Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 13 2020 18:05
    adamw commented #64
  • Jan 13 2020 17:23
    agilesteel commented #64
  • Jul 10 2019 11:04
    lrytz opened #65
  • Jun 28 2019 13:37
    adamw commented #64
  • Jun 27 2019 22:50
    bjchambers opened #64
  • Mar 14 2019 17:25

    kciesielski on 0.6.1

    (compare)

  • Mar 14 2019 16:55

    kciesielski on master

    Update sbt to 0.13.7 Add a predefined constant for n… (compare)

  • Mar 14 2019 13:23
    nonsleepr opened #63
  • Mar 13 2019 13:34
    nonsleepr commented #49
  • Mar 12 2019 14:53

    kciesielski on master

    Fix fatal warnings example (compare)

  • Feb 20 2019 09:59
    adamw commented #30
  • Feb 20 2019 01:58
    nafg commented #30
  • Jan 31 2019 08:09

    kciesielski on master

    Adjust tests (compare)

  • Jan 31 2019 07:51

    kciesielski on v0.6.0

    (compare)

  • Jan 31 2019 07:49

    kciesielski on master

    Support fatal warnings Update version to 0.6.0 Allow defining fatal warnings w… and 1 more (compare)

  • Dec 14 2018 07:22
    adamw commented #62
  • Dec 14 2018 02:40
    acruise opened #62
  • Sep 23 2018 17:36
    quasi-coherent commented #57
  • May 11 2018 11:17
    adamw commented #57
  • May 10 2018 06:56
    michelemauro commented #57
Shane Delmore
@ShaneDelmore
Either way, if it hurts I say it's worth opening an issue.
chris vale
@crispywalrus
so I had intended to start this conversation in emacs-ensime rather than the cats gitter. I’m guessing it’s something in ensime that changes since it didn’t properly corelate with an clippy update
I’m going to drill into ensime first and if don’t make any progress I’ll come back to clippy
Shane Delmore
@ShaneDelmore
@crispywalrus Sounds good, but if we need to work together with ensime to get it sorted let us know. I have a knee surgery tomorrow so I will be offline for a few days but if you don't hear back for a few know that I will get back to you.
chris vale
@crispywalrus
well good luck with that. I’d like to get this working again as I find value in both tools
Shane Delmore
@ShaneDelmore
:+1:
Adam Warski
@adamw
@crispywalrus we had a bit similar issue with SBT, as SBT was assuming a specific implementation of the reporter (which we have a custom implementation of). So maybe here the presentation compiler does the same - although I'm not using Ensime, so hard to say. If you won't find anything, please file a bug report :)
Krzysiek Ciesielski
@kciesielski
I just stumbled upon the ensime issue yesterday
I'm using ensime SNAPSHOT so maybe it's something new :)
Defenitely something we need to look at. We managed to work around this in SBT with some dirty tricks (and it still happens but very rarely)
not nice when some code does a casting of a Reporter to some concrete type it expects it to be
chris vale
@crispywalrus
I’ve moved the compiler version and clippy version around (couldn’t try the 0.3.0 suggestion as the code is build using 2.12 and used dependencies only available in 2.12 so …) it always comes down to https://github.com/scala/scala/blob/v2.12.1/src/compiler/scala/tools/nsc/Global.scala#L1519 or similar in the compiler during the presentation compiler run.
should InjectReporter be a GlobalPhase or is it somehow ending up in the list improperly?
higher up in the calls stack interactive.Global there’s comments suggesting that sbt does inject phases into compilation and there’s some need for the compiler to be careful about this
In the end I can compile with clippy enabled but not use the presentation compiler … which breaks ensime
Adam Warski
@adamw
@crispywalrus not sure what's the intended meaning of GlobalPhase - but maybe that's something clippy could extend/implement?
Our phases are quite simple
chris vale
@crispywalrus
I don’t know what clippy is doing or needs to do in this case. Thing is that it all works when using the compiler proper but not the presenation compiler. I’m convinced this is some subtle difference between the presentation compiler and the compiler proper.
Oron Port
@soronpo
Is there a plan to support Scala 2.13?
Vladyslav Pekker
@agilesteel
Is this room still alive? :) Scala 2.13 is a good question. Is there an answer?
Vladyslav Pekker
@agilesteel
Vladyslav Pekker
@agilesteel
@adamw @kciesielski is anyone alive here? :)
Vladyslav Pekker
@agilesteel
I was wondering how to do sth like clippyColorType := Some(ClippyColor.None) without the sbt plugin... I figured out this much: scalacOptions ++= Seq("-P:clippy:colors=true") and then tried P:clippy:color:type=none and a few other variations without luck... any help?
Krzysiek Ciesielski
@kciesielski
Hi there, sorry for long silence, I'm going to start implementing a version for 2.13 in a few days
vonchav
@voonchav_gitlab
@kciesielski Is there a plan to support 2.13? :)
Krzysiek Ciesielski
@kciesielski
Unfortunately it's still pending :(