Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 10 11:04
    lrytz opened #65
  • Jun 28 13:37
    adamw commented #64
  • Jun 27 22:50
    bjchambers opened #64
  • Mar 14 17:25

    kciesielski on 0.6.1

    (compare)

  • Mar 14 16:55

    kciesielski on master

    Update sbt to 0.13.7 Add a predefined constant for n… (compare)

  • Mar 14 13:23
    nonsleepr opened #63
  • Mar 13 13:34
    nonsleepr commented #49
  • Mar 12 14:53

    kciesielski on master

    Fix fatal warnings example (compare)

  • Feb 20 09:59
    adamw commented #30
  • Feb 20 01:58
    nafg commented #30
  • Jan 31 08:09

    kciesielski on master

    Adjust tests (compare)

  • Jan 31 07:51

    kciesielski on v0.6.0

    (compare)

  • Jan 31 07:49

    kciesielski on master

    Support fatal warnings Update version to 0.6.0 Allow defining fatal warnings w… and 1 more (compare)

  • Dec 14 2018 07:22
    adamw commented #62
  • Dec 14 2018 02:40
    acruise opened #62
  • Sep 23 2018 17:36
    quasi-coherent commented #57
  • May 11 2018 11:17
    adamw commented #57
  • May 10 2018 06:56
    michelemauro commented #57
  • May 09 2018 14:58
    dragos commented #57
  • Feb 02 2018 10:18
    avdv opened #61
Shane Delmore
@ShaneDelmore
I found this issue related to Path, unless there is objection I will just make a pr and file it away under this issue. http4s/http4s#559
Krzysiek Ciesielski
@kciesielski
@ShaneDelmore Sounds very interesting with the dotty highlighter. Are you sure the http4s path issue relates to Clippy?
@ochrons Are you using windows? Because this looks like softwaremill/scala-clippy#40
Otto Chrons
@ochrons
yeah
Krzysiek Ciesielski
@kciesielski
We are going to add support for custom Ansi RESET color, so windows users can set it to light-grey or whatever. For some reason it doesn't work well on Windows (when used with Li Haoyi's fansi lib)
Otto Chrons
@ochrons
Win10 and mingw bash under ConEmu terminal
Krzysiek Ciesielski
@kciesielski
@ochrons you can use clippy 0.5.1-SNAPSHOT as a workaround for now (described in issue). We'll soon add the mentioned option as a proper fix.
Otto Chrons
@ochrons
ok, will try at some point :)
Shane Delmore
@ShaneDelmore
@kciesielski User error, that was meant for the https room
@kciesielski not at all related to clippy.
Greg Pfeil
@sellout
So, is there a way I can conditionally disable clippy for certain projects via my ~/…/global.sbt? Like if (sbt.project == "scala") scalacOptions += "-P:clippy:enable=false"?
Shane Delmore
@ShaneDelmore
I'm getting the following error again. Anyone else? Information:scalac: Unable to load/store local Clippy advice due to: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
Shane Delmore
@ShaneDelmore
The error cleared up. I have no idea why. Weird.
prateekmane99
@prateekmane99
I have added addCompilerPlugin("com.softwaremill.clippy" %% "plugin" % "0.5.2" classifier "bundle") in my sbt
I cant see Clippy errors in my console
Shane Delmore
@ShaneDelmore
What error are you using to test?
Oron Port
@soronpo
Does clippy replace scalac errors or just adds information?
Adam Warski
@adamw
@soronpo only adds information. The original error is always there
Oron Port
@soronpo
What do you think of adding an optional flag that sets if we want the original error message to replaced?
Adam Warski
@adamw
@soronpo well, what would be the use-case? :)
Oron Port
@soronpo
I'm creating a DSL and
some of its users will be less confused that way
Adam Warski
@adamw
well there are mechanisms like @implicitNotFound for customizing error messages. I'd be cautious in replacing the original error message entirely, I suppose we would need to have a good motivating example to include that
Oron Port
@soronpo
@adamw On one hand, @implicitNotFound is very limited, and on the other hand, the missing implicit messages for my library are too verbose. This is not a must feature, but if a library owner has an optional flag for that, I do not see the harm.
Crucial feature that I am currently missing is the ability to grab text from the original message and place it in the new/hint message.
chris vale
@crispywalrus

I’ve started seeing this

21:06:25.829 DEBUG akka://ENSIME/user/ensime-main/tcp-server/con1/3 o.e.s.RequestHandler - received handled message SymbolDesignations(RawFile(.),List()) from Actor[akka://ENSIME/user/ensime-main/project/scalac#1727592554] in state receive
java.lang.ClassCastException: com.softwaremill.clippy.InjectReporteranonanon1 cannot be cast to scala.tools.nsc.Global$GlobalPhase
at scala.tools.nsc.Global$Run.$anonfun$compileLate$3(Global.scala:1519)
at scala.tools.nsc.Global$Run.$anonfun$compileLate$2(Global.scala:1519)
at scala.tools.nsc.Global$Run.$anonfun$compileLate$2$adapted(Global.scala:1518)
at scala.tools.nsc.Global$Run$$Lambda$1471/168254663.apply(Unknown Source)
at scala.collection.Iterator.foreach(Iterator.scala:929)
at scala.collection.Iterator.foreach$(Iterator.scala:929)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1406)
at scala.tools.nsc.Global$Run.compileLate(Global.scala:1518)
at scala.tools.nsc.interactive.Global.parseAndEnter(Global.scala:645)
at scala.tools.nsc.interactive.Global.$anonfun$backgroundCompile$4(Global.scala:554)
at scala.tools.nsc.interactive.Global.$anonfun$backgroundCompile$3(Global.scala:551)
at scala.tools.nsc.interactive.Global.backgroundCompile(Global.scala:551)
at scala.tools.nsc.interactive.PresentationCompilerThread.run(PresentationCompilerThread.scala:25)

interaction between clippy (or so it appear) and ensime. Commenting out clippy (which I’ve been loading via my global sbt plugins) resolves the issue but at quite a loss.

Shane Delmore
@ShaneDelmore
Does the issue happen with 0.5.2?
I don't use ensime but added a feature in 0.5.3 and am worried there might be a conflict.
Although I don't know anything about how the reporter is injected, that was another contributor who worked on that but I do remember it changing a few releases back when the nice coloring was added.
chris vale
@crispywalrus
so that answer to that is yes, it fails with 0.5.2 in the same manner
Shane Delmore
@ShaneDelmore
Hmm...no idea then. Just for troubleshooting purposes you could try loading an old pre-new reporter version, say 0.3.0 to see if that still has the issue. But it sounds related to the new reporter and I have no familiarity with that area but I may be able to help in a few days.
Either way, if it hurts I say it's worth opening an issue.
chris vale
@crispywalrus
so I had intended to start this conversation in emacs-ensime rather than the cats gitter. I’m guessing it’s something in ensime that changes since it didn’t properly corelate with an clippy update
I’m going to drill into ensime first and if don’t make any progress I’ll come back to clippy
Shane Delmore
@ShaneDelmore
@crispywalrus Sounds good, but if we need to work together with ensime to get it sorted let us know. I have a knee surgery tomorrow so I will be offline for a few days but if you don't hear back for a few know that I will get back to you.
chris vale
@crispywalrus
well good luck with that. I’d like to get this working again as I find value in both tools
Shane Delmore
@ShaneDelmore
:+1:
Adam Warski
@adamw
@crispywalrus we had a bit similar issue with SBT, as SBT was assuming a specific implementation of the reporter (which we have a custom implementation of). So maybe here the presentation compiler does the same - although I'm not using Ensime, so hard to say. If you won't find anything, please file a bug report :)
Krzysiek Ciesielski
@kciesielski
I just stumbled upon the ensime issue yesterday
I'm using ensime SNAPSHOT so maybe it's something new :)
Defenitely something we need to look at. We managed to work around this in SBT with some dirty tricks (and it still happens but very rarely)
not nice when some code does a casting of a Reporter to some concrete type it expects it to be
chris vale
@crispywalrus
I’ve moved the compiler version and clippy version around (couldn’t try the 0.3.0 suggestion as the code is build using 2.12 and used dependencies only available in 2.12 so …) it always comes down to https://github.com/scala/scala/blob/v2.12.1/src/compiler/scala/tools/nsc/Global.scala#L1519 or similar in the compiler during the presentation compiler run.
should InjectReporter be a GlobalPhase or is it somehow ending up in the list improperly?
higher up in the calls stack interactive.Global there’s comments suggesting that sbt does inject phases into compilation and there’s some need for the compiler to be careful about this
In the end I can compile with clippy enabled but not use the presentation compiler … which breaks ensime
Adam Warski
@adamw
@crispywalrus not sure what's the intended meaning of GlobalPhase - but maybe that's something clippy could extend/implement?
Our phases are quite simple
chris vale
@crispywalrus
I don’t know what clippy is doing or needs to do in this case. Thing is that it all works when using the compiler proper but not the presenation compiler. I’m convinced this is some subtle difference between the presentation compiler and the compiler proper.
Oron Port
@soronpo
Is there a plan to support Scala 2.13?