softwaremill/sttp

Glen Marchesani

@fizzy33

So for my issue I added this (a memoize on the backend task which makes sense (I only need one backend AFAICT) --

val instance: Task[sttp.client.SttpBackend[Task, monix.reactive.Observable[java.nio.ByteBuffer], WebSocketHandler]] =
    AsyncHttpClientMonixBackend().memoize

1 reply

Glen Marchesani

@fizzy33

yeah that fixed it for me

Glen Marchesani

@fizzy33

anyone recommend code for taking a

    val webSocketT: Task[WebSocket[Task]] = ...

12 replies

and getting a

      lazy val frames: Observable[WebSocketFrame.Incoming] =

using monix

here is what I have


      lazy val frames: Observable[WebSocketFrame.Incoming] = {
        Observable.unsafeCreate[WebSocketFrame.Incoming] { subscriber =>

          val cancelable = AssignableCancelable.multi()

          def feedOnNext(): Unit = {
            val receiveT: Task[(Either[WebSocketEvent.Close, WebSocketFrame.Incoming], WebSocket[Task])] =
              webSocketT
                .flatMap { webSocket =>
                  webSocket
                    .receive
                    .map(_ -> webSocket)
                }
            cancelable :=
              receiveT
                .runAsync {
                  case Left(error) =>
                    subscriber.onError(error)
                  case Right((Left(close), _)) =>
                    if ( logger.isTraceEnabled )
                      logger.trace(s"received close ${close}")
                    subscriber.onComplete()
                  case Right((Right(frame), webSocket)) =>
                    subscriber
                      .onNext(frame)
                      .syncOnContinue(feedOnNext())
                      .syncOnStopOrFailure {
                        case Some(th) =>
                          logger.error(s"error processing ${frame}", th)
                          feedOnNext()
                        case None =>
                          if ( logger.isTraceEnabled)
                            logger.trace(s"stop received closing WebSocket")
                          webSocket.close.runAsyncAndForget
                      }
                }
          }

          feedOnNext()
          cancelable
        }
      }

Glen Marchesani

@fizzy33

any comments are appreciated

Glen Marchesani

@fizzy33

okay here is something that doesn't do "unsafe" things

      lazy val frames: Observable[WebSocketFrame.Incoming] = {
        val receiveT: Task[(Either[WebSocketEvent.Close, WebSocketFrame.Incoming], WebSocket[Task])] =
          webSocketT
            .flatMap { webSocket =>
              webSocket
                .receive
                .map(_ -> webSocket)
            }

        val receiveForObservableT: Task[(Either[WebSocketEvent.Close, WebSocketFrame.Incoming], Unit)] = receiveT.map(t => (t._1, ()))

        val observable: Observable[Either[WebSocketEvent.Close, WebSocketFrame.Incoming]] = Observable.fromAsyncStateAction[Unit,Either[WebSocketEvent.Close, WebSocketFrame.Incoming]](_ => receiveForObservableT)(())

        observable
          .takeWhile(_.isRight)
          .collect {
            case Right(f) =>
              f
          }
      }

6 replies

Mark Hammons

@markehammons

Hi, I'm having some weird behavior from sttp3 in some cases

when making a POST to 198.51.100.0 (which is supposed to be an invalid ipv4 address), I get a ReadException while I expected sttp to give me a ConnectException.

furthermore, sttp waits until the timeout has been reached to send a ReadException

Mark Hammons

@markehammons

I'm using the sttp3 monix async http backend by the way

5 replies

truongio

@truongio

Hi! I'm trying to integrate with an external API that only accepts form encoded request bodies (application/x-www-form-urlencoded). Do you have any recommendations on how to do this mapping from my case classes to such a body without having to manually create a Map[String, String] for each case class?

1 reply

Arun Gopalpuri

@arun0009

Is there an opentelemetry backend wrapper similar to opentracing wrapper? https://sttp.softwaremill.com/en/latest/backends/wrappers/opentracing.html

5 replies

ylaurent

@ylaurent

Hello, I am trying client3 with zio (scala 2.13.3 and zio 1.0.3, sttp 3.0.0-RC5), following the example here https://sttp.softwaremill.com/en/latest/examples.html (GET and parse JSON using the ZIO async-http-client backend and circe), I get at runtime

[info]   Fiber failed.
[info]   An unchecked error was produced.
[info]   java.lang.Error: Defect in zio.Has: Set(SttpBackend[=λ %2:0 → ZIO[-Any,+Throwable,+2:0],+{ZioStreams & package::WebSockets}]) statically known to be contained within the environment are missing
[info]       at zio.Has$HasSyntax$.prune$extension(Has.scala:197)
[info]       at zio.Has$HasSyntax$.union$extension(Has.scala:209)
[info]       at zio.Has$Union$$anon$2.union(Has.scala:91)
[info]       at zio.Has$Union$$anon$2.union(Has.scala:89)

Anything I am missing ? when I am not using layer, and just directly the backend its working properly.

9 replies

Denis Mikhaylov

@notxcain

Hi! Do you plan to release https://mvnrepository.com/artifact/com.softwaremill.sttp.client3/httpclient-backend_0.26 for 2.12 ?

2 replies

Lorenzo Gabriele

@lolgab

Hi everyone :)
Are you interested in a upickle/ujson integration like the circe one? Can I submit a PR?

4 replies

user753

@user753

hi. I would like to use okhttp backend with cats IO. Is it possible to transform SttpBackend[Future, Nothing, WebSocketHandler] to SttpBackend[IO, Nothing, WebSocketHandler] or separate backend should be created?

1 reply

Pavel Yurgin

@payurgin

I trying to implement sttp backend for prometeus metrics.
I want to report statusCode as one of the label for metric. But I noticed that if request fails with DeserializationError, all metadata of response (headers, status code and other) will be lost.
@adamw WDYT about adding optional ResponseMetadata to ResponseError ?

2 replies

Leszek Gruchała

@leszekgruchala

Hi. I am using STTP with ZIO. It's a bit unclear to me if STTP calls should be wrapped with effectBlocking. I think not as otherwise Blocking would be simply required by sttp-zio integration. I guess STTP has it's own execution context, but maybe it's still good to tell ZIO this is a blocking operation?

12 replies

Vasily Shiyan

@xicmiah

How do you ensure that streams close when using v3 asStreamUnsafe? Obviously this is backend/stream-specific, but some hints would help.
For example in proxy-ish scenario, using httpclient-backend-fs2, get IO[Stream[IO, T]] from sttp, add some in-flight transformations, stream results in http response via http4s. I think this scenario cannot be expressed with safe asStream.

2 replies

Anton Kulaga

@antonkulaga

I am having issues with sending requests to download files on FTP via syncronius backend, could you suggest what is the recommended way of downloading files?

2 replies

almoehi

@almoehi

Hi - I'm trying to get a minimal working example of sttp3 (akka backend) + websocket + asWebSocketStreamAlways. The client is connecting but it's not sending or receiving anything. This is how I'm using it right now - what am I missing here ?

def webSocketFramePipe: Flow[WebSocketFrame.Data[_], WebSocketFrame, NotUsed] = Flow[WebSocketFrame.Data[_]].map{
    case o @ WebSocketFrame.Text(str, _, _) =>
      println(s"received string: $str")
    case other =>
      println(s"received other: $other")
      other
}

val inputSrc: Source[ByteString, Any] = ... // ie Seq("test1", "test")

basicRequest
.get(uri)
.streamBody(AkkaStreams)(inputSrc)
.response(asWebSocketStreamAlways(AkkaStreams)(webSocketFramePipe))
.send(backend)
.onComplete(_ => backend.close())

5 replies

Binh Nguyen

@ngbinh

Hi, anyone know if OpenAPI generator https://sttp.softwaremill.com/en/latest/openapi.html work with sttp 3.X? I tried the example repo https://github.com/softwaremill/sttp-openapi-example but looks like it only work with sttp 2.X

1 reply

Bruno Campos

@brucampos88_twitter

HI… I am trying to use PrometheusBackend with Cats backend but it looks like it is not supported. It works fine with Monix backend.

AsyncHttpClientMonixBackend().map(backend => PrometheusBackend(backend)) // OK

AsyncHttpClientCatsBackend[cats.effect.IO]().map(backend => PrometheusBackend(backend)) 

       error: type mismatch;
        found   : sttp.client.SttpBackend[cats.effect.IO,Nothing,sttp.client.asynchttpclient.WebSocketHandler]
        required: sttp.client.SttpBackend[[+A]cats.effect.IO[A],S,[WS_RESULT]sttp.client.asynchttpclient.WebSocketHandler[WS_RESULT]]
       Error occurred in an application involving default arguments.
sttp.client.SttpBackend[cats.effect.IO,Nothing,sttp.client.asynchttpclient.WebSocketHandler] <: sttp.client.SttpBackend[[+A]cats.effect.IO[A],S,[WS_RESULT]sttp.client.asynchttpclient.WebSocketHandler[WS_RESULT]]?
false

Am I missing something?

ybasket

@ybasket

Looks fine. Try to specify the type explicitly, so PrometheusBackend[IO, Nothing, sttp.client.asynchttpclient.WebSocketHandler]

Bruno Campos

@brucampos88_twitter

:thumbsup:

barthorre

@barthorre

Hi, are there some code examples for sttp 3 available apart from the ones https://github.com/softwaremill/sttp/blob/master/examples/src/main/scala/sttp/client3/examples/ that might demonstrate on how to connect 2 zio streams to a websocket? 1 being the request send to the websocket server and 1 reading the responses that come back?

4 replies

barthorre

@barthorre

Does anyone know how to put the subprotocols for a websocket connections using HttpClientBackend?

private def apply(
      client: HttpClient,
      closeClient: Boolean,
      customizeRequest: HttpRequest => HttpRequest,
      customEncodingHandler: ZioEncodingHandler
  ): SttpBackend[Task, ZioStreams with WebSockets] =

in akka there seems to be an other function you can pass

private def make(
      actorSystem: ActorSystem,
      ec: ExecutionContext,
      terminateActorSystemOnClose: Boolean,
      options: SttpBackendOptions,
      customConnectionPoolSettings: Option[ConnectionPoolSettings],
      http: AkkaHttpClient,
      customizeRequest: HttpRequest => HttpRequest,
      customizeWebsocketRequest: WebSocketRequest => WebSocketRequest = identity,
      customEncodingHandler: EncodingHandler = PartialFunction.empty

allowing to set the subprotocol

for http client this seem to be missing

also setting the header Sec-WebSocket-Protocol results in an Illegal Header exception

Adam Warski

@adamw

I can't recall having any tests or supporting ws subprotocols, so it's possible the support is simply not there

you'd have to check if HttpClient supports this at all and then we can try to fix this in sttp

barthorre

@barthorre

  val wsBuilder = client.newWebSocketBuilder()
          client.connectTimeout().map[java.net.http.WebSocket.Builder](wsBuilder.connectTimeout(_))
          request.headers.foreach(h => wsBuilder.header(h.name, h.value))
          val cf = wsBuilder
            .buildAsync(request.uri.toJavaUri, listener)
            .thenApply[Unit](_ => ())
            .exceptionally(t => cb(Left(t)))
          Canceler(() => cf.cancel(true))
        })

19 replies

here you could do wsBuilder.subprotocols afaik

catostrophe

@catostrophe

@adamw hi. do you have any concrete plans regarding the 3.0.0 stable release date? days/weeks/months?

3 replies

Zsolt Szilagyi

@esgott

Hi all
I'm looking at the new v3 API, and there is one thing that caught my eye. In SttpBackend trait, the documentation for send states

Type parameters: R – The capabilities required by the request. This must be a subset of the the capabilities supported by the backend (which always includes Effect[F]).

, which makes sense. However when I'm looking at AkkaHttpBackend, the type returned is SttpBackend[Future, AkkaStreams with WebSockets], so Effect[Future] is not included. Shouldn't that be there?

3 replies

Adam Warski

@adamw

Thank you for being part of the sttp community - Merry Christmas & a more regular 2021 ;)

sttp 3.0 is coming up beginning next year, along with Scala 3!

Rohan Sircar

@rohan-sircar

Merry Christmas Adam! Eager to see the release of Scala 3 and sttp 3. Also, I understand quicklens and macwire will take time since they need to be rewritten in scala3 macros, but I hope they do get ported to scala 3 in future.

2 replies

Adam Warski

@adamw

sttp client 3.0.0 got released, enjoy :) thanks for all the contributions & testing!

Philipp Dörfler

@phdoerfler

congrats! :)

Philipp Dörfler

@phdoerfler

I'm currently idiot-testing 3.0.0's akka websockets, so I created a minimal build.sbt and copy pasted this example:
https://sttp.softwaremill.com/en/latest/examples.html#open-a-websocket-using-akka

It doesn't compile! It complains:

Symbol 'type akka.event.LoggingAdapter' is missing from the classpath.
This symbol is required by 'value sttp.client3.akkahttp.AkkaHttpBackend.customLog'.
Make sure that type LoggingAdapter is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.

The akka documentation says for logging you need: "com.typesafe.akka" %% "akka-actor" % "2.6.10"
However, I saw that sttp3's akka-http-backend has this listed as provided so I went with that instead: "com.typesafe.akka" %% "akka-stream" % "2.6.10"

It compiles, but I get 0 output when I run the example. No error, no nothing.

build.sbt:

name := "meep"
scalaVersion := "2.13.4"

libraryDependencies ++= Seq(
  "com.softwaremill.sttp.client3" %% "core" % "3.0.0",
  "com.softwaremill.sttp.client3" %% "akka-http-backend" % "3.0.0",
  "com.typesafe.akka" %% "akka-stream" % "2.6.10"
)

4 replies

Philipp Dörfler

@phdoerfler

Playing this game with the monix example, I get this SSL exception when running:

runMain sttp.client3.examples.WebSocketMonix
[info] running sttp.client3.examples.WebSocketMonix
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[error] (run-main-4) sttp.client3.SttpClientException$ConnectException: Exception when sending request: GET wss://echo.websocket.org
[error] sttp.client3.SttpClientException$ConnectException: Exception when sending request: GET wss://echo.websocket.org
[error] Caused by: java.net.ConnectException: handshake timed out after 10000ms
[error] Caused by: io.netty.handler.ssl.SslHandshakeTimeoutException: handshake timed out after 10000ms

(I've omitted the stack trace elements in between due to gitter's message limits)

Where communities thrive

People

Repo info

Activity