by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 2015 18:55

    sokra on master

    delayed watching (compare)

  • Jan 20 2015 17:58

    sokra on master

    Added Gitter badge Merge pull request #1 from gitt… (compare)

  • Jan 20 2015 17:58
    sokra closed #1
  • Jan 20 2015 17:56
    gitter-badger opened #1
Tobias Koppers
@sokra
@kentcdodds You gave the perfect hint... ;)
Kent C. Dodds
@kentcdodds
:blush: just console.logging :-)
Tobias Koppers
@sokra
I write an issue...
Tobias Koppers
@sokra
paulmillr/chokidar#216
@kentcdodds The ^C in your log indicates that closing the watcher doesn't end the process... It should exit the process when finished...
Kent C. Dodds
@kentcdodds
that’s right
I had to ^C to exit, it didn’t exit automatically
Tobias Koppers
@sokra
That's an additional issue...
Kent C. Dodds
@kentcdodds
I only waited for two or three seconds
I’ll try it again
the test also took several seconds to run (I haven’t looked to see if that was inteneded)
Yeah, it’s not exiting automatically for me… Been 10 seconds now
yeah, looks like the test is inteded to run at one second intervals, so the test is running fine (asside from failing), but yeah, it’s not closing automatically.
Can somebody try the chokidar master branch?
Kent C. Dodds
@kentcdodds
I’ll give it a go.
hmmm…. I don’t think it’s fixed…..
but I’m not sure that I correctly tried it out with the master branch….
what’s the best way to update the node module to master?
Elan Shanker
@es128
npm i paulmillr/chokidar
Kent C. Dodds
@kentcdodds
I attempted to npm i --save git://github.com/paulmillr/chokidar.git#f4c49296b708c6901429a6497b31a8b907bdd8c0
Elan Shanker
@es128
I'm about to give it a try too
Kent C. Dodds
@kentcdodds
that hash is the latest commit
Elan Shanker
@es128
just having cloned the test repo, I'm getting expected behavior regarding the add/change events using both 0.12.6 and master... I'm on Yosemite
but I am reproducing the issue with the process staying open.. digging into why that is first
Kent C. Dodds
@kentcdodds
Sorry, it’s the process staying open that I was talking about :-/
haha, sorry for the confusion. I thought that’s what was fixed, so I didn’t even notice that the original issue was resolved. :-)
Tobias Koppers
@sokra
What's about the add/update issue? @kentcdodds
Kent C. Dodds
@kentcdodds
Just tested it out. Works great on my project. THanks @es128!
Tobias Koppers
@sokra
master or 0.12.6?
Kent C. Dodds
@kentcdodds
… wait… no, I think that my local webpack is still using an older version...
I’m not sure how that dependency is resolved. If I npm install chokidar, it’s added to my own node_modules, but watchpack is still using it’s own copy right?
Give me another second to check
if I npm i paulmiller/chokidar in the watchpack directory, it should update that module’s dependency right?
Tobias Koppers
@sokra
yes
Kent C. Dodds
@kentcdodds
ok, one sec.
totally works :-)
Tobias Koppers
@sokra
ok cool... so we just need a new release @es128 :smile:
Kent C. Dodds
@kentcdodds
and with 600 files, it’s incredibly lightning fast as always.
:shipit:
Tobias Koppers
@sokra
CPU usage?
Kent C. Dodds
@kentcdodds
should there be?
nothing noticeable I think
Tobias Koppers
@sokra
:smile: good work @es128
Elan Shanker
@es128
cpu will be unnoticeable when using fsevents on OS X... still trying to figure out the process closing issue
but yeah regarding release, 1.0.0 will be coming very soon
Elan Shanker
@es128
pipobscure/fsevents#50 the process closing thing is a new issue on the fsevents side, introduced when io.js compatibility was added. Now that it's been noticed, probably won't take much to resolve it, but not something I have control over
Tobias Koppers
@sokra
ok thx for investigating...
That's not something that is problematic, because we never stop watching...
Christoffer Wolgast
@Chrazy
looks like I came in to this a bit late, but great that you managed to locate the problem and get it fixed!