Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tim Berners-Lee
    @timbl
    Yes also agree about the client quietly making thumbnails of various sizes of profile pictures and probably other pictures too. Also we can add a separate banner background picture maybe
    David
    @scenaristeur
    @Julian-Cole sure i could adapt Shighl lib to match 50 messages but i don't understand what is the problem with more than 50 . Is it the post operations (retrieve name /pic of sender ) ? If yes, this is not a problem of length of chat.ttl file, but a problem of caching the name/pic of users instead of retriving them each time. If we make 50 messages files, who would build the second &third.. files ? The server ? I don't think it is it's role to say 'oh there are more than 50' i must create a new one! The client ? It will not simplify the implementation... When the client will want to write a new file... Oh there are more than 50 in the chat.ttl, let's create a second .. oh it already exists, how messages in it ? Ho more than 50... And so one... It will make many many more request to post and to retrieve messages... I don't think it's a good idea...
    David
    @scenaristeur
    It's already too much in my opinion to have subfolders 2020/08/19/chat.ttl 2020/08/18/chat.ttl with 404 if the file doesn't exist... Why not using in the main folder 2020-08-19.ttl 2020-08-18.ttl this way we can get a list of all existing file/day in one request with solid-file-client/readfolder . Then it's easy to load each one when the infinite scroll come to bottom. With 50 file per message it will be harder to know which file to load chat1.ttl, chat2.ttl, ...
    ??
    Another day ? Which day ?
    David
    @scenaristeur
    When you open the chat, where is the last message ? In chat7.ttl ? chat8.ttl?
    Jules Cole
    @Julian-Cole
    "Is it the post operations (retrieve name /pic of sender )" no. Do you not see any possible ui performance hit / unnecessary resource loading when you read and parse a full day of chat each site visit, as opposed to just reading 50 messages at a time each visit? why does gitter only seem to read 47 messages at a time?
    Jules Cole
    @Julian-Cole
    If you get the file count of folder 2020/08/19 and there are 5 files you load chat5.ttl; 2 files=chat2.ttl; 1 file=chat.ttl
    Michiel de Jong
    @michielbdejong
    This might come in handy, I created it so that we can put a "Chat with me" button on every Solid user's home page: solid/chat-pane#45
    David
    @scenaristeur
    @Julian-Cole sorry but as already said, performance issue is not due to more than 50 messages, but retriving name & pic form user . With Shighl, If one user post 10 messages we go 10 times get its name & 10 times get its pic https://github.com/scenaristeur/shighl/blob/9b4b61d06d8a20f55de3f2aa580cbc5fb840d584/src/Shighl-chat.js#L131 performance can be optimized by caching them
    And using Tripledoc instead of ldflex could be a better way reading files. 50 messages per file will complicate everything. The first thing is to review Shighl lib before make it more complicated...
    David
    @scenaristeur
    @michielbdejong nice, should the the user change it's inbox acl to receive notification?
    @Julian-Cole on the other side i'm agree to the different size of pictures 🙂👍
    Another perf issue, could also be the json + websocket you developed on each user pod. I would rather use a connected_users.ttl on the chat folder that would be updated on each connect/disconnect... So you only have one websocket instead of one per user 🤗
    Jules Cole
    @Julian-Cole
    @scenaristeur "@Julian-Cole on the other side i'm agree to the different size of pictures 🙂👍" well 1 idea out of 2 isn't too bad! lol
    Jules Cole
    @Julian-Cole
    I did bench-test the call for just the chat on it's own without the extras etc; but you still have to potentially stream all the file with all the messages to get to the new ones at the bottom; ideally you want the ui to display and populate within 3 secs.
    Jules Cole
    @Julian-Cole
    Perhaps the best thing to do is just try it and see. (leave out loading of the avatar pics for the test)
    David
    @scenaristeur
    @Julian-Cole my last chat version with infinite scroll is at https://scenaristeur.github.io/solid-vue-panes/ then Communication / Chat if you want to bench
    Michiel de Jong
    @michielbdejong
    @scenaristeur what do you think of the invites I used in https://github.com/solid/chat-pane/blob/master/src/create.ts#L22-L40 ?
    and does your app do something like https://github.com/solid/chat-pane/blob/master/src/index.js#L37 to discover the user's LongChat instances from their privateTypeIndex?
    David
    @scenaristeur
    @michielbdejong not from private but public for the moment https://github.com/scenaristeur/solid-vue-panes/blob/f78a22bbf94d08fce561c05b5ce8eac4f567927c/src/mixins/profileMixin.js#L66 and but i must review the add process
    @michielbdejong the main problem i think with inbox/notif/invite is that by default, acl are not configured to accept anyone/any app as poster, so you won't be able to invite someone that never manually change this settings, i am wrong?
    Michiel de Jong
    @michielbdejong
    @scenaristeur there is an exception for Public ACLs, so if for instance to /inbox/ you can POST without sending any authorization header, then you also don't have to match any Origin header criteria. So it does work, sending to anyone.
    David
    @scenaristeur
    @michielbdejong so i'm wrong, i will retry with POST 😉. The second main problem is to be sure that the poster is the good one. I don't think this has been resolved : when we worked on Solidarity, @angelo-v posted a message with schema:sender @timbl and we thought it was posted by tim... I can't find the issue yet but it's a big server side problem... For chat /inbox. Do you think it has been / could be resolved?
    @michielbdejong does the invite create a new chat channel ? On which pod ?
    David
    @scenaristeur
    @michielbdejong "you can POST without sending any authorization header" but it only works if the app is in trusted app ?
    David
    @scenaristeur
    image.png
    image.png
    image.png
    David
    @scenaristeur
    @michielbdejong i can't send to you even with solid-file-client (createFile or postFile) or the new https://docs.inrupt.com/client-libraries/solid-client-js/tutorial/read-write-files.html#write-a-file-directly-at-a-url ... any idea ? is it because you have never add popock to trustedapps ?
    Michiel de Jong
    @michielbdejong
    Ah, not PUT. That would require acl:Write. Use POST instead
    David
    @scenaristeur
    @michielbdejong yeah, seems ok with solid-file-client postFile, but i also need to append in log.ttl file for using websocket . I will try to store that log.ttl file outside the inbox folder
    https://github.com/scenaristeur/solid-vue-panes/blob/56dfb4caf4d8de3096e06e47e2c4d247496e37ff/src/components/inbox/Inbox.vue#L191 . Thxs for tour help
    Jules Cole
    @Julian-Cole
    @scenaristeur "my last chat version with infinite scroll is at https://scenaristeur.github.io/solid-vue-panes/ then Communication / Chat if you want to bench" I think in most chat apps the most recent message is placed at the bottom, and you use mouse-scroll-up or (swipe-down) to go through older messages, but you seem to have the most recent chat at the top and a scroll-down for older messages?
    although the way you've implemented it (direction and placement) is ok for a "social" type infinite scroller.
    Matthias Evering
    @ewingson
    I have done ongoing, multiple and extensive tests with the chat-with-me button vice versa with two accounts. first try I had multiple participants. resolved by deleting with data-browser. then had multiple messages, although only clicking once. deleting the messages-by-error and changing the browser from firefox to chrome, I succeeded to send unique messages from solidweb.org to solid.community and vice versa. seems definately functional.
    Matthias Evering
    @ewingson
    working now with both browsers
    Michiel de Jong
    @michielbdejong
    @ewingson so any more bugs that you are aware of?
    I noticed that it displays a "Chat with me" button when you view your own profile, which might be useful ("note to self"?) but at least we should change the text there to "Chat with yourself ;)"
    Matthias Evering
    @ewingson
    @michielbdejong then we must do a case differentiation ;-) so: I' m not sure if thats a local problem, but it occurred several times that duplicate messages were sent although only clicking once
    Bildschirmfoto vom 2020-08-25 00-01-03.png
    Michiel de Jong
    @michielbdejong
    hm
    I'll see if I can reproduce that
    @ewingson is wss://michielbdejong.solidweb.org/ blocked by your proxy?
    A message should never be created 3 times. I tried to reproduce it but couldn't. Did you just click once and then immediately you saw all three appear?
    Matthias Evering
    @ewingson
    yes immediately
    I just sent you a test on solid.community and it seemed unique
    how do I check the log if something is blocked ?
    Michiel de Jong
    @michielbdejong
    ah hm, maybe it is an error in how the event listener is attached to the 'Send' arrow