Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 29 10:49

    theRealImy on feature152

    (compare)

  • Nov 26 22:39
    bourgeoa assigned #135
  • Nov 26 20:49
    josephguillaume opened #135
  • Nov 09 22:05

    github-actions[bot] on gh-pages

    deploy: ac1a4f9306ad085d3ecdd02… (compare)

  • Nov 09 22:01

    bourgeoa on v1.7.12

    (compare)

  • Nov 09 22:01

    bourgeoa on main

    Update dependencies 1.7.12 (compare)

  • Nov 09 21:42

    github-actions[bot] on gh-pages

    deploy: 93d53b73263e04bc0967fac… (compare)

  • Nov 09 21:38

    bourgeoa on main

    Update dependencies 1.7.11 (compare)

  • Nov 09 21:38

    bourgeoa on v1.7.11

    (compare)

  • Nov 06 18:30

    github-actions[bot] on gh-pages

    deploy: 2021c2fcea5ee9269ce337e… (compare)

  • Nov 06 18:27

    bourgeoa on main

    Update dependencies 1.7.10 (compare)

  • Nov 06 18:27

    bourgeoa on v1.7.10

    (compare)

  • Nov 05 15:31

    github-actions[bot] on gh-pages

    deploy: 7861c5036714fd15817ec5c… (compare)

  • Nov 05 15:26

    bourgeoa on main

    added header menu for https://g… code improve open new menu targets in blank … and 9 more (compare)

  • Nov 05 15:26
    bourgeoa closed #134
  • Nov 05 13:45
    bourgeoa assigned #134
  • Nov 05 13:44
    bourgeoa labeled #134
  • Nov 05 13:44
    bourgeoa review_requested #134
  • Nov 05 13:43
    bourgeoa opened #134
  • Nov 04 23:16

    github-actions[bot] on gh-pages

    deploy: aca37eb3001f039da04f940… (compare)

Tim Berners-Lee
@timbl
Of course it may by that if you are looing at two things next to eaxh other, a chat and a to-do list, then both end up getting more powerful when you log in.
there is a og in event which it would be better to use in nfact in infinite.js
Timea
@theRealImy
but in the end, the pane or part of the pane must take care on its own if user is loggedin or not
Jeff Zucker
@jeff-zucker
I am unable to build mashlib - I get ERROR in ../solid-panes/lib/registerPanes.js
Module not found: Error: Can't resolve 'chat-pane' in '/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-panes/lib'
@ ../solid-panes/lib/registerPanes.js 26:18-38
@ ../solid-panes/lib/index.js
@ ./src/index.ts
@ multi ./src/index.ts
... and same error for meeting-pane ... yet I cloned and built and both those panes and both are symlinked in solid-panes ... any help?
7 replies
Timea
@theRealImy
I implemented refresh on the Add me to you friend feature. @timbl did I get it right (https://github.com/theRealImy/profile-pane/blob/3069e8f20dd3b02dcc642ca1dea5e8b455c45bfa/src/addMeToYourFriends.ts#L51)
Question: if now, say, somewhere in the code, in an above context, refreshTree(context) would be triggered would my button also refresh? Is the code enough?
Tim Berners-Lee
@timbl
@theRealImy You have done half … the case where checkIfAnyUserLoggedIn(me) is true. A refresh function has to set the state of the thing in all cases. What do you want the button to look like when the user is not logged in? refresh should reset it to that state too.
  • You don’t need to return the button, This is a function with no params and no return.
Timea
@theRealImy
My PR is now implementing all feedback I received from @SharonStrats, @bourgeoa, @timbl solid/profile-pane#15 Thank you, this was a great learning experience that brought me to a lot of the code and concepts.
The other day I also did some work on this PR: solid/profile-pane#19
Timea
@theRealImy
Good news, @bourgeoa's (thanks!) suggestion helped me to build and run SolidOs on Apple M1 chip! (I could install earlier version of node). I documented it in wiki: https://github.com/solid/solidos/wiki
Timea
@theRealImy
I also tried to document the Ui refresh topic: https://github.com/solid/solidos/wiki/Solid-UI-tips#refresh-of-ui not sure I understood it correctly. Feedback or edit is welcome.
Timea
@theRealImy
The full NSS token lifespan conversation with Aaron is now documented in a NSS ticket: solid/node-solid-server#1615
Sharon Stratsianis
@SharonStrats
@bourgeoa I was wondering if we implement the refresh scenario for auth. Do you know does this happen in mashlib repo right? Because the frontend would handle continuously asking the back in for a new token.
@timbl are you leaning toward a particular solution?
Sharon Stratsianis
@SharonStrats
the second one am I right that the state might be quite complex unless I'm missing something perhaps
10 replies
Tim Berners-Lee
@timbl
When it comes to the lifetime of the toke, lets not change anything unil the auth is working again.
Jeff Zucker
@jeff-zucker
I second that approach - the auth-upgrade is really critical to everything in the future so l am in favor of all hands on deck to get it working and deal with other issues later. The login/logout is the most critical so if you have any ideas there ... Alain could use help, I presume, with the build process, especially for panes ... I've tried a little, but AFAIK no one is testing with the stand-alone browse.html (web app but not served as part of a server) ... less critically, I could use more eyes on Data Kitchen's handling of the various panes.
4 replies
Matthias Evering
@ewingson
@jeff-zucker shall I install the 1.7.5-alpha-d9bd19aa on solidweb.me and test ? originally I intended to wait for the 1.7.5 production. but case I can help I will for sure ...
Jeff Zucker
@jeff-zucker
@ewingson - that won't help at his point since CSS and ESS work fine, the problem is NSS.
Matthias Evering
@ewingson
k
Sharon Stratsianis
@SharonStrats
Screen Shot 2021-09-18 at 6.13.32 am.png
I also have the prefs error
i will start here
Jeff Zucker
@jeff-zucker
Which context (solidcommunity:8443, data-kitchen, or browse.html?) Were you logged in when you got that, if not, that is expected?
Sharon Stratsianis
@SharonStrats
I actually got it in two different ways. So when I login from the server side (as discussed in this ticket solid/solidos#57) i get what is shown there in this screen shot.
Then I am shown the login button again from mashlib and when I click it it acts like everything went fine, however it ends up giving me a pop up saying the same thing
that prefs can't be reached
does this sounds correct?
Jeff Zucker
@jeff-zucker
That is a problem with that page, do not login there, go to your own pod and login using one of the new auth buttons ... the problems on the root index are not related to other login problems and have a known fix
the old login buttons are hard-coded in that index page so do NOT represent the new login flow
Sharon Stratsianis
@SharonStrats
aww ok
so i need to go to profile/card#me...
Jeff Zucker
@jeff-zucker
If you know how to fix that page, though, go for it
4 replies
yeah or I usually go to /public/
Sharon Stratsianis
@SharonStrats
I hadn't brought all the recent changes down, once I did that I no longer have the prefs errors as you mentioned. Only on that first login via the server html. Okay, so I have to feed my kids, but then I'll come back and start on the logout issue. If there is somewhere else you think I should start just let me know. I'll be about 30min I think
Sharon Stratsianis
@SharonStrats
Screen Shot 2021-09-18 at 10.42.28 am.png
I'm going to add to the ticket actually
Sharon Stratsianis
@SharonStrats
@jeff-zucker I'm documenting my findings in github, but currently I find that sharingPane doesn't ever call currentUser(). I'm doing to do some debugging, bc I'm not sure if it should or not, but other panes seem to call currentUser() in render. It seems like it should. However, it used to work right.. so seems weird that now it doesn't and before it did. Why would the new auth effect that? I'm not sure.
sharingPane is in solid-panes/src/sharing/sharingPane.js
Sharon Stratsianis
@SharonStrats
My findings are documented here solid/solidos#38. The sharing pane seems to be different locally versus on solidcommunity.net. @jeff-zucker @jaxoncreed @bourgeoa. Based on your feedback I will continue tomorrow morning my time testing or seeing if I can find anything further to help.
Sharon Stratsianis
@SharonStrats
@timbl @theRealImy @jeff-zucker @bourgeoa @jaxoncreed can you guys meet PST Monday 9am, CET Monday 6pm, BST Monday 5pm this is the first during the week time that would be possible. It will be 2am for me so I can't promise for sure I will make it, but I will do my best. I will make sure I have documented anything I find just in case.
Timea
@theRealImy
would be OK for me.
Timea
@theRealImy
@SharonStrats this meeting you propose for Monday, is that for the auth issues or ...
Sharon Stratsianis
@SharonStrats
yeah it seems like we should meet, but maybe 🤔 not... up to everyone. that is just the first time that would be possible.
Jeff Zucker
@jeff-zucker
I can meet, but seems like it should be up to @jaxoncreed when to meet - if he can use our help or has things to report, that's the time to meet
Tim Berners-Lee
@timbl
jaxoncreed
@jaxoncreed
Hey all, If needed I could attend a meeting but I won’t have much to report. Once I get access to the test server to see why there are problems only in production I’ll be able to debug it and then report.
Timea
@theRealImy
In tomorrow's meeting I would like to talk about the documentation topic, if we have time.
Thank you for contributing thus far, in case there are additional ideas pls add in the discussion: https://github.com/solid/solidos/discussions/49
Timea
@theRealImy
To have an overview I made again a diagram about what documentation part is now connected to what: https://miro.com/app/board/o9J_lvx4BGo=/
Timea
@theRealImy
Solid documentation user experience(4).jpg