Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 30 09:58
    michielbdejong closed #145
  • Jun 30 09:58
    michielbdejong closed #146
  • Jun 29 14:54
    TallTed commented #145
  • Jun 29 14:24
    michielbdejong commented #145
  • Jun 29 13:05
    michielbdejong commented #145
  • Jun 29 12:32
    michielbdejong commented #146
  • Jun 29 12:13
    michielbdejong commented #146
  • Jun 29 08:53
    michielbdejong commented #146
  • Jun 29 08:52
    michielbdejong commented #146
  • Jun 29 08:24
    michielbdejong commented #146
  • Jun 29 08:19
    michielbdejong commented #146
  • Jun 27 07:02
    michielbdejong commented #146
  • Jun 27 07:01
    michielbdejong edited #146
  • Jun 25 00:24

    dependabot[bot] on npm_and_yarn

    (compare)

  • Jun 25 00:24
    dependabot[bot] closed #130
  • Jun 25 00:24
    dependabot[bot] commented #130
  • Jun 25 00:24
    dependabot[bot] labeled #147
  • Jun 25 00:24
    dependabot[bot] opened #147
  • Jun 25 00:24

    dependabot[bot] on npm_and_yarn

    Bump node-fetch from 2.6.0 to 2… (compare)

  • Jun 16 17:15
    michielbdejong labeled #146
bblfish
@bblfish:matrix.org
[m]
Ah yes, I have to publish a new release of banana-rdf for the new servers to work. I also need to get a relase for this milestone done very very soon.
Michiel de Jong
@michielbdejong
@bblfish:matrix.org great, keep us posted!
Kjetil Kjernsmo
@kjetilk
@michielbdejong I know you have been championing the use if If-None-Match: * and so, at least, it is now very clear it is a MUST in the spec, which I hope makes you happy :-)
Michiel de Jong
@michielbdejong
@kjetilk ah yes, thanks! That does make me very happy :) I see, this line, right? https://github.com/solid/specification/blob/2b6652d31a15bb6921416573c2244324400fff45/protocol.html#L640
3 replies
jaxoncreed
@jaxoncreed
@michielbdejong I’m upgrading SolidOS to the new auth standard. I don’t think the test suite will touch any of my upgrades since I didn’t touch NSS, but I just want to be sure.

When I run that script I see

=> [ 2/10] RUN git clone https://github.com/solid/node-solid-server                                                                     3.3s
 => [ 3/10] WORKDIR node-solid-server                                                                                                    0.1s
 => [ 4/10] RUN git checkout main                                                                                                        0.3s
 => [ 5/10] RUN npm install                                                                                                             75.2s
 => [ 6/10] RUN openssl req -new -x509 -days 365 -nodes   -out ./server.cert   -keyout ./server.key   -subj "/C=RO/ST=Bucharest/L=Bucha  0.5se
 => [ 7/10] ADD config.json .                                                                                                            0.0s 
 => [ 8/10] ADD config ./config                                                                                                          0.0s 
 => [ 9/10] ADD data ./data                                                                                                              0.0s 
 => [10/10] ADD .db ./.db

It looks like its just checking out the current main branch of node-solid-server and running it. Is there any way I can run the test suite against the local instance?

Sarven Capadisli
@csarven

@michielbdejong @RubenVerborgh Let's take it down a few notches =)

Michiel, Aaron's suggestions seem reasonable to me and will be easy going for everyone.

Let the information about implementations and their reports come from authoritative sources or at the very least be published given their consent. (FWIW, that's how it was for the LDN test suite.)

Sarven Capadisli
@csarven
re "authoritative sources", I meant the implementers (maintainers, the PR department, the Press Secretary...) :)
Michiel de Jong
@michielbdejong
yes, please! more involvement from implementers would be awesome! that really makes our job easier, too.
For instance for ESS, i'm having a hard time right now migrating https://github.com/solid/solid-crud-tests/blob/main/run-against-ess.sh#L10 from pod-compat.inrupt.com to pod.inrupt.com. We will no longer be able to run the WAC tests against ESS, but I was hoping we can still run the CRUD tests that way.
Michiel de Jong
@michielbdejong
Re NSS CI running against main instead of against the current branch, you're right! I vaguely remember we had that as a todo item to fix that. I'm looking into it now.
For solid-nextcloud the CI was set up the proper way, using ADD instead of git pull, see https://github.com/pdsinterop/solid-nextcloud/blob/main/Dockerfile#L17
And PSS CI also uses ADD so that will also test the PR's branch correctly https://github.com/pdsinterop/php-solid-server/blob/main/Dockerfile#L20
Michiel de Jong
@michielbdejong
@jaxoncreed fixed with solid/node-solid-server#1610
Michiel de Jong
@michielbdejong
Updated the CRUD tests 'run-against-ess' script from pod-compat.inrupt.com to pod.inrupt.com
Tests: 3 failed, 33 skipped, 33 passed, 69 total
All three failures have to do with concurrency. Does pod.inrupt.com support If-None-Match: * request headers?
Michiel de Jong
@michielbdejong
@gibsonf1 TrinPod doesn
t support If-Match and If-None-Match either yet, right?
are there plans to add that?
jaxoncreed
@jaxoncreed
I don’t see in references to supporting those headers in the code.
I’m trying to run the test suite locally to check it out, but I keep getting Error: Cannot find module ‘rdflib’. It’s linked in my node_modules. Is there something else I should do?
Fred Gibson
@gibsonf1
@michielbdejong Yes, we will be adding trinpod support for If-Match and If-None-Match
Michiel de Jong
@michielbdejong
@jaxoncreed you probably linked to a local version of rdflib that's not built?
Try using https://GitHub.com/solid/solidos or just cd into the rdflib copy that causes the error and run npm run build there.
@gibsonf1 great!
Is someone from Inrupt available to discuss the test results for pod.inrupt.com?
jaxoncreed
@jaxoncreed
@michielbdejong The local version of rdflib is built
jaxoncreed
@jaxoncreed
Okay, it works if I clone node-solid-server independent of solidos
Michiel de Jong
@michielbdejong
@jaxoncreed Great! Let me know if there is anything else I can help with.
Regarding https://github.com/solid/solid-crud-tests/blob/main/test/surface/concurrency.test.ts we concluded that the spec does not require servers to pass these tests, so we'll still report them but clearly mark it as optional.
Michiel de Jong
@michielbdejong
So 'WebID Provider', 'CRUD' (excluding Websockets-pub-sub and Concurrency), and 'WAC' will be required, and 'Concurrency', 'Websockets-Pub-Sub', and 'Monetization' will be optional. We also still want to add optional test suite sections about 'Websockets-Patch' and 'ACP', but these tests have yet to be written.
@ylebre @bourgeoa @edwardsph @csarven does that list sound correct, did I forget anything?
Pete Edwards
@edwardsph
@kjetilk may want to comment as he has been going through the spec ensuring everything testable has an id: solid/specification#302
Kjetil Kjernsmo
@kjetilk
Not sure what we are discussing :-)
Just one comment, on the term CRUD, I have always been uncomfortable about using that in Solid context, for two reasons: They don't map all that well to HTTP methods, and secondly, but more importantly, they lack permissions subsets. Which is kind of a strength in some contexts, but when we need to be very careful to design a system that truly enables practical use of the principle of least privilege, which has big societal implications
Kjetil Kjernsmo
@kjetilk
it is interesting to talk about Create, Update and Delete as subsets of Write, though, and I think we should
anyway, that was probably pretty far out on a tangent :-)
Yvo Brevoort
@ylebre
@michielbdejong sounds good to me!
Michiel de Jong
@michielbdejong
@kjetilk good point, these tests used to be called the "storage" tests, to distinguish them as a testable server function from IDP function and from access control (WAC). We renamed them to CRUD because they don't test the storage backend implementation, but the layer just above that, in a sense. The test how resources are created, updated, represented and deleted. Hence the name :)
Michiel de Jong
@michielbdejong
Michiel de Jong
@michielbdejong
Is someone from CSS team available to discuss the latest test results?
Or should I just create an issue on https://github.com/solid/community-server/issues ?
Michiel de Jong
@michielbdejong
Basically, the 6 failures from https://github.com/solid/community-server/issues/902#issue-968511525 are stil happening in both the main and the version/2.0.0 branch.
Sarven Capadisli
@csarven
solid/specification#316 adds identifiers and descriptions to significant things like requirements, concepts.. in the Protocol. Same as in https://solid.github.io/web-access-control-spec/
Michiel de Jong
@michielbdejong
great!
Sarven Capadisli
@csarven
Needless to say, feedback welcome.
Fred Gibson
@gibsonf1
We've been in the process of an architecture update for the last 2 days and noticed someone running the test-suite this morning, so that wouldn't run. The update is complete now on https://stage.graphmetrix.net
Fred Gibson
@gibsonf1
Actually not quite, still have an issue to fix.