Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jeffry Hesse
    @DarthHater
    One test away from victory, I think
    ALSO cleaned up some of the nasty shit around the test db name, etc...
    Gonna go outside for a few minutes but I think I'm gonna crest this pretty soon
    Jeffry Hesse
    @DarthHater
    @zendern @fitzoh aight, there's some duplication in the code atm, but let er rip, tests passing: sonatype-nexus-community/nancy#133
    Jeffry Hesse
    @DarthHater
    Aight, I think I addressed your feedback @fitzoh , and tests are still passing, no lint complaints, dogfooding, and lots of other cool stuff. We reduced our dependencies quite a bit by doing this, AND it's cross platform AND it's STUPID fast at least locally
    I stepped through it a few times with the debugger to make sure it was doing exactly what I wanted
    Jeffry Hesse
    @DarthHater
    Either way we go forward now, we at least have the cache more or less extracted from ossindex itself, so it should be easyish to swap to another one if pudge isn't making the cut
    Jeffry Hesse
    @DarthHater
    ANNNND cache specific tests added. Largely duplicate the OSS Index ones, but a bit more fine grained
    And that said, I AM OUTTA HERE!
    Jeffry Hesse
    @DarthHater
    Hmmm there is an intermittent failure
    The tests being in parallel now I'm having some fun
    why did you bodge that?
    Jeffry Hesse
    @DarthHater
    @greut because when I went to release Nancy it wasn't working, lol
    I'll fix it up in a couple minutes, but I had to unblock the release first
    Jeffry Hesse
    @DarthHater
    Yoan Blanc
    @greut
    @DarthHater thanks mate
    Jeffry Hesse
    @DarthHater
    No problem @greut !
    Jeffry Hesse
    @DarthHater
    Ahoy!
    Been a bit quiet over here recently
    If anyone wants to review a PR: sonatype-nexus-community/nancy#145
    Jeffry Hesse
    @DarthHater
    @zendern @fitzoh , I'm currently working on go-sona-types , taking the stuff from Nancy out that's kinda common, if either of you want in, let me know!
    Nathan Zender
    @zendern
    👍 I probably won't have time to help but I'm up for 👀 PRS of you have them.
    Jeffry Hesse
    @DarthHater
    Cool!
    I'm probably gonna push the initial project out today
    Just doing some work to cut "nancy" out
    Nathan Zender
    @zendern
    @DarthHater Feelings on since we are ripping these out do we officially pull the trigger on 1.0 status??
    Jeffry Hesse
    @DarthHater
    @zendern that's the plan! @bhamail is getting close to having the Cobra commander stuff solid, and I was like aight if we gotta change flags and stuff, let's rip off the band aid and go 1.0.0
    I've still got some concerns with Cobra overall (it pulls in a ton of dependencies) but overall it's fantastic
    Nathan Zender
    @zendern
    👍🎉👍🎉👍🎉👍
    :tada:
    Yoan Blanc
    @greut
    Jeffry Hesse
    @DarthHater
    @greut not explicitly, but I would imagine when it goes out of scope it is
    So as soon as AuditPackages ends
    I use it to block the function from returning while we poll Nexus IQ Server
    Do you think we need to add a close() around it @greut ?
    I'm no total expert on them, so if you know better, all ears!
    Jeffry Hesse
    @DarthHater
    @zendern @greut @fitzoh this is pretty much baked: sonatype-nexus-community/go-sona-types#2
    Jeffry Hesse
    @DarthHater
    I rethought those packages from a "I'm a consumer" standpoint
    So function names, Options, etc... all kinda rethunk
    Yoan Blanc
    @greut
    @DarthHater the first rule of channels is don't use them.
    in this case, it's doesn't appear useful and should be removed (imho)
    Jeffry Hesse
    @DarthHater
    Haha
    If you can rethink that long polling process, I'm more than game. I used a goroutine and channel to block the process from exiting because it was the only way I knew how to, but I surmise I just didn't really grasp something else!
    Jeffry Hesse
    @DarthHater
    Y'all make me so proud for the help you give!!!!
    Proud maybe not right word?
    Stoked?
    Excited, etc...