Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jeffry Hesse
    @DarthHater
    @zendern @fitzoh , I'm currently working on go-sona-types , taking the stuff from Nancy out that's kinda common, if either of you want in, let me know!
    Nathan Zender
    @zendern
    👍 I probably won't have time to help but I'm up for 👀 PRS of you have them.
    Jeffry Hesse
    @DarthHater
    Cool!
    I'm probably gonna push the initial project out today
    Just doing some work to cut "nancy" out
    Nathan Zender
    @zendern
    @DarthHater Feelings on since we are ripping these out do we officially pull the trigger on 1.0 status??
    Jeffry Hesse
    @DarthHater
    @zendern that's the plan! @bhamail is getting close to having the Cobra commander stuff solid, and I was like aight if we gotta change flags and stuff, let's rip off the band aid and go 1.0.0
    I've still got some concerns with Cobra overall (it pulls in a ton of dependencies) but overall it's fantastic
    Nathan Zender
    @zendern
    👍🎉👍🎉👍🎉👍
    :tada:
    Yoan Blanc
    @greut
    Jeffry Hesse
    @DarthHater
    @greut not explicitly, but I would imagine when it goes out of scope it is
    So as soon as AuditPackages ends
    I use it to block the function from returning while we poll Nexus IQ Server
    Do you think we need to add a close() around it @greut ?
    I'm no total expert on them, so if you know better, all ears!
    Jeffry Hesse
    @DarthHater
    @zendern @greut @fitzoh this is pretty much baked: sonatype-nexus-community/go-sona-types#2
    Jeffry Hesse
    @DarthHater
    I rethought those packages from a "I'm a consumer" standpoint
    So function names, Options, etc... all kinda rethunk
    Yoan Blanc
    @greut
    @DarthHater the first rule of channels is don't use them.
    in this case, it's doesn't appear useful and should be removed (imho)
    Jeffry Hesse
    @DarthHater
    Haha
    If you can rethink that long polling process, I'm more than game. I used a goroutine and channel to block the process from exiting because it was the only way I knew how to, but I surmise I just didn't really grasp something else!
    Jeffry Hesse
    @DarthHater
    Y'all make me so proud for the help you give!!!!
    Proud maybe not right word?
    Stoked?
    Excited, etc...
    Yoan Blanc
    @greut
    @DarthHater the goroutine serves little benefits as the caller is blocked by the result channel. You could for { select { }} on some timeout e.g. using context.WithTimeout. If it ain't broke, don't fix though.
    Jeffry Hesse
    @DarthHater
    @zendern @greut @fitzoh I made a change to the addlicense check that now only checks *.go files, as I think that's probably sufficient for headers. There's a new file called license-excludes.xml that is meant for the tool that does this internally, too
    Yoan Blanc
    @greut
    $ cat go-list.json | nancy --quiet
    exit code: 3 - Error auditing packages - error: [500 Internal Server Error] error accessing OSS Index