by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    John Eckhart
    @jeckhart
    Good morning. I've been using the typescript lang server in conjunction with Atom and notice a peculiarity:
    If I've changed a file's type (ie. .ts to .tsx) or installed a package in node_modules the lang server doesn't often pick up on it unless I restart Atom.
    Is there a way to encourage the lang-server to reload from within atom?
    Ville Hakulinen
    @vhakulinen
    Hi, does the lang server shipping documentation key in the textDocument/complete request response?
    I found the original PR which added support for code completion and it had the test cases for the documentation but the latest (master branch) doesn't seem to have the documentation key in the test cases
    no wait, they are there..
    tho' it looks like its for snippets
    Ville Hakulinen
    @vhakulinen
    nvm, the documentation made it clear that it might not be filled in so additional requests might be needed
    realisation
    @realisation

    @vhakulinen @jeckhart @teasp00n @felixfbecker @jayvdb @AlexMax

    Is there a better place to talk about the js LSP server ?

    John Vandenberg
    @jayvdb
    nope, I guess this is the best spot
    realisation
    @realisation
    neat
    @jayvdb I'm wondering how it handles the parsing
    I'm creating a peculiar IDE, and it's seeming like that's the first step
    Troy Patrick
    @teasp00n
    @realisation yeah I guess this is the place to talk about it. pretty quiet in here though.
    Alexander Bonin
    @alex4o
    Hello, is there a way to get autocomplete for packages from node_modules, using require and for things that are exported with
    export default
    Troy Patrick
    @teasp00n
    im wanting to implement textDocumentTypeDefinition but it looks like the Location objects returned from _getDefinitionLocations are not decorated with whether or not the definition is for a local var or an interface/class. Am i going about this the wrong way or would this info need to be added to support what im after?
    @felixfbecker
    Felix Becker
    @felixfbecker
    _getDefinitionLocation under the hood looks for the location of the definition, not the location of the type - I think you need to implement a new method, that instead of calling TS's API to get the definition location, it calls TS's API to get the type location. It should otherwise look almost the same.
    Troy Patrick
    @teasp00n
    Awesome, thanks for the reply I'll have a look into it
    Felix Becker
    @felixfbecker
    go to type support would be awesome!
    Troy Patrick
    @teasp00n
    @felixfbecker looks like it is working locally :) ill need to add some tests etc then ill open a pr for you to look at
    Troy Patrick
    @teasp00n
    @felixfbecker PR up: sourcegraph/javascript-typescript-langserver#475
    Troy Patrick
    @teasp00n
    @felixfbecker I updated the PR btw. Can you check
    Eric Corson
    @emccorson
    Hi, I am wondering how javascript-typescript-langserver is able to work in the browser (e.g. the demo on sourcegraph.com) since it only supports TCP. I thought for a browser to send requests it would need to use a websocket since there is no support for plain TCP connections in JavaScript? But as far as I can see, there is no way to use websockets with this language server.
    Felix Becker
    @felixfbecker
    @emccorson sourcegraph.com talks to an LSP gateway (supports both HTTP and WebSockets) that proxies requests to language servers running over TCP
    Chris
    @ipatch

    got javascript-typescript-langserver setup with neovim, deoplete, and LanguageClient-neovim the other day 💪

    and it doesn't quite have the completions that VS Code provides, especially when working with a Node.js / Express app. Is there anything I could do to help improve the completions?

    neovim-comparing-completions.png
    Eric Corson
    @emccorson
    @felixfbecker thanks!
    Charles Hughes
    @chughes87
    Hey all I'm experimenting with using this tool with vim and am having a hard time finding a way to make the textDocument_rename function ignore node_modules and other folders other than modifying the source code myself. Is there a configuration for this?