Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 06 00:44
    BFergerson milestoned #48
  • Apr 06 00:44
    BFergerson demilestoned #48
  • Apr 06 00:44
    BFergerson demilestoned #47
  • Apr 06 00:44
    BFergerson milestoned #47
  • Apr 06 00:42
    BFergerson milestoned #137
  • Apr 06 00:42
    BFergerson demilestoned #137
  • Apr 06 00:42
    BFergerson milestoned #159
  • Apr 06 00:42
    BFergerson demilestoned #159
  • Apr 06 00:41
    BFergerson milestoned #159
  • Apr 06 00:41
    BFergerson demilestoned #159
  • Apr 06 00:40
    BFergerson milestoned #150
  • Apr 06 00:40
    BFergerson demilestoned #150
  • Apr 06 00:38
    BFergerson demilestoned #137
  • Apr 06 00:38
    BFergerson milestoned #137
  • Apr 05 20:31
    BFergerson synchronize #170
  • Apr 05 20:31

    BFergerson on trace-api-test

    added variables (compare)

  • Apr 05 20:23
    BFergerson synchronize #170
  • Apr 05 20:23

    BFergerson on trace-api-test

    test call depth of 2 (compare)

  • Apr 05 17:29
    BFergerson synchronize #170
  • Apr 05 17:29

    BFergerson on trace-api-test

    simplify (compare)

Laurent
@lauhin
[SKYWALKING] - WARN 2019-03-19 15:28:11:279 AbstractClassEnhancePluginDefine : enhance class be.liantis.zo.ol.controllers.PermissionController by plugin org.apache.skywalking.apm.plugin.spring.webflux.v5.define.RestControllerInstrumentation is not working. Because witness class org.springframework.web.reactive.BindingContext is not existed.
Brandon Fergerson
@BFergerson
I'll start with the restart IDE bug
That's just a warning
Does your application have @RequestMapping annotations?
Laurent
@lauhin
no, @GetMapping
Brandon Fergerson
@BFergerson
Ah, I'm going to need to add support for those
I'll work on that later today
Laurent
@lauhin
when i do requests now, the icon gets a color
thats good news, but nog data... everything zero :p
Brandon Fergerson
@BFergerson
Does your S++ Core instance show anything?
It'll be the first to find the traces
Laurent
@lauhin
no, it says nothing
brobably beacuse I use GetMapping?
Brandon Fergerson
@BFergerson
It might be. You should be able to manually subscribe to anything that's automatically subscribed though. If you hit ALT+ENTER it'll let you subscribe to the artifact. The fact that you said the S++ is a different color though at least signifies that there is SOME data available for it. So it showing you nothing seems strange.
I would need to see your S++ Core logs to get an idea of what it's doing
And I'm guessing you're hitting this method with @GetMapping, right? At least a couple times so it has some data
Laurent
@lauhin
hm, wait
skywalker broke :p
image.png

but the source logger shows this:

2019-03-19 15:35:55,672 INFO [c.s.c.i.s.SkywalkingIntegration] [org.slf4j.Logger$info.call(Unknown Source)]
Getting SkyWalking traces: TraceQuery{appUuid=1e988b55-468e-4335-ba7d-df21a99325ae, artifactQualifiedName=be.liantis.zo.ol.controllers.PermissionController.findAll(), endpointId=13, durationStart=2019-02-17T14:35:55.671Z, durationStop=2019-03-19T14:35:55.671Z, durationStep=SECOND}

but time is the same..., the request takes +-800ms
maybe thats why everything is 0? :)
Brandon Fergerson
@BFergerson
I can't read what the exception message is in your screenshot. What happened to SkyWalking?
The logs you shows from S++ Core just say that it ran a query against SkyWalking. It doesn't say anything about finding them. You would see something like:
Getting Skywalking traces: TraceQuery{appUuid=fa53e250-a5ee-4c20-92cd-a043940e2cea, artifactQualifiedName=KotlinErrorExampleKt.invokesMethod(), endpointId=3, durationStart=2019-02-17T14:52:05.021Z, durationStop$
2019-03-19 14:52:05,057 INFO [c.s.c.i.s.SkywalkingIntegration] [org.slf4j.Logger$info$3.call(Unknown Source)]
Got Skywalking traces. Traces: 10 - Total: 5433
Brandon Fergerson
@BFergerson
Also, the fact that be.liantis.zo.ol.controllers.PermissionController.findAll() has an endpoint id of 13 means that it was able to find it in SkyWalking. So if you send more requests (and SkyWalking is up) they should appear in S++.
Laurent
@lauhin
hm, will try this tomorrow, done working for today :)
Brandon Fergerson
@BFergerson

Turns out GetMapping was supported (source).

The other method types aren't but will be in the next release (CodeBrig/Source#27). Just FYI.

Brandon Fergerson
@BFergerson
Also, if the issue of no data issue persists you will probably need to add -Duser.timezone=GMT to oapService.bat/oapService.sh in the JAVA_OPTS variable.
Laurent
@lauhin
added -Duser.timezone=GMT and the data is flowing now :D
1 question, when i go to the overview, the stats are the same for all the medthods, is that normal?
Brandon Fergerson
@BFergerson
That doesn't sound normal. Mind showing me?
Brandon Fergerson
@BFergerson
I realized yesterday that you're missing a pretty significant bug fix (CodeBrig/Source#23). I don't want to blame it on that bug without confirming it, but it could likely cause issues like that. If I can confirm it's that issue I'll get a release out today. If not, I'll get a release out this weekend like I was planning with some more fixes.
Laurent
@lauhin
ok, will test it next week then :D
Brandon Fergerson
@BFergerson

@lauhin, released v0.1.2 (https://github.com/CodeBrig/Source/releases/tag/v0.1.2-alpha). This addresses the timezone issue you were facing and hopefully the issue with all the tooltips showing the same results. It'll take a couple days before JetBrains approves the plugin but if you want to try it out in the meantime you can download and install jetbrains-source-plugin-0.1.2.zip directly.

You'll need to remove the -Duser.timezone=GMT property I had you add before. It'll default to your system timezone now. Let me know if you have any issues.

Laurent
@lauhin
dod the port of apache skywalking changed?
source++ is searching for 12799 instead of 12800
image.png
Brandon Fergerson
@BFergerson
@lauhin, sorry about that. That's the port I use when connecting via Docker. Not sure how that slipped in.
Please use the fixed Source++ Core here: https://github.com/CodeBrig/Source/releases/tag/v0.1.3-alpha
Laurent
@lauhin
no problem :p will try again
Laurent
@lauhin
@BFergerson about the stats that showing the same for all methods
when i go from a method with stats data to another one without stats, the stats from the first one are shown
when i go to the traces tab and back, the stats are gone
when i switch between methods, both filled with stats, it is shown ok
so it seems to work :D
only intellij has a hard time on startup :p
Brandon Fergerson
@BFergerson

@lauhin, gotcha. I added a bug for it (CodeBrig/Source#41) and will address that issue this week.

Would you mind explaining what you mean about the IntellIj having a hard time on startup? Is that the issue with needing to restart after connecting to Source++ Core?

Gregor B. Rosenauer
@grexe
tried to setup the IntelliJ plugin in IntelliJ Ultimate 2019.3 but the plugin crashed with a conflict in the Groovy libraries, just trying to find out where it comes from, but is this an issue others encountered, too?
groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-all is loaded in version 2.4.15 and you are trying to load version 2.4.17
Gregor B. Rosenauer
@grexe
tried to disable bundled Groovy plugin (which also disables dependant Cucumber and Android plugins...), but still getting the same error.
Gregor B. Rosenauer
@grexe
works with the java-11-upgrade branch, though. Related Github issue: sourceplusplus/Assistant#104