Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Monia
@ImmanuelSegol
@avive @iamonuwa is #42 ready to merge or is there need for improvement ? about the UI issues I would happily help @iamonuwa
Onuwa Nnachi Isaac
@iamonuwa
@ImmanuelSegol thank you for your hard work so far. Will review and request @avive and @samparsky to do likewise
Monia
@ImmanuelSegol
@iamonuwa Whats is your time zone, im in TLV and I know @avive is in NY.
Onuwa Nnachi Isaac
@iamonuwa
GMT +1 (Nigeria)
Monia
@ImmanuelSegol
Cool that will make communicating better :)
Onuwa Nnachi Isaac
@iamonuwa
Cool
Aviv Eyal
@avive
@/all are there any product / UX specific questions you may have to me as you work on the tasks?
I'm here and will be glad to answer
Onuwa Nnachi Isaac
@iamonuwa
:+1: @avive
Aviv Eyal
@avive
who needs some help on anything? ux, mobile, etc?
anyone works on shared components that can go to cosmic?
Aviv Eyal
@avive
What about this task? spacemeshos/cosmic#15
is it ready for review?
Onuwa Nnachi Isaac
@iamonuwa
Yes please
Aviv Eyal
@avive
Regarding cosmic #15 - I'm getting yarn error after yarn clean-all and yarn mobile
same old issue - must run the shell commands in the readme under known issues...
maybe we should add these to the yarn mobile script to automate the cleanup?
Aviv Eyal
@avive
I'm commenting on the PR - please have a look
Aviv Eyal
@avive
Is there anyone here with OS X that would like to help out with building the cosmic seed for the app?
Aviv Eyal
@avive
as a quick update this app is built on top of cosmic - we can use some help on getting cosmic to build properly on os x. You can see a list of issues in this pr: spacemeshos/cosmic#15 - if you have a mac and a will to get cross-platform build processes working then please help us here
Onuwa Nnachi Isaac
@iamonuwa
Alright. Looks weird
I have a macbook now. Testing on both Ubuntu and Macbook
Aviv Eyal
@avive
:+1:
Aviv Eyal
@avive
question: can you assign yourself on github to tasks / issues you are currently working on so we can get a better sense of what's going on?
Onuwa Nnachi Isaac
@iamonuwa
Alright
Am AFK at the moment
Will do that ASAP
Aviv Eyal
@avive
Has anyone here done any work which involves assets? if yes - please chime in how you are using assets
Wai Mun
@iworkforthem_twitter

ref: spacemeshos/app#13

is anyone working on this issue? would love to give it a try.

Aviv Eyal
@avive
@iamonuwa - is anyone working on #13 ?
Omidiora Samuel
@samparsky
@avive No I don't think so
Wai Mun
@iworkforthem_twitter
@avive @samparsky .. ok, is it alright that i use Storybook on the components?
Aviv Eyal
@avive
yes - great idea - go for it
Noam - the app designer can collaborate on this with you
As he did the visual design for all the components
Omidiora Samuel
@samparsky
@iworkforthem_twitter No you can't use Storybook for the components
@avive I don't think using Storybook would work has it would differ greatly from the current implementation @iamonuwa is working on the basic UI implementation
Also I don't think Storybook adds any possible needed advantage
Aviv Eyal
@avive
Does storybook even support react native components?
Wai Mun
@iworkforthem_twitter
@avive https://storybook.js.org/basics/guide-react-native/
Wai Mun
@iworkforthem_twitter
@samparsky for large/distributed teams, it really help to streamline the UI development & reuse.
this article summarise it really well: https://spin.atomicobject.com/2018/01/24/react-storybook/
Onuwa Nnachi Isaac
@iamonuwa
@avive @samparsky I took ill last week.
Am okay right now
Am going to complete work on the basic ui
ETA Tuesday 1800 GMT +1
Aviv Eyal
@avive
Is there any PR that needs some code review?
Is anyone working on this issue now? spacemeshos/app#45
Omidiora Samuel
@samparsky
@avive If no one is working on it I can work on it
@iamonuwa How is the basic UI coming up?