Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 03 2022 21:34
    jonZlotnik added as member
  • Sep 21 2022 11:34
    AmitShaul removed as member
  • Sep 21 2022 11:33
    narayanprusty removed as member
  • Sep 21 2022 11:32
    narayanprusty added as member
  • Jun 22 2022 09:04
    neysofu added as member
  • Jun 22 2022 09:04
    nkryuchkov added as member
  • Jun 08 2022 19:28
    y0sher removed as member
  • Jun 08 2022 19:28
    sudachen removed as member
  • Jun 08 2022 19:28
    sidsankhe removed as member
  • Jun 08 2022 19:28
    daonb removed as member
  • Jun 08 2022 15:00
    sidsankhe added as member
  • Jun 07 2022 03:30
    antonlerner added as member
  • Dec 14 2021 12:24
    daonb added as member
  • Dec 14 2021 12:24
    IlyaVi added as member
  • Dec 14 2021 12:24
    y0sher added as member
  • Dec 14 2021 12:24
    AmitShaul added as member
  • Dec 14 2021 12:24
    sudachen added as member
  • Oct 11 2020 15:25
    liathoffman removed as member
  • Jan 23 2020 07:10
    liathoffman added as member
  • Nov 17 2019 19:47
    zalmen removed as member
Aviv Eyal
@avive
can you guys please add short one-line documents to the app source code to clarify a bit the demo app and the major patterns?
I've verified on mbp that: iOS, Android and Electron builds work. Yarn dist works
Shouldn't the instructions for ios and android dev builds be:
yarn clean-all, react-native upgrade, yarn ios or yarn android ?
this is the only way I can avoid duplicated deps from desktop builds when running in emulators
talking about readme.md
Onuwa Nnachi Isaac
@iamonuwa
Alright
Aviv Eyal
@avive
maybe yarn ios should clean, run a script to build the source and compile and run
too many steps
Onuwa Nnachi Isaac
@iamonuwa
Oh, I get it.
This message was deleted
Aviv Eyal
@avive
amen to that
Onuwa Nnachi Isaac
@iamonuwa
@avive the gitignore get recreated if the user wants anytime they run react-native upgrade. If we remove it now, a user may choose to accept a new .gitignore, the options will go away
Aviv Eyal
@avive
isn’t there another script to build the ios or android source files that doesn’t like to overwrite gitignore?
Onuwa Nnachi Isaac
@iamonuwa

yarn ios will not work without the script that generated the /ios dir - is it react-native upgrade?

Yes. You'll need the ios directory for it to work.

The react-native upgrade does the overwrite if the user wants. And we are leveraging it. I've been searching for additional flags so that we can override it. Say --no-overwrite or something
We can remove it from the seed but once a developer picks it up, he needs the android and ios directories
Onuwa Nnachi Isaac
@iamonuwa
Just updated the README.md to reflect mobile build and run
Aviv Eyal
@avive

question - are we sure about this: `For the android app to work well, you need to add local.properties to the root directory of the android directory.

local.properties contains the sdk path to your android sdk.`

I can run in emulator fine without it
is it for building production builds?
ideally we'll have this file with the syntax so the user only needs to update with path to java sdk. at least we should add a link about help text on the web about the syntax and the need for this file
Onuwa Nnachi Isaac
@iamonuwa
That should be for production.
Every rebuild generates an apk
Onuwa Nnachi Isaac
@iamonuwa

Right, let me add the link now

ideally we'll have this file with the syntax so the user only needs to update with path to java sdk. at least we should add a link about help text on the web about the syntax and the need for this file

Onuwa Nnachi Isaac
@iamonuwa
@avive please check the last PR
Aviv Eyal
@avive
great - can you guys please comment the code you wrote for the app?
redux, main classes, types, etc...
there are almost no comments in the code
Aviv Eyal
@avive
I think we are getting close - what else to be done before we can state all tasks defined in the funded issues are complete?
Aviv Eyal
@avive
cleaned up and formatted: https://github.com/spacemeshos/cosmic/blob/master/README.md
merged the PR into master
let's get it done!
Onuwa Nnachi Isaac
@iamonuwa
Alright. Adding comments
Onuwa Nnachi Isaac
@iamonuwa
@avive samuel added comments already to the codebase
Onuwa Nnachi Isaac
@iamonuwa
@avive Added minor description.
Aviv Eyal
@avive
let me know when comments pr@ia ready for review
meant comments pr
is
Onuwa Nnachi Isaac
@iamonuwa
Please check my last PR to see if it's okay or in format
Aviv Eyal
@avive
please add yourselves to authors.md
Onuwa Nnachi Isaac
@iamonuwa
Done that already
Aviv Eyal
@avive
comments are good but can we have it to all sample code?
redux, components, etc... just a one liner for each type / class / method please
Onuwa Nnachi Isaac
@iamonuwa
Alright. I'll fix that right now
Onuwa Nnachi Isaac
@iamonuwa
Please check again
Aviv Eyal
@avive
it is ok - I hope to have more - like 1 line about what each code section does and not just an empty comment
this helps ease-in new devs into the project
for example reducers/index.ts - what is IState and what is initialState?
secondpage/index.tsx - what is each const?