Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 03 21:34
    jonZlotnik added as member
  • Sep 21 11:34
    AmitShaul removed as member
  • Sep 21 11:33
    narayanprusty removed as member
  • Sep 21 11:32
    narayanprusty added as member
  • Jun 22 09:04
    neysofu added as member
  • Jun 22 09:04
    nkryuchkov added as member
  • Jun 08 19:28
    y0sher removed as member
  • Jun 08 19:28
    sudachen removed as member
  • Jun 08 19:28
    sidsankhe removed as member
  • Jun 08 19:28
    daonb removed as member
  • Jun 08 15:00
    sidsankhe added as member
  • Jun 07 03:30
    antonlerner added as member
  • Dec 14 2021 12:24
    daonb added as member
  • Dec 14 2021 12:24
    IlyaVi added as member
  • Dec 14 2021 12:24
    y0sher added as member
  • Dec 14 2021 12:24
    AmitShaul added as member
  • Dec 14 2021 12:24
    sudachen added as member
  • Oct 11 2020 15:25
    liathoffman removed as member
  • Jan 23 2020 07:10
    liathoffman added as member
  • Nov 17 2019 19:47
    zalmen removed as member
Onuwa Nnachi Isaac
@iamonuwa
That should be for production.
Every rebuild generates an apk
Onuwa Nnachi Isaac
@iamonuwa

Right, let me add the link now

ideally we'll have this file with the syntax so the user only needs to update with path to java sdk. at least we should add a link about help text on the web about the syntax and the need for this file

Onuwa Nnachi Isaac
@iamonuwa
@avive please check the last PR
Aviv Eyal
@avive
great - can you guys please comment the code you wrote for the app?
redux, main classes, types, etc...
there are almost no comments in the code
Aviv Eyal
@avive
I think we are getting close - what else to be done before we can state all tasks defined in the funded issues are complete?
Aviv Eyal
@avive
merged the PR into master
let's get it done!
Onuwa Nnachi Isaac
@iamonuwa
Alright. Adding comments
Onuwa Nnachi Isaac
@iamonuwa
@avive samuel added comments already to the codebase
Onuwa Nnachi Isaac
@iamonuwa
@avive Added minor description.
Aviv Eyal
@avive
let me know when comments pr@ia ready for review
meant comments pr
is
Onuwa Nnachi Isaac
@iamonuwa
Please check my last PR to see if it's okay or in format
Aviv Eyal
@avive
please add yourselves to authors.md
Onuwa Nnachi Isaac
@iamonuwa
Done that already
Aviv Eyal
@avive
comments are good but can we have it to all sample code?
redux, components, etc... just a one liner for each type / class / method please
Onuwa Nnachi Isaac
@iamonuwa
Alright. I'll fix that right now
Onuwa Nnachi Isaac
@iamonuwa
Please check again
Aviv Eyal
@avive
it is ok - I hope to have more - like 1 line about what each code section does and not just an empty comment
this helps ease-in new devs into the project
for example reducers/index.ts - what is IState and what is initialState?
secondpage/index.tsx - what is each const?
what is class Sample ?
but I think we are 95% there
checking w the gitcoin guys how to make sure the bounty is split between you guys
Onuwa Nnachi Isaac
@iamonuwa
IMHO, a dev that picks this seed will want to remove the component and rewrite
Aviv Eyal
@avive
good job on getting this done!
through config hells!
Onuwa Nnachi Isaac
@iamonuwa
Available to contribute more to growing this seed
Proud of it.
Aviv Eyal
@avive
yes, but the components show a working redux usage
yes - let's make it awesome and popular
you can collab with me on a blog post to describe the motivation and what we have done
Onuwa Nnachi Isaac
@iamonuwa
Will get back to you about the blog post
CI, adding docker to it.
Am fully game
Aviv Eyal
@avive
I think you guys need to go here https://gitcoin.co/issue/spacemeshos/cosmic/2/755
and submit work or something like that - right?
so I can accept the submitted work so you can get the eth
Onuwa Nnachi Isaac
@iamonuwa
Yes
Let me submit
Aviv Eyal
@avive
please go ahead and open a new issue for each idea you have to improve ti
it
Onuwa Nnachi Isaac
@iamonuwa
I think Samuel will equally submit. Or accept mine. Then divide the bounty and send to our addresses