by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Philippe Ombredanne
    @pombredanne
    done ;)
    Rohit Lodha
    @rtgdk
    @anshuldutt21 Can you open a PR against empty master, it's easier to review and add changes?
    Anshul Dutt Sharma
    @anshuldutt21
    @rtgdk Okay will do so.
    ekongobie
    @ekongobie
    @pombredanne @SantiagoTorres @kestewart I've pushed tests on the repo. You can have a look https://github.com/ekongobie/spdx-py-build-tool
    Yash Varshney
    @Yash-Varshney
    @pombredanne @goneall when I'm running document.py, it doesn't shows relationship list in it.
    Screenshot 2020-07-14 at 12.07.23 AM.png
    (above) is the output I got when tried to ran an example, the dict of document doesn't contains 'relationship'.
    the code which I ran to get the above output is .(below)
    Screenshot 2020-07-14 at 12.09.27 AM.png
    RishabhBhatnagar
    @RishabhBhatnagar
    As evident from the class definition here, spdx.document.Document doesn't have any method called add_relationship.
    Yash Varshney
    @Yash-Varshney
    @RishabhBhatnagar I m running this on my local version ( & the recent P.R. as well) where i have created add_relationship method
    You can look here
    RishabhBhatnagar
    @RishabhBhatnagar

    @pombredanne @goneall when I'm running document.py, it doesn't shows relationship list in it.

    I couldn't reproduce the same behavior. I was able to run it without any error. You may refer to the screenshot below for the steps I followed.

    Capture.PNG
    Santiago Torres
    @SantiagoTorres
    I'll be missing the tech call today, they cut water in my building and I need to take care of things :/
    Yash Varshney
    @Yash-Varshney
    thanks @RishabhBhatnagar, I might have to look more. Meanwhile, it would be great if you can look for bugs in spdx/tools-python#143
    Yash Varshney
    @Yash-Varshney
    @pombredanne for relationship.py I have generally taken motivation from annotation class. as, I was looking in document.py file, validate_annotation method does not make any sense. (which was probably going wrong in relationship as well)
    Screenshot 2020-07-15 at 12.09.46 AM.png
    it takes a string from annotations list and does validation of it which results in "AttributeError: 'str' object has no attribute"
    Philippe Ombredanne
    @pombredanne
    when you see code like, please feel free to fix these weird things :+1:
    Yash Varshney
    @Yash-Varshney
    spdx/tools-python#143 is ready to be reviewed ! It is passing all the tests now.
    Smith Tanjong Agbor
    @tjasmith
    @goneall The travis build on the LicenseListPublisher repo fails with this error:
    999.png
    ekongobie
    @ekongobie
    @pombredanne @kestewart @SantiagoTorres I have started the development of the npm build tool. It will still use the python scripts, but will be installable via npm.
    Philippe Ombredanne
    @pombredanne
    @ekongobie nice :) with Python-> JS interpreter?
    ekongobie
    @ekongobie
    @pombredanne yes
    Santiago Torres
    @SantiagoTorres
    so this will be an npm tool to create spdx documents for npm using python?
    Philippe Ombredanne
    @pombredanne
    :D
    @ekongobie tell me where I can see the code
    Gary O'Neall
    @goneall
    GSoC and Community Bridge mentees - we have an SPDX general meeting Thursday August 6 at 8AM Pacific time. We would like to hear from one of you on the project. It would be about a 15 to 20 minute overview of the project presented over Uberconference. Slides and a demo would be nice, but not necessary. @RishabhBhatnagar presented last month and it was well recieved. Let me know who's interested in going next and I'll provide additional details.
    Kate Stewart
    @kestewart
    @ekongobie - do you have a repo visible yet?
    Philippe Ombredanne
    @pombredanne
    @ekongobie :) did you push the npm code too? beside the Python code at https://github.com/ekongobie/spdx-py-build-tool ?
    ekongobie
    @ekongobie
    @pombredanne @kestewart @SantiagoTorres I haven't pushed the npm code yet. Will do soon.
    Philippe Ombredanne
    @pombredanne
    @ekongobie Can you do it ASAP? I want to see it today :P
    ekongobie
    @ekongobie
    Sure
    Philippe Ombredanne
    @pombredanne
    :+1:
    Philippe Ombredanne
    @pombredanne
    @ekongobie gentle ping :)
    ekongobie
    @ekongobie
    @pombredanne yes, you can have a look at that. Though the link with the Python-tools is not yet complete. Working on that right now.
    Philippe Ombredanne
    @pombredanne
    that's OK :)
    @ekongobie let's make sure we exchange more frequently going forward ;)
    ekongobie
    @ekongobie
    @pombredanne Alright. Will do better from now on. :)
    Smith Tanjong Agbor
    @tjasmith
    @goneall Is it Ok if I do the multi-threading in the buildUrlDetails method(inorder to execute each of the methods that get field information in seperate threads), rather than doing the multi-threading in say the writeLicense methods? Can I do the first option, observe the performance and then if needed, proceed to the second option?
    Gary O'Neall
    @goneall
    @tjasmith I agree with your approach of multi-threading in the buildRuleDetails - let me know how it performs.
    Smith Tanjong Agbor
    @tjasmith
    @goneall With that done, I now record a 50% performance increase. The time taken to execute on the license-list-xml/src is slashed by half. Now working on improving it.
    Kate Stewart
    @kestewart
    GSoC students - the mentors started comparing notes yesterday in the SPDX tech meeting (of which you're welcome to attend) and one of the best practices that we've noticed is that one of the mentees is keeping of a daily log document, shared with mentors. In that document, open questions can be captured, and reviewed before meetings, by mentors as well as ad hoc. Feel free to do this in a document on github, or a google document, as you prefer.
    ekongobie
    @ekongobie
    @pombredanne I have added the spdx-tools utils to the npm app, but I am currently facing some issues with the import of foreign packages into scripts for execution. If I don't find a solution on that, I might change the python-npm tool(python-shell).
    @SantiagoTorres Please do you have any experience with that?
    Philippe Ombredanne
    @pombredanne
    @ekongobie Can you explain this more? may be in a ticket?
    ekongobie
    @ekongobie
    @pombredanne @SantiagoTorres It's all sorted, I have solved the issue. The npm tool is 70% complete. Now writing tests. :)
    Smith Tanjong Agbor
    @tjasmith
    @goneall Please can you have a look at the PR?