Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Eli White
    @TheSavior
    Sounds good, thanks
    speedskater
    @speedskater
    On monday the 14th March. I will create a new branch and start with the first samples which currently do not work which come to my mind.
    We will than collect new ideas till mid may and start after that with the implementation of this approach.
    In the mean I will try to fix smaller issues and release bug fix release on every third monday starting with the 14th of March.
    Do you have any further suggestions regarding this roadmap?
    Eli White
    @TheSavior
    I think any expectation of a plan that far out with the few details we have seems likely to be inaccurate to some level.
    speedskater
    @speedskater
    thats definitively true, but we can at least reduce the expectations.
    Eli White
    @TheSavior
    I think the part that is reasonable is your belief on how often you are able to work on it.
    speedskater
    @speedskater
    that's true
    Eli White
    @TheSavior
    If people have problems with that (myself included), then they should dig into the code and solve things themselves.
    speedskater
    @speedskater
    ;)
    Eli White
    @TheSavior
    But we should have a way to support people who are able to do so
    speedskater
    @speedskater
    definitely.
    It is important and we should have some kind of workflow when merges and releases will occur.
    Eli White
    @TheSavior
    I imagine it is very demoralizing to put out a PR that passes builds and looks good but is told it won’t be merged until your every three week period
    speedskater
    @speedskater
    thats true.
    Eli White
    @TheSavior
    I think merges and releases should be as quick as possible assuming that we have high confidence in the change
    speedskater
    @speedskater
    yes thats true. It should be doable as soon as this babel 6 huge issue is out.
    but I think we should have some kind of stages. I we merge fast we should provide a beta first.
    Eli White
    @TheSavior
    What does that optimize for?
    speedskater
    @speedskater
    for higher stability
    Eli White
    @TheSavior
    Do we not have confidence in the test suite?
    speedskater
    @speedskater
    we do, but I am not 100% that we have already tackled all use cases
    Eli White
    @TheSavior
    What a beta implies is that we don’t trust our test suite and need some amount of manual testing
    One approach is to improve our test suite with some amount of integration tests, possibly by doing something crazy like cloning jquery (or some large es6 package) and trying to rewire something in that
    I don’t think that is a good long term solution though
    I think it is reasonable to say that we support everything our unit tests cover
    By merging and releasing quickly we enable it to be quicker to get fixes, and we at least validate against regressions
    speedskater
    @speedskater
    thats reasonable but I mean more something like the wildcard imports we haven't considered in the first place but are out there. But I like your approach regarding using existing libraries and their unit tests for integration
    we can do this. I would propose the following. I create the babel 6 release till the end of this week. than I will make you contributor as well and we try both to merge asap and release after some kind of four eye check?
    Eli White
    @TheSavior
    I don’t have the context for specific code changes as you do
    But that sort of plan sounds good in the aggregate
    speedskater
    @speedskater
    Okay. Than I'will try my best to stick to the plan. I will have to go offline now. We can chat again in some days after the released version.
    Eli White
    @TheSavior
    :+1:
    speedskater
    @speedskater
    bye
    speedskater
    @speedskater
    its done babel 6 version shipped as rc1. As soon as no major issues occur we will finally ship 1.0.0
    and from there move on as planned
    Andrew Throener
    @trainerbill

    @speedskater I am interested in testing out this plugin. I npm to the babel6-support branch and added it to babelrc and getting:

    SyntaxError in plugin 'gulp-babel'
    Message:
    Unexpected token import

    Andrew Throener
    @trainerbill

    changed to master branch and getting:

    TypeError in plugin 'gulp-babel'
    Message:
    Filename must be a string

    speedskater
    @speedskater
    @trainerbill I think you can just use the main branch and run 1.0.0-rc-1 as this is the current default version. the babel6-support branch is quite old
    Eli White
    @TheSavior
    @speedskater I’m pretty excited about this version but it looks like it doesn’t quite work with our system at work yet
    Andrew Throener
    @trainerbill
    @speedskater Yeah I got it working. I also had rewire installed which it was choking on.

    @speedskater on thing I am noticing is that Rewire isn't available on a * import:

    import * as mymodule from './mymodule;

    mymodule.Rewire is undefined. if I have a export default fallback it seems to work. Is that your suggested use?

    Andrew Throener
    @trainerbill

    @speedskater came across an edge case. I am getting:

    Duplicate declaration "typeOfOriginalExport" (This is an error on an internal node. Probably an internal error)

    and I think its because it is doing the rewire twice. I am using gulp babel and also a build procedure with a dynamic require. Is there a check to see if the import/require has already been rewired?

    Eli White
    @TheSavior
    @trainerbill Did you search the issues? speedskater/babel-plugin-rewire#106
    Andrew Throener
    @trainerbill
    thx @TheSavior. Did you find a work around?
    Eli White
    @TheSavior
    Nope. We are still on babel5 because of it
    I’m curious how similar of an environment you are in to us
    Are you using browserify with babelify?
    Andrew Throener
    @trainerbill
    no. I am working on the server side in Node
    Eli White
    @TheSavior
    Did you look at the repro repo that I put up?
    You should see if you have a similar situation of requires