Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 28 2019 14:22
    guog starred spotify/heroic
  • Jan 27 2019 10:29
    udoprog added as member
  • Jan 26 2019 18:15
    danielnorberg removed as member
  • Jan 26 2019 18:15
    rohansingh removed as member
  • Jan 23 2019 08:17
    garciparedes starred spotify/heroic
  • Jan 23 2019 04:28
    odeke-em starred spotify/heroic
  • Jan 22 2019 09:39
    anke522 starred spotify/heroic
  • Jan 21 2019 13:23
    svergtanya starred spotify/heroic
  • Jan 18 2019 16:16

    lmuhlha on 0.8.5

    (compare)

  • Jan 17 2019 22:00
    hashkanna starred spotify/heroic
  • Jan 16 2019 21:29

    lmuhlha on suggestfail

    (compare)

  • Jan 16 2019 21:29

    lmuhlha on master

    Don't mark all api nodes as unh… Merge pull request #406 from sp… (compare)

  • Jan 16 2019 21:29
    lmuhlha closed #406
  • Jan 16 2019 20:20
    codecov[bot] commented #406
  • Jan 16 2019 20:03
    lmuhlha review_requested #406
  • Jan 16 2019 20:03
    lmuhlha review_requested #406
  • Jan 16 2019 20:03
    lmuhlha opened #406
  • Jan 16 2019 20:03

    lmuhlha on suggestfail

    Don't mark all api nodes as unh… (compare)

  • Jan 16 2019 19:59

    lmuhlha on suggestfail

    Don't mark all api nodes as unh… (compare)

John-John Tedro
@udoprog
Hey, I set this up now. :)
Tariq Ibrahim
@tariq1890
That's awesome.!
John-John Tedro
@udoprog
hey @tariq1890
Tariq Ibrahim
@tariq1890
Hello. Do you want to discuss the REST resource test cases?
John-John Tedro
@udoprog
yeah sure
an outstanding issue is that not all data-models have client-oriented implementations. they might not be deserializable. this is true for MetricResponse iirc.
but for the ones which does work straight out of the box, it's good to just move forward with what you want to do
Tariq Ibrahim
@tariq1890
Oh alright
John-John Tedro
@udoprog
it would also be good to use random ports in the test, this can be accomplished by setting up the instance in the integration test and extracting the port through ServerInstance (or something like that). It was previously used in some python-based integration tests, but scrapped in favor of the internal ClusterIT and family.
But I think the functionality for binding to a random port, and getting which port was bound is still present, since it's still in use here: https://github.com/spotify/heroic/blob/master/heroic-core/src/main/java/com/spotify/heroic/HeroicStartupPinger.java#L95
you can get access to HttpServer through dependency injection, and extract the port that was used like this: https://github.com/spotify/heroic/blob/master/heroic-dist/src/test/java/com/spotify/heroic/AbstractLocalClusterIT.java#L165 (c is a HeroicCoreInstance)
Tariq Ibrahim
@tariq1890
Ohh alright. Cool. I'll check this out as well.
Tariq Ibrahim
@tariq1890
I am using gitter on my phone right now. Thanks for the tip :)
John-John Tedro
@udoprog
yeah, no worries
Tariq Ibrahim
@tariq1890
Hey @udoprog
Tariq Ibrahim
@tariq1890
Regarding MetricsResponse
Any plans to write a @JsonDeserializer for it?
I guess for now, that would be useful for test cases. But I was wondering, would a use case ever come up when you’d need to consume the QueryMetricsResponse in another web application ? In that case, deserializating of the json would be required, correct?
If you do see a good use for it, I am happy to write a JsonDeserializer and submit it as a PR
John-John Tedro
@udoprog
For a stable java client. So yeah. But doing it this way would require a re-org of the code, and the goals between a server and client the to be different. One has more emphasis on maintaining compatibility.
Tariq Ibrahim
@tariq1890
Oh alright
John-John Tedro
@udoprog
Tend*
jcabmora
@jcabmora
Hello guys!
John-John Tedro
@udoprog
jcabmora: hey!
Tariq Ibrahim
@tariq1890
Hey @udoprog
John-John Tedro
@udoprog
Yeah?
Tariq Ibrahim
@tariq1890
I was looking at the code for AbstractLocalConsumerIT
And It does a lot of initialization work.
Is there a possibility to mock out the other HeroicModules ?