Any plans to write a @JsonDeserializer for it?
I guess for now, that would be useful for test cases. But I was wondering, would a use case ever come up when you’d need to consume the QueryMetricsResponse in another web application ? In that case, deserializating of the json would be required, correct?
If you do see a good use for it, I am happy to write a JsonDeserializer and submit it as a PR
And It does a lot of initialization work.
Is there a possibility to mock out the other HeroicModules ?
Writing multiple test cases for resource classes would be overkill if I am not mistaken
if we have the Integration test starting up all the modules and built-in modules.
I could use that actually
Thanks. I’ll get to using that.
Like the array ast that is filters.
Nothing as good as Gorilla though. That would complicate ingestion.
Hi again, can i query the raw values within a range using heroic? I am not sure if the aggregation (https://spotify.github.io/heroic/#!/docs/api/post-query-metrics) is optional.
Hello @udoprog ! I was wondering if you had a chance to look at spotify/heroic#371. Build is failing coverage, and I was wondering if you have any pointers about how to solve this. I actually added an integration test (which is passing) . I suspect the codecov tests might be broken since they are pointing to stuff that was not changed on the PR that I submitted. E.g. https://codecov.io/gh/spotify/heroic/pull/371/changes
ERR: ShardError(nodes=[LocalClusterNode(localMetadata=NodeMetadata(version=0, id=0336e36b-8d5c-49bb-9d8d-b435eb9eaf32, tags={}, service=ServiceInfo(name=The Heroic Time Series Database, version=0.0.1-SNAPSHOT, id=heroic)))], shard={}, error=Some fetches failed (4) or were cancelled (0), caused by Some fetches failed (4) or were cancelled (0))
I'm attempting to update a rather ancient heroic deployment to 0.8.7 and from the kafka consumer to the
+pubsub consumer, and am running into a frankly bizarre issue: messages with a certain key format appear to be silently not recorded in the metrics backend.
+pubsub consumer, and am running into a frankly bizarre issue: messages with a certain key format appear to be silently not recorded in the metrics backend.