Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Marcin Grzejszczak
    @marcingrzejszczak
    yo, I've closed the sleuth issue related to executor services and the async span. Can you please check how things work with the latest snapshots? (spring-cloud/spring-cloud-sleuth#1465)
    Ray Tsang
    @saturnism
    👋
    Elena Felder
    @elefeint
    Thank you! I'll test it today.
    Elena Felder
    @elefeint
    @marcingrzejszczak Well, the part that propagates scheduler bean names works great. But we have not integrated with 3.0.0 before, so I've ran into a number of issues -- I'll come up with coherent questions on the ones I resolved tomorrow, but the one I am stuck on is -- should Sleuth provide a default SpanHandler, or should we write one in Spring Cloud GCP?
    Marcin Grzejszczak
    @marcingrzejszczak
    Hmm i haven't seen such an issue before. Can you show me the stacktrace?
    Elena Felder
    @elefeint
    no issue, just traces not showing up -- the sampling works, but because SpanHandler bean is needed to bridge from instrumentation to reporter, the traces don't make it to reporter. It's configured for Zipkin here: https://github.com/spring-cloud/spring-cloud-sleuth/blob/bd149ce4a7c2154fe8526394d14b6ab89addd62e/spring-cloud-sleuth-zipkin/src/main/java/org/springframework/cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java#L179 , I am guessing we need to do the same for Stackdriver
    I'll look more into it today; don't worry about it yet
    need to read the comprehensive documentation Adrian usually writes for changes. In "hours of troubleshooting can save minutes of reading documentation" situation, clearly.
    Marcin Grzejszczak
    @marcingrzejszczak
    :D
    Kriti
    @Kriti84252554_twitter
    Hi, is there any sample project for generating tokens from google cloud APIs? The userCredentials are stored in GCP
    Mike Eltsufin
    @meltsufin
    @Kriti84252554_twitter Can you clarify what kind of tokens you're looking to generate and for what kind of use case?
    Kriti
    @Kriti84252554_twitter
    Hi @meltsufin I want to validate my users against GCP IAM using spring boot application
    but I do not want to re-direct them to google SSO page
    Mike Eltsufin
    @meltsufin
    How do your users provide the credentials to your app?
    Also, maybe this page is relevant: https://cloud.google.com/iam/docs/testing-permissions.
    Daniel Zou
    @dzou
    @spencergibb -- Hey Spencer, what's your recommendation for how to move forward on this issue: spring-cloud/spring-cloud-config#1695 Our pub/sub integration using the config server is affected by this too. Curious what your recommendations are for integrators; I can see users setting the legacy-processing setting on an individual level, but what are recommended practices for library integrators to get things working out of the box? @ttomsu has some more context too.
    Spencer Gibb
    @spencergibb
    it's a documentation issue
    if bootstrap is required there is a new spring-cloud-starter-bootstrap to enable it by default. We want to move to the spring.config.import style
    Daniel Zou
    @dzou
    Ah I see, thank you for clarifying!
    Spencer Gibb
    @spencergibb
    @dzou made some comments there, you'll need to set a property or include a new starter. But we are planning on moving to the new import as the default way of working.
    Travis Tomsu
    @ttomsu
    Hmmm... I added that spring.cloud.bootstrap.enabled=true value and I'm still not seeing the value in /actuator/env
    @spencergibb ^
    Spencer Gibb
    @spencergibb
    @ttomsu where did you add the property?
    Travis Tomsu
    @ttomsu
    ahh, I think I got it with both the spring-cloud-starter-bootstrap and the property set
    Spencer Gibb
    @spencergibb
    shouldn't be needed. Where did you add the property?
    Travis Tomsu
    @ttomsu
    application.properties
    Spencer Gibb
    @spencergibb
    it can't be in application.properties because that is too late. Either needs to be a cli arg, system property or env var.
    the starter on its own should work
    Travis Tomsu
    @ttomsu
    I see - I recall reading something about bootstrap.yml - is that the same thing?
    (apologies for silly questions - dusting off the cobwebs)
    Spencer Gibb
    @spencergibb
    only if bootstrap is enabled
    Travis Tomsu
    @ttomsu
    is bootstrap new? I've never heard of it
    Spencer Gibb
    @spencergibb
    nope
    Daniel Zou
    @dzou
    @artembilan - Hey Artem, do you know who might be able to help us with this Actuator question? spring-cloud/spring-cloud-commons#833
    We have a question about how to refresh the application context correctly for a Spring Property Source that maintains an active connection with an external resource
    Artem Bilan
    @artembilan
    @RefreshScope... Probably @spencergibb is the best person to give you some clue...
    Travis Tomsu
    @ttomsu
    Good Morning @spencergibb - question for you re: Ilford releasing. Would it be a bad idea if we started depending on more stable POMs on our master branch - say milestone or even full releases? Based on the breakages from a couple weeks ago, it seems like our build's greenness is highly dependent on numerous SNAPSHOT dependencies.
    Investigating why a build breaks isn't a cheap task either (at least for me, since I'm pretty new to the team).
    Spencer Gibb
    @spencergibb
    we have to go back and forth. The only one we can do is boot. You're free to pin to a milestone of ilford
    unfortunately when there are api changes there's not much we can do
    Travis Tomsu
    @ttomsu
    Totally understandable - there's little we can do too!
    It's basically all the same amount of time - pinning dependencies at least allows us to schedule time to do upgrades vs spending that time randomly throughout the quarter when something breaks.
    I just didn't know if there was something I wasn't aware of that we should know about before doing that
    wilacosta1
    @wilacosta1
    quick question, there any tool to use kms (Cloud Key Management)
    Mike Eltsufin
    @meltsufin
    @wilacosta1 We do not have any specific support for KMS in Spring Cloud GCP, but can you elaborate on your use-case?
    Spencer Gibb
    @spencergibb
    @meltsufin @ttomsu @dzou or @elefeint did you use a tool to transfer any issues to the new repo?
    Mike Eltsufin
    @meltsufin
    @spencergibb No, not yet, and we probably won't.
    Spencer Gibb
    @spencergibb
    thanks
    Travis Tomsu
    @ttomsu
    @spencergibb - qq. When you're doing a release, do you have to do a ./mvnw install first? We're running into an issue where maven fails during a ./mvnw clean deploy because it can't find the submodule spring-cloud-gcp-dependencies, which makes sense because we're literally trying to publish it!
    
    [INFO] Downloading from spring-milestones: https://repo.spring.io/milestone/com/google/cloud/spring-cloud-gcp-dependencies/2.0.0/spring-cloud-gcp-dependencies-2.0.0.pom
    [INFO] Downloading from spring-releases: https://repo.spring.io/release/com/google/cloud/spring-cloud-gcp-dependencies/2.0.0/spring-cloud-gcp-dependencies-2.0.0.pom
    [INFO] Downloading from gcs-mirror: https://maven-central.storage-download.googleapis.com/repos/central/data/com/google/cloud/spring-cloud-gcp-dependencies/2.0.0/spring-cloud-gcp-dependencies-2.0.0.pom
    [INFO] Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/spring-cloud-gcp-dependencies/2.0.0/spring-cloud-gcp-dependencies-2.0.0.pom
    [ERROR] [ERROR] Some problems were encountered while processing the POMs:
    [ERROR] Non-resolvable import POM: Could not find artifact com.google.cloud:spring-cloud-gcp-dependencies:pom:2.0.0 in spring-milestones (https://repo.spring.io/milestone) @ line 87, column 16
     @ 
    [ERROR] The build could not read 1 project -> [Help 1]
    [ERROR]   
    [ERROR]   The project com.google.cloud:spring-cloud-gcp:2.0.0 (/tmpfs/src/github/spring-cloud-gcp/pom.xml) has 1 error
    [ERROR]     Non-resolvable import POM: Could not find artifact com.google.cloud:spring-cloud-gcp-dependencies:pom:2.0.0 in spring-milestones (https://repo.spring.io/milestone) @ line 87, column 16 -> [Help 2]
    The only big change we made was removing the parent POM from our root POM.
    Spencer Gibb
    @spencergibb
    @ttomsu yes we do an install first