spring-cloud-gcp/Lobby

Nuno Marujo

@nhmarujo

Dependency convergence error for com.google.protobuf:protobuf-java:3.7.1 paths to dependency are:
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.protobuf:protobuf-java-util:3.7.1
            +-com.google.protobuf:protobuf-java:3.7.1
and
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.api.grpc:proto-google-common-protos:1.16.0
            +-com.google.protobuf:protobuf-java:3.7.1
and
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.api.grpc:proto-google-iam-v1:0.12.0
            +-com.google.protobuf:protobuf-java:3.5.1

[WARNING] 
Dependency convergence error for com.google.guava:guava:27.1-android paths to dependency are:
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.guava:guava:27.1-android
and
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.http-client:google-http-client:1.30.1
            +-com.google.guava:guava:26.0-android
and
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.api:api-common:1.8.1
            +-com.google.guava:guava:26.0-android
and
+-com.nhmarujo:asset-manager:0.0.1-SNAPSHOT
  +-org.springframework.cloud:spring-cloud-gcp-starter-storage:1.1.3.RELEASE
    +-org.springframework.cloud:spring-cloud-gcp-starter:1.1.3.RELEASE
      +-org.springframework.cloud:spring-cloud-gcp-core:1.1.3.RELEASE
        +-com.google.cloud:google-cloud-core:1.78.0
          +-com.google.api:gax:1.45.0
            +-com.google.guava:guava:26.0-android

(this is just a part, it is quite big)

picking up the very first example, all the conflicts for protobuf-java are happening inside spring-cloud-gcp-starter-storage

Nuno Marujo

@nhmarujo

see what I mean @elefeint ?

Elena Felder

@elefeint

I do! We are at Spring One right now, but I will look into the dependencies in the evening. Thanks for letting us know!

Nuno Marujo

@nhmarujo

You’re welcome! Thank you for taking a look at it @elefeint . That was just an example, but I saw conflicts in the following dependencies:

com.google.api:api-common
com.google.api.grpc:proto-google-common-protos
com.google.api-client:google-api-client
com.google.auth:google-auth-library-oauth2-http
com.google.auth:google-auth-library-credentials
com.google.http-client:google-http-client
com.google.protobuf:protobuf-java
io.opencensus:opencensus-api
io.opencensus:opencensus-contrib-http-util

Enjoy the conference! :)

Mike Eltsufin

@meltsufin

It looks like the conflicts are happening under the google-cloud-core:1.78.0 dependency, which we don't really control. You see that we're using the same version of the Google Client libraries, but they have their own dependency conflicts.

It also looks like we don't have the latest version of Google Cloud Java in 1.1.3.

see: https://github.com/googleapis/google-cloud-java

Nuno Marujo

@nhmarujo

I see what you mean @meltsufin . You are right, those conflicts are on googleapis side

Do you think that bumping to a newer version of google-cloud-java might fix it?

Elena Felder

@elefeint

@meltsufin But should we file a diamond dependency issue in google cloud java?

Mike Eltsufin

@meltsufin

@elefeint I think we should first see if upgrading to latest google cloud java libs umbrella version resolves the issue.

Tracking issue: spring-cloud/spring-cloud-gcp#1975

Nuno Marujo

@nhmarujo

thank you both @meltsufin and @elefeint

The issue you mentioned doesn’t have the full issue report (gitter code snippet limitations), but I’ll update spring-cloud/spring-cloud-gcp#1975 with it

Mike Eltsufin

@meltsufin

Thanks!

Nuno Marujo

@nhmarujo

You’re welcome! :)

Nuno Marujo

@nhmarujo

Hey everyone. I’m using Spring Webflux and I’m receiving a Flux<FilePart> on a REST endpoint. I would like to stream that to a bucket on Google Storage. Unfortunately I’m failing to find out how. Anyone can point me in the right direction, please?

Mike Eltsufin

@meltsufin

How would you write it to a plain old file?

Nuno Marujo

@nhmarujo

well, for a file on the local filesystem, it has a transferTo(Path path) method

but none that takes an Outputstream

Mike Eltsufin

@meltsufin

I guess FilePart is designed just to write to local filesystem. You'd have to send the file to GCS separately after it has been written locally. Otherwise, this is really more of a question for Spring Framework Core. https://github.com/spring-projects/spring-framework/issues

Nuno Marujo

@nhmarujo

I would like to just pipe each chunk directly to gcp and avoid a lot of memory consumption

Will check. Thanks

stevenweili

@stevenweili

I just reported an issue of 1.2.0.M3, project id not found while run in PCF, it works after I downgrade to 1.2.0.M2.
spring-cloud/spring-cloud-gcp#1994
@meltsufin can you help check?

Mike Eltsufin

@meltsufin

yeah, I'll respond on the issue

Artem Bilan

@artembilan

Any thoughts here: https://stackoverflow.com/questions/58642522/gcp-pub-sub-how-to-get-event-details-in-onfailure-of-publishcallbacklistener ?

Looks like SettableApiFuture comes without a message in the exception we have just sent

Mike Eltsufin

@meltsufin

It all comes down to what we get from the Pub/Sub client library.

See: https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java

Artem Bilan

@artembilan

OK. I got. Does it bother you to answer to that SO question? Thanks

Mike Eltsufin

@meltsufin

All we get is a message id, if successful, and exception if failure

not at all

Of course we can change change the type of the future to include the original message as well, if that's what they are asking

Artem Bilan

@artembilan

right, at least into an exception part

Mike Eltsufin

@meltsufin

responded, feel free to add more to the conversation

Artem Bilan

@artembilan

Thanks, Mike! That all :smile:

Mike Eltsufin

@meltsufin

np, thanks for bringing it to my attention :)

Mike Eltsufin

@meltsufin

is Hoxton release still on track for tomorrow?

Ryan Baxter

@ryanjbaxter

it will be RC2

Mike Eltsufin

@meltsufin

oh ok

Attoumane

@akuma8

Please let us know here when it will be released, I am waiting for it before migrating to Spring Boot 2.2 and Java 13. 🙏

Ryan Baxter

@ryanjbaxter

@here we are trying to do the Greenwich.SR4 release and sc-gcp is failing

11:27:39 [ERROR] testValidObject(org.springframework.cloud.gcp.autoconfigure.storage.GcpStorageAutoConfigurationTests)  Time elapsed: 0.001 s  <<< ERROR!
11:27:39 java.lang.IllegalStateException: Failed to load ApplicationContext
11:27:39 Caused by: java.lang.IllegalStateException: Error processing condition on 
org.springframework.cloud.sleuth.instrument.web.TraceHttpAutoConfiguration.httpClientParser
11:27:39 Caused by: java.lang.IllegalStateException: Failed to introspect Class [org.springframework.cloud.sleuth.instrument.web.TraceHttpAutoConfiguration] from ClassLoader [sun.misc.Launcher$AppClassLoader@75b84c92]
11:27:39 Caused by: java.lang.NoClassDefFoundError: brave/sampler/SamplerFunction
11:27:39 Caused by: java.lang.ClassNotFoundException: brave.sampler.SamplerFunction

does that make any sense to anyone?

Ryan Baxter

@ryanjbaxter

looks like the problem shows up when moving to sleuth 2.1.6

Ryan Baxter

@ryanjbaxter

looks like it was due to a mismatch in the version of brave being used, I bumped the version to 5.8.0 and ran the build and the problem went away, I will submit a PR with the changes

Mike Eltsufin

@meltsufin

Thanks, merged PR

Where communities thrive

People

Repo info

Activity