Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ryan Baxter
    @ryanjbaxter
    11:27:39 [ERROR] testValidObject(org.springframework.cloud.gcp.autoconfigure.storage.GcpStorageAutoConfigurationTests)  Time elapsed: 0.001 s  <<< ERROR!
    11:27:39 java.lang.IllegalStateException: Failed to load ApplicationContext
    11:27:39 Caused by: java.lang.IllegalStateException: Error processing condition on 
    org.springframework.cloud.sleuth.instrument.web.TraceHttpAutoConfiguration.httpClientParser
    11:27:39 Caused by: java.lang.IllegalStateException: Failed to introspect Class [org.springframework.cloud.sleuth.instrument.web.TraceHttpAutoConfiguration] from ClassLoader [sun.misc.Launcher$AppClassLoader@75b84c92]
    11:27:39 Caused by: java.lang.NoClassDefFoundError: brave/sampler/SamplerFunction
    11:27:39 Caused by: java.lang.ClassNotFoundException: brave.sampler.SamplerFunction
    does that make any sense to anyone?
    Ryan Baxter
    @ryanjbaxter
    looks like the problem shows up when moving to sleuth 2.1.6
    Ryan Baxter
    @ryanjbaxter
    looks like it was due to a mismatch in the version of brave being used, I bumped the version to 5.8.0 and ran the build and the problem went away, I will submit a PR with the changes
    Mike Eltsufin
    @meltsufin
    Thanks, merged PR
    Ryan Baxter
    @ryanjbaxter
    awesome
    Daniel Zou
    @dzou
    Hey guys, I saw 1.2 was released. Thank you for your work on this. I wanted to followup on a question we had about our landing page documentation a while back. We updated our sagan-index.adoc but it doesn't appear to have updated. Are we missing something? Was curious how we can get the updated sagan-index.adoc for our landing page on spring.io.
    Ryan Baxter
    @ryanjbaxter
    @dzou I updated the page, not sure why it didnt happen automatically
    let me know if something doesnt look right
    @here would someone like to give me some highlights of features/changes made in gcp to highlight in the Hoxton release blog post?
    Mike Eltsufin
    @meltsufin
    Mike Eltsufin
    @meltsufin
    The major changes are added support for BigQuery and Spring Data Reactive Repositories for Cloud Firestore
    Marcin Grzejszczak
    @marcingrzejszczak
    @dzou most likely we had an issue with sagan and the page didn't get updating
    Spencer Gibb
    @spencergibb
    Seeing a build failure. Hoping to release today org.springframework.cloud.gcp.data.datastore.repository.query.PartTreeDatastoreQueryTests.pageableQueryNoPageableParam
    Error Details
    Expecting:
    <2>
    to be equal to:
    <1>
    but was not.
    Stack Trace
    Elena Felder
    @elefeint
    I am about to fix that
    Spencer Gibb
    @spencergibb
    @elefeint thanks, can you ping me when you are done?
    Elena Felder
    @elefeint
    Waiting for Travis to build. The brief commercial break in my brain features Chicago's "All that Jazz": " Come on, Travis, got to run that build, and fix this test, and fix this test! ... And all... those... teeeeests!"
    Spencer Gibb
    @spencergibb
    :stuck_out_tongue_winking_eye:
    Elena Felder
    @elefeint
    @spencergibb Build is fixed.
    Spencer Gibb
    @spencergibb
    cool, watching jenkins build (since that's what does the release).
    Elena Felder
    @elefeint
    yep. The branch travis build runs integration tests, so it will run for a while, but since Jenkins only runs unit tests, it should match the PR build results. (internally debating whether knocking on synthetic surface counts as knocking on wood)
    Spencer Gibb
    @spencergibb
    :+1:
    Spencer Gibb
    @spencergibb
    we're green in jenkins too
    Elena Felder
    @elefeint
    excellent!
    Artem Bilan
    @artembilan
    I’d appreciate if someone from GCP team can jump into this for investigation: https://stackoverflow.com/q/59418646/2756547. I can help with Spring Integration part, but why it doesn’t finish write into the file in GCP is out of my knowledge. Thanks in advance!
    Marcin Grzejszczak
    @marcingrzejszczak
    Yo, we need your help with spring-cloud/spring-cloud-gcp#2091
    you can't use the commons version for spring cloud bus since those are separate projects with different release cycles
    Elena Felder
    @elefeint
    @marcingrzejszczak Thank you for fixing that. Is there anything else blocking the release now?
    Elena Felder
    @elefeint
    @artembilan I asked some clarifying questions. Hopefully this will show a direction to dig in
    Marcin Grzejszczak
    @marcingrzejszczak
    nope
    Elena Felder
    @elefeint
    @artembilan parachuting into your conversation with @meltsufin, since I bumped the samples version to the latest spring-boot, vaguely expecting spring-cloud-build to open to snapshots soon. I've asked a spring-cloud-build question -- spring-cloud/spring-cloud-build#149
    Artem Bilan
    @artembilan
    2.2.x and 2.3.x that's not true
    You have misunderstood that Ilford is going to be GA when we have SB-2.4 already
    but that's fully doesn't mean that SR release will move to SB minor release
    that's fully not correct
    Elena Felder
    @elefeint
    so Ilford should be moving to 2.3.x?
    Artem Bilan
    @artembilan
    Ilford will move to SB-2.3 ASAP
    Elena Felder
    @elefeint
    excellent! Happy to be wrong on that
    Artem Bilan
    @artembilan
    and will switch to SB-2.4 when that is going to be available somewhere in May
    Mike Eltsufin
    @meltsufin
    Are Hoxton SRs all going to stay on SB-2.2, or will they at some point move to SB-2.3?
    Artem Bilan
    @artembilan
    No. That's not how our support policy works
    We don't upgrade to minor releases in the point releases
    That's kinda very high possibility of braking changes and byte-code incompatiblity
    Like we faced yesterday with SI-5.3 and SCSt-Horsham
    Mike Eltsufin
    @meltsufin
    So, there will never be a version of Spring Cloud based on SB-2.3?
    I thought that SB-2.3 is more of a minor release. So, things might be different.
    Unreleated: The first link on our "Learn" tab is broken:
    https://cloud.spring.io/spring-cloud-gcp/1.2.x/reference/html/
    Artem Bilan
    @artembilan
    there is no 1.2.x dir in the gh-pages branch: https://github.com/spring-cloud/spring-cloud-gcp/tree/gh-pages
    Mike Eltsufin
    @meltsufin
    what's the process for creating it? I don't recall how w did the 1.1.x
    Artem Bilan
    @artembilan
    I don't know. Let's ask @marcingrzejszczak ! :smile: