Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Elena Felder
    @elefeint
    running integration tests
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    thanks @elefeint - please let me know when it's ready to retry the release process
    Elena Felder
    @elefeint
    will send a PR in a minute. Non-urgent question: do you use gradle for releases?
    spring-cloud/spring-cloud-gcp#2236 -- see if you can approve?
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    done
    Elena Felder
    @elefeint
    Can you retry the release?
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    rerunning
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    @elefeint Worked now - thanks :)
    Elena Felder
    @elefeint
    excellent
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    we're done with the dry run; running the actual release process now
    Daniel Zou
    @dzou

    Hey, thank you guys for completing the release for us.

    I wanted to ask if we could also update our API docs link on spring.io for version 1.2.2 (Current, GA) with this link for javadocs: https://googleapis.dev/java/spring-cloud-gcp/1.2.2.RELEASE/index.html

    Spencer Gibb
    @spencergibb
    done
    Daniel Zou
    @dzou
    Many thanks; really appreciate the fast response!
    Serhat Soydan
    @ssoydan-strands

    Hey,
    I don't know if I am missing something but;
    I tried to upgrade the dependency of spring-cloud-gcp-starter-pubsub in my project (spring-boot 2.1.4.RELEASE) to 1.2.2.RELEASE and then started it, I got some errors about PubSubHealthIndicator:

    2020-03-06T11:43:16,046 INFO (1)main [AnnotationUtils.java:1973]: Failed to introspect annotations on class org.springframework.cloud.gcp.autoconfigure.pubsub.health.PubSubHealthIndicatorAutoConfigurationEnhancerBySpringCGLIBEnhancerBySpringCGLIB6ba30de8: java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy
    2020-03-06T11:43:16,059 INFO (1)main [PostProcessorRegistrationDelegate.java:330]: Bean 'org.springframework.transaction.annotation.ProxyTransactionManagementConfiguration' of type [org.springframework.transaction.annotation.ProxyTransactionManagementConfigurationEnhancerBySpringCGLIBEnhancerBySpringCGLIB6b3fbf4] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)

    I think it is because "HealthContributorAutoConfiguration" class used in "PubSubHealthIndicatorAutoConfiguration" is added to SpringBoot after 2.2.0, so it does not work with Spring Boot versions below that one!

    If you confirm that it is a bug, I can create an issue. Currently the new release requires at least SpringBoot 2.2.0
    Serhat Soydan
    @ssoydan-strands
    I think the workaround is to have: "management.health.pubsub.enabled=false" if you use SpringBoot version below 2.2.0, then it works.
    Serhat Soydan
    @ssoydan-strands
    I created the issue, anyone can comment on there: spring-cloud/spring-cloud-gcp#2242
    Thanks.
    Arash
    @arashbi
    Does Sleuth supports pubsub? I would like to track a message's flow over a set of topics.
    Daniel Zou
    @dzou
    @meltsufin - was Sleuth support for pub/sub something we were targetting the upcoming quarter?
    Mike Eltsufin
    @meltsufin
    It seems like it should work as long as everything is using Spring Integration, but not if you're using PubSubTemplate directly. This hasn't been verified though AFAIK. Also see: spring-cloud/spring-cloud-gcp#2073
    Arash
    @arashbi
    I see
    Arash
    @arashbi
    thanks!
    does sleuth support opencensus?
    I see a ticket from 2018 on opencensus which is still open, but I thought I read somewhere that it is there
    Arash
    @arashbi
    ah, stackdrive implementation is there directly, which goes trough opencensus I would guess
    Elena Felder
    @elefeint
    We actually don't go through opencensus -- the spring-cloud-gcp-starter-trace uses Zipkin sender, which uses Stackdriver APIs directly
    Daniel Zou
    @dzou
    Hey we're interested in writing a Spring Cloud Functions adapter for GCP Cloud Functions; is there anyone involved with the project that we can ask some questions? @artembilan - Would you know someone by any chance?
    Artem Bilan
    @artembilan
    Oleg Zhurakousky (@olegz) is the right person to talk to.
    So, do you mean GCP Cloud Functions is the thing now for Java? :smile:
    Daniel Zou
    @dzou
    !
    Maybe... ;)
    Thanks for the contact.
    Oskar Olsson
    @olssonoskar

    Hello everyone!

    I'm having some issues enabling Stackdriver Trace in a project that is using FirestoreReactiveRepository.
    Having tracing enabled with spring-cloud-gcp-starter-trace and doing something basic like fetching a document with a specific id will result in:

    'org.springframework.cloud.gcp.data.firestore.FirestoreDataException: Error while reading entries by id; nested exception is io.grpc.StatusRuntimeException: UNIMPLEMENTED: GRPC target method can't be resolved.'

    Is this not currently supported?

    dmitry-s
    @dmitry-s
    Hi @olssonoskar !
    could you submit an issue on our github tracker? Also, please include some sample code that replicates the issue.
    Thanks
    Oskar Olsson
    @olssonoskar
    Will do, thanks @dmitry-s
    Volkan Yazıcı
    @vy
    Hello! Trying to use spring-integration in combination with spring-cloud-gcp to handle messages in batches. For this purposes, AggregatingMessageHandler expects me to provide a CorrelationStrategy, of which I don't have any for Pub/Sub. Receiving messages in batches in random order is perfectly fine by me. How shall I pass a CorrelationStrategy in this case?
    Artem Bilan
    @artembilan
    I think there is no a "message group" concept in Pub/Sub at all
    so, you are on your own to determine whatever "key" could be used as a group identifier
    and that one is going to be for CorrelationStrategy against every incoming message.
    Volkan Yazıcı
    @vy

    @artembilan I've come up with this one:

    object SpringConstantCorrelationStrategy: CorrelationStrategy {
    
        override fun getCorrelationKey(message: Message<*>?): Any = "constant"
    
    }

    Though I am not sure if it'll do what it is expected to do.

    Artem Bilan
    @artembilan
    It does
    but you are going to have only one group for all the message
    and you are going to process all the released group instances only in a single thread
    Volkan Yazıcı
    @vy
    @artembilan What do you mean? I won't be able to receive messages in batches?
    Artem Bilan
    @artembilan
    Please, read more about an aggregator in Spring Integration docs: https://docs.spring.io/spring-integration/docs/current/reference/html/message-routing.html#aggregator
    Volkan Yazıcı
    @vy

    and you are going to process all the released group instances only in a single thread

    In that case, shall I return a random String from a set of size concurrency, e.g., available CPU count?

    Artem Bilan
    @artembilan
    The CorrelationStrategy brings us a hook how to determine which group the current message belongs
    when a ReleaseStrategy is satisfied, the aggregator releases a whole group with messages arrived to it so far
    I somehow believe that there could be some business key in all your Pub/Sub messages to distinguish their group in your app