by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    09:01:51 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project spring-cloud-gcp-pubsub: Compilation failure
    09:01:51 [ERROR] /opt/jenkins/data/workspace/spring-cloud-openjdk14-spring-cloud-gcp-master-ci/spring-cloud-gcp-pubsub/src/main/java/org/springframework/cloud/gcp/pubsub/support/converter/PubSubMessageConverter.java:[46,15] An unhandled exception was thrown by the Error Prone static analysis plugin.
    09:01:51 [ERROR]      Please report this at https://github.com/google/error-prone/issues/new and include the following:
    09:01:51 [ERROR]   
    09:01:51 [ERROR]      error-prone version: 2.3.2
    09:01:51 [ERROR]      BugPattern: TypeParameterUnusedInFormals
    09:01:51 [ERROR]      Stack Trace:
    09:01:51 [ERROR]      java.lang.NoSuchFieldError: bound
    09:01:51 [ERROR]       at com.google.errorprone.bugpatterns.TypeParameterUnusedInFormals.matchMethod(TypeParameterUnusedInFormals.java:73)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:890)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitMethod(ErrorProneScanner.java:146)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:916)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.Scanner.scan(Scanner.java:83)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.Scanner.scan(Scanner.java:43)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:90)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.visitClass(TreeScanner.java:187)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:588)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:146)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:823)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:82)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.Scanner.scan(Scanner.java:83)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.Scanner.scan(Scanner.java:43)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.scan(TreeScanner.java:105)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.scanAndReduce(TreeScanner.java:113)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreeScanner.visitCompilationUnit(TreeScanner.java:144)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:603)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScanner.visitCompilationUnit(ErrorProneScanner.java:146)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:603)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.Scanner.scan(Scanner.java:65)
    09:01:51 [ERROR]       at com.google.errorprone.scanner.ErrorProneScannerTransformer.apply(ErrorProneScannerTransformer.java:43)
    09:01:51 [ERROR]       at com.google.errorprone.ErrorProneAnalyzer.finished(ErrorProneAnalyzer.java:151)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1423)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1370)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:959)
    09:01:51 [ERROR]       at jdk.compiler/com.sun.
    Elena Felder
    @elefeint
    sorry, missed this message. I think gitter forgot to send summaries
    although this does answer the question I came to gitter to answer... You are releasing Hoxton SR?
    Mike Eltsufin
    @meltsufin
    @spencergibb Are you doing the release today? We have a critical issue with our Trace integration due to some breakage when upgrading to Sleuth 2.2.3. Can we hold the release a bit?
    Elena Felder
    @elefeint
    It looks like @OlgaMaciaszek is doing the releasew
    Spencer Gibb
    @spencergibb
    It can wait, we haven't started
    @meltsufin how long do you need?
    Mike Eltsufin
    @meltsufin
    we might need a new release of zipkin-gcp
    Spencer Gibb
    @spencergibb
    I am almost positive adrian is done for the night, so we'll hold off until tomorrow
    Mike Eltsufin
    @meltsufin
    is that ok by you all?
    Spencer Gibb
    @spencergibb
    not a problem
    Mike Eltsufin
    @meltsufin
    ok thanks!!
    we'll try to figure out all of the issues before tomorrow :)
    Spencer Gibb
    @spencergibb
    a PR to zipkin-gcp would probably speed things along for adrian as well
    Mike Eltsufin
    @meltsufin
    we're working on it. unfortunately there might be more than one issue there. we'll keep you posted
    Mike Eltsufin
    @meltsufin
    We figured it out. Now we just need the PR to be merged zipkin-gcp re-released.
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    @elefeint, @spencergibb is doing it; We were just reviewing the builds together and I've across that
    Piyush Garg
    @piyushpcegarg
    Can anyone please answer below question? I am also struggling with same problem.
    Even I want to fetch subcollection document by ID. Even I want a way to fetch till any level of subcollection because I am using 4-5 level of subcollection in firestore.
    https://stackoverflow.com/questions/61839619/how-can-i-retrieve-a-subcollection-in-firestore-with-spring-framework
    dmitry-s
    @dmitry-s
    @piyushpcegarg I think it doesn't work because you are using a field of type Flux in your entity class.
    Flux<Listing> listings;
    Try using List instead.
    Elena Felder
    @elefeint
    @spencergibb We think we resolved all issues
    So it should be safe to release
    Spencer Gibb
    @spencergibb
    @elefeint and @meltsufin master failing with
    org.springframework.cloud.gcp.security.firebase.FirebaseJwtTokenDecoderTests.invalidIssuerTests
     Error Details
    
    Expecting:
     <"An error occurred while attempting to decode the Jwt: This iss claim is not equal to the configured issuer">
    to start with:
     <"An error occurred while attempting to decode the Jwt: The iss claim is not valid">
    Mike Eltsufin
    @meltsufin
    Looking...
    Spencer Gibb
    @spencergibb
    we just rescheduled to tuesday next week for another project
    Mike Eltsufin
    @meltsufin
    ok we got some time then. thanks!
    Spencer Gibb
    @spencergibb
    yup
    Elena Felder
    @elefeint
    @spencergibb What version of spring-security are you running the build with? This message was updated in spring-security-oauth2-jose-5.3.0.RELEASE
    when we build just spring-cloud-gcp, we have org.springframework.security:spring-security-oauth2-jose:jar:5.3.2.RELEASE
    Spencer Gibb
    @spencergibb
    we don't manage spring security. I'm sure boot does
    Elena Felder
    @elefeint
    can you look at the failing build output to check the version?
    or paste the link to the jenkins job; I don't know if I have access but I'd try
    Piyush Garg
    @piyushpcegarg

    @piyushpcegarg I think it doesn't work because you are using a field of type Flux in your entity class.
    Flux<Listing> listings;

    @dmitry-s , no I already tried with List. It would be very helpful if spring-cloud-gcp team can provide an example to deal with subcollections (with n level). Because lot of people are facing issues while using subcollection but there is no document available around it.

    Daniel Zou
    @dzou
    Hey @spencergibb - We just pushed a fix for the jwt tests, is the build looking better now?
    Spencer Gibb
    @spencergibb
    let me check @dzou
    yup
    Daniel Zou
    @dzou
    Great, thank you !
    Spencer Gibb
    @spencergibb
    @meltsufin or @elefeint are you around?
    or @dzou ?
    https://github.com/spring-cloud/spring-cloud-gcp/pull/2264/files has broken the release of Hoxton.SR5. There is no Ivyland release and no 3.1.0.RELEASE of spring-cloud-stream-binder-test
    Spencer Gibb
    @spencergibb
    I updated that but the reliance on 3.0.0.snapshot of build tools is now causing problems
    Spencer Gibb
    @spencergibb
    reverted change to use 3.0.0 checkstyle
    Spencer Gibb
    @spencergibb
    samples broken now :-(
    Elena Felder
    @elefeint
    We don't need to rely on the snapshot, but some version of build tools is necessary for our samples
    otherwise the samples have no way of getting spring-cloud checkstyle
    Piyush Garg
    @piyushpcegarg
    @meltsufin , @dmitry-s or anyone else who has any idea about fetching documents from subcollection please answer below question:
    https://stackoverflow.com/questions/62043573/how-to-fetch-documents-from-subcollection-in-firestore-using-spring-data
    Marcin Grzejszczak
    @marcingrzejszczak
    Yo can some one approve this PR - spring-cloud/spring-cloud-gcp#2400 we can't release without it
    Marcin Grzejszczak
    @marcingrzejszczak
    @/all ping ^^
    Marcin Grzejszczak
    @marcingrzejszczak
    We've moved past that one