by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    dmitry-s
    @dmitry-s
    @piyushpcegarg I think it doesn't work because you are using a field of type Flux in your entity class.
    Flux<Listing> listings;
    Try using List instead.
    Elena Felder
    @elefeint
    @spencergibb We think we resolved all issues
    So it should be safe to release
    Spencer Gibb
    @spencergibb
    @elefeint and @meltsufin master failing with
    org.springframework.cloud.gcp.security.firebase.FirebaseJwtTokenDecoderTests.invalidIssuerTests
     Error Details
    
    Expecting:
     <"An error occurred while attempting to decode the Jwt: This iss claim is not equal to the configured issuer">
    to start with:
     <"An error occurred while attempting to decode the Jwt: The iss claim is not valid">
    Mike Eltsufin
    @meltsufin
    Looking...
    Spencer Gibb
    @spencergibb
    we just rescheduled to tuesday next week for another project
    Mike Eltsufin
    @meltsufin
    ok we got some time then. thanks!
    Spencer Gibb
    @spencergibb
    yup
    Elena Felder
    @elefeint
    @spencergibb What version of spring-security are you running the build with? This message was updated in spring-security-oauth2-jose-5.3.0.RELEASE
    when we build just spring-cloud-gcp, we have org.springframework.security:spring-security-oauth2-jose:jar:5.3.2.RELEASE
    Spencer Gibb
    @spencergibb
    we don't manage spring security. I'm sure boot does
    Elena Felder
    @elefeint
    can you look at the failing build output to check the version?
    or paste the link to the jenkins job; I don't know if I have access but I'd try
    Piyush Garg
    @piyushpcegarg

    @piyushpcegarg I think it doesn't work because you are using a field of type Flux in your entity class.
    Flux<Listing> listings;

    @dmitry-s , no I already tried with List. It would be very helpful if spring-cloud-gcp team can provide an example to deal with subcollections (with n level). Because lot of people are facing issues while using subcollection but there is no document available around it.

    Daniel Zou
    @dzou
    Hey @spencergibb - We just pushed a fix for the jwt tests, is the build looking better now?
    Spencer Gibb
    @spencergibb
    let me check @dzou
    yup
    Daniel Zou
    @dzou
    Great, thank you !
    Spencer Gibb
    @spencergibb
    @meltsufin or @elefeint are you around?
    or @dzou ?
    https://github.com/spring-cloud/spring-cloud-gcp/pull/2264/files has broken the release of Hoxton.SR5. There is no Ivyland release and no 3.1.0.RELEASE of spring-cloud-stream-binder-test
    Spencer Gibb
    @spencergibb
    I updated that but the reliance on 3.0.0.snapshot of build tools is now causing problems
    Spencer Gibb
    @spencergibb
    reverted change to use 3.0.0 checkstyle
    Spencer Gibb
    @spencergibb
    samples broken now :-(
    Elena Felder
    @elefeint
    We don't need to rely on the snapshot, but some version of build tools is necessary for our samples
    otherwise the samples have no way of getting spring-cloud checkstyle
    Piyush Garg
    @piyushpcegarg
    @meltsufin , @dmitry-s or anyone else who has any idea about fetching documents from subcollection please answer below question:
    https://stackoverflow.com/questions/62043573/how-to-fetch-documents-from-subcollection-in-firestore-using-spring-data
    Marcin Grzejszczak
    @marcingrzejszczak
    Yo can some one approve this PR - spring-cloud/spring-cloud-gcp#2400 we can't release without it
    Marcin Grzejszczak
    @marcingrzejszczak
    @/all ping ^^
    Marcin Grzejszczak
    @marcingrzejszczak
    We've moved past that one
    ther's another problem
    15:32:362020-05-29 13:28:41.4353 min 54 s    │ spring-cloud-gcp │ BuildProjectReleaseTask │ Build the project            │ FAILURE   │ java.lang.Throwable: File [..../spring-cloud-gcp/docs/target/generated-docs/reference/html/firestore.html] contains a tag that wasn't resolved properly ║
    the firestore.adoc renders a unresolved tag
    Elena Felder
    @elefeint
    can you paste the full message?
    Marcin Grzejszczak
    @marcingrzejszczak
    that's from the building process
    after bumping the versions to GA and ubilding the docs ./mvnw clean install -Pdocs -pl docs we're getting unresolved tags in the html
    you can search for the word unresolved in the hrml
    Elena Felder
    @elefeint
    I can't reproduce on master; docs build for me. Which versions were bumped?
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    We're releasing Hoxton: spring-cloud-gcp => 1.2.3.RELEASE
    Daniel Zou
    @dzou
    I'll try to reproduce
    What does the error mean generally? There's some syntax error with the asciidocs?
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    It usually means you reference a file in the docs that is not there in the project
    Daniel Zou
    @dzou
    Ahh ok, I see
    Ok i think i know what the issue is, i'll send out a PR in a few mins
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    when you text search the generated html files by unresolved you should be able to find out what is causing the issue
    Daniel Zou
    @dzou
    Gotcha, many thanks
    Daniel Zou
    @dzou
    @OlgaMaciaszek - Ok I think this should do it: spring-cloud/spring-cloud-gcp#2401
    Can someone approve and I'll merge it in
    Thanks @elefeint ! Let me know if the fix worked or if there's other issues.
    Olga Maciaszek-Sharma
    @OlgaMaciaszek
    Thanks. We're rerunning the releaser job