Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Elena Felder
    @elefeint
    We had some excellent external contributions this release. We for sure want to mention the Micrometer autoconfiguration...
    @spencergibb when are you publishing it?
    we have some power outages on east coast
    Spencer Gibb
    @spencergibb
    I'll add whatever you give me @elefeint
    Elena Felder
    @elefeint
    This release features many excellent community contributions:
    * New Spring Cloud GCP starter, `spring-cloud-gcp-starter-metrics`, configures Micrometer Stackdriver to automatically pick up project ID and credentials (thanks to \@eddumelendez).
    * Additional operations for managing secret versions on `SecretManagerTemplate` (thanks to \@kioie)
    * Additional GCS Spring Integration file filters `GcsAcceptModifiedAfterFileListFilter` and `GcsDiscardRecentModifiedFileListFilter` (thanks to \@hosainnet)
    Sorry, I was not sure what format you use -- can the three community contributors be linked? https://github.com/hosainnet, https://github.com/kioie and https://github.com/eddumelendez
    Elena Felder
    @elefeint
    Sorry, @spencergibb , I forgot to at-mention you
    Marcin Grzejszczak
    @marcingrzejszczak
    Yo spring-cloud/spring-cloud-gcp#2481 can you please update your master branch version to 1.2.5.BUILD-SNAPSHOT ?
    dmitry-s
    @dmitry-s
    @marcingrzejszczak sure, I'll handle this
    Marcin Grzejszczak
    @marcingrzejszczak
    :+1:
    Mike Eltsufin
    @meltsufin
    @artembilan Can some help us update the project learn page (https://spring.io/projects/spring-cloud-gcp#learn) with 1.2.4 release and the associated API docs link (https://googleapis.dev/java/spring-cloud-gcp/1.2.4.RELEASE/index.html )?
    Thanks!
    27 replies
    Marcin Grzejszczak
    @marcingrzejszczak
    We've migrated all the docs to the docs.spring.io server
    Spencer Gibb
    @spencergibb
    @meltsufin @elefeint @dzou if you haven't seen the new boot config loading https://spring.io/blog/2020/08/14/config-file-processing-in-spring-boot-2-4 Anything that implements PropertySourceLocator could be retargeted to the new API
    Elena Felder
    @elefeint
    @spencergibb Thank you! We've seen the blog post, and it really helps, since @dzou has been upgrading this week in the new repo. Will there be additional changes in future milestones to make bootstrap configuration unnecessary? I am trying to figure out whether I should be fixing pubsub Spring Cloud Bus starter now, or wait for more changes.
    Spencer Gibb
    @spencergibb
    In ilford (2020.0) bootstrap will be opt-in. If you require it, there is a new spring-cloud-starter-bootstrap dependency you can require.
    Elena Felder
    @elefeint
    opt-in is the spring.config.use-legacy-processing?
    Spencer Gibb
    @spencergibb
    It can be via that property (but since it's bootstrap it would need to be a cli arg, system prop or env var) or the new starter
    Elena Felder
    @elefeint
    Got it, thank you!
    Marcin Grzejszczak
    @marcingrzejszczak
    yo, I've closed the sleuth issue related to executor services and the async span. Can you please check how things work with the latest snapshots? (spring-cloud/spring-cloud-sleuth#1465)
    Ray Tsang
    @saturnism
    👋
    Elena Felder
    @elefeint
    Thank you! I'll test it today.
    Elena Felder
    @elefeint
    @marcingrzejszczak Well, the part that propagates scheduler bean names works great. But we have not integrated with 3.0.0 before, so I've ran into a number of issues -- I'll come up with coherent questions on the ones I resolved tomorrow, but the one I am stuck on is -- should Sleuth provide a default SpanHandler, or should we write one in Spring Cloud GCP?
    Marcin Grzejszczak
    @marcingrzejszczak
    Hmm i haven't seen such an issue before. Can you show me the stacktrace?
    Elena Felder
    @elefeint
    no issue, just traces not showing up -- the sampling works, but because SpanHandler bean is needed to bridge from instrumentation to reporter, the traces don't make it to reporter. It's configured for Zipkin here: https://github.com/spring-cloud/spring-cloud-sleuth/blob/bd149ce4a7c2154fe8526394d14b6ab89addd62e/spring-cloud-sleuth-zipkin/src/main/java/org/springframework/cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java#L179 , I am guessing we need to do the same for Stackdriver
    I'll look more into it today; don't worry about it yet
    need to read the comprehensive documentation Adrian usually writes for changes. In "hours of troubleshooting can save minutes of reading documentation" situation, clearly.
    Marcin Grzejszczak
    @marcingrzejszczak
    :D
    Kriti
    @Kriti84252554_twitter
    Hi, is there any sample project for generating tokens from google cloud APIs? The userCredentials are stored in GCP
    Mike Eltsufin
    @meltsufin
    @Kriti84252554_twitter Can you clarify what kind of tokens you're looking to generate and for what kind of use case?
    Kriti
    @Kriti84252554_twitter
    Hi @meltsufin I want to validate my users against GCP IAM using spring boot application
    but I do not want to re-direct them to google SSO page
    Mike Eltsufin
    @meltsufin
    How do your users provide the credentials to your app?
    Also, maybe this page is relevant: https://cloud.google.com/iam/docs/testing-permissions.
    Daniel Zou
    @dzou
    @spencergibb -- Hey Spencer, what's your recommendation for how to move forward on this issue: spring-cloud/spring-cloud-config#1695 Our pub/sub integration using the config server is affected by this too. Curious what your recommendations are for integrators; I can see users setting the legacy-processing setting on an individual level, but what are recommended practices for library integrators to get things working out of the box? @ttomsu has some more context too.
    Spencer Gibb
    @spencergibb
    it's a documentation issue
    if bootstrap is required there is a new spring-cloud-starter-bootstrap to enable it by default. We want to move to the spring.config.import style
    Daniel Zou
    @dzou
    Ah I see, thank you for clarifying!
    Spencer Gibb
    @spencergibb
    @dzou made some comments there, you'll need to set a property or include a new starter. But we are planning on moving to the new import as the default way of working.
    Travis Tomsu
    @ttomsu
    Hmmm... I added that spring.cloud.bootstrap.enabled=true value and I'm still not seeing the value in /actuator/env
    @spencergibb ^
    Spencer Gibb
    @spencergibb
    @ttomsu where did you add the property?
    Travis Tomsu
    @ttomsu
    ahh, I think I got it with both the spring-cloud-starter-bootstrap and the property set
    Spencer Gibb
    @spencergibb
    shouldn't be needed. Where did you add the property?
    Travis Tomsu
    @ttomsu
    application.properties
    Spencer Gibb
    @spencergibb
    it can't be in application.properties because that is too late. Either needs to be a cli arg, system property or env var.
    the starter on its own should work
    Travis Tomsu
    @ttomsu
    I see - I recall reading something about bootstrap.yml - is that the same thing?
    (apologies for silly questions - dusting off the cobwebs)