Hi All,
I am relatively new to sleuth framework.. I have an usecase where traceId needs to be sent back in the response header. I was hoping to achieve the same using annotations or configuration. When I had searched they were achieved by adding filters (also found few old threads where they had mentioned that sending traceId in the response header has been removed due to potential security concern). In the latest implementation are there any configuration/annotations for the same or I would have to write a trace filter? Any help on this is appreciated
I am relatively new to sleuth framework.. I have an usecase where traceId needs to be sent back in the response header. I was hoping to achieve the same using annotations or configuration. When I had searched they were achieved by adding filters (also found few old threads where they had mentioned that sending traceId in the response header has been removed due to potential security concern). In the latest implementation are there any configuration/annotations for the same or I would have to write a trace filter? Any help on this is appreciated
the tracing system does not mutate the response at the moment, so it can't write response headers
Hi
What's the difference between
In the sleuth properties appendix its given with
https://cloud.spring.io/spring-cloud-sleuth/reference/html/appendix.html
What's the difference between
spring.sleuth.remote-fields vs spring.sleuth.baggage.remote-fieldsIn the sleuth properties appendix its given with
baggage. whereas in the documentation withouthttps://cloud.spring.io/spring-cloud-sleuth/reference/html/appendix.html
Which of these is correct
@saisuryakat if using sleuth v3 the latter https://github.com/spring-cloud/spring-cloud-sleuth/wiki/Spring-Cloud-Sleuth-3.0-Migration-Guide#property-names-1
the link you are pointing to is the version 3 docs
ah I see what you are saying
thanks. can you do a pull request to fix this?
but I'm having trouble making baggage fields work
Is there any sample repo present for reference
I'm confused esp whether to just define the headers in application.yml and set the values in controller or to config brave(as shown in brave docs)
brave is used for other things even spring 2.5
sleuth has things built-in so easier to use properties than javaconfig for the same result
I'm changing example project for you hold a sec
Are there any working examples of integrating a spring boot project with AWS X-Ray? A quick googling say no. Do I just import the deps (spring-cloud-starter-zipkin/io.zipkin.aws:zipkin-reporter-xray-udp) and override the
ZipkinAutoConfiguration.REPORTER_BEAN_NAME with my own XRayUDPReporter bean? There doesn't seem to be any auto-config for the Zipkin X-Ray but I'm happy to be wrong.
@LtTempletonPeck so there's no auto-config I'm aware of (ex if so it would be in spring-cloud-aws and I think we'd have heard of it)
there's not much auto-config for xray anyway as the daemon is localhost, but if you wanted to have an auto-config I suspect an issue on spring-cloud-aws would make most sense as something similar to this exists in spring-cloud-gcp
1 reply
Hi all, I'd be glad if you could have a look at my SO question:
https://stackoverflow.com/questions/62172238/how-to-init-a-default-trace-context-with-span-in-controller-when-using-springboo
Thanks!
https://stackoverflow.com/questions/62172238/how-to-init-a-default-trace-context-with-span-in-controller-when-using-springboo
Thanks!
My spring webflux based boot application seems to post traces to zipkin properly but neither the logs nor the controller methods are getting the trace and span ids. It’s a pretty basic configuration with sleuth starter and zipkin starter. The trace web filter is getting invoked correctly and recording the initial span. I realize this is pretty vague but am wondering if I’m missing something basic. What information should I provide here if this is not obvious.
Hi I now have traces being sent to X-Ray but the names that display in the X-Ray console for traces are not being correctly set for Feign and Spring Cloud Stream Kafka. For Feign they are using the http method, here is an example the name is get but the annotations.http_path has the path:
"subsegments": [
{
"id": "f945f28acb910a16",
"name": "get",
"start_time": 1591611761.254306,
"end_time": 1591611761.583249,
"http": {
"request": {
"method": "GET"
}
},
"annotations": {
"http_path": "/device/v1",
"operation": "get"
},
"namespace": "remote"
},
...For Spring Cloud Stream Kafka I was hoping it would resolve the destination of the channel but at the moment it is using the binder as the name and the channel is in the annotations. It doesnt seem to have resolved the destination.
{
"id": "aeab33b8a6b2c004",
"name": "kafka",
"start_time": 1591611763.963422,
"end_time": 1591611763.968351,
"annotations": {
"channel": "output"
},
"namespace": "remote"
}Do you know if its possible to override the name? So far I've tried @SpanName and @PostMapping(name = "my-name" but neither work.
@LtTempletonPeck I think feign is using defaults. It could possibly be made to implement HttpRequest.route() as UriTemplate https://github.com/OpenFeign/feign/blob/835a96380e3212afb2c882aa54e463eea4c20b32/core/src/main/java/feign/template/UriTemplate.java#L28 you could open an issue for that. I haven't worked on feign for years but I initially envisioned MethodMetadata.configKey as the span name hystrix name etc also. But anyway HttpRequest.route() would work better as the template value than the path as it won't lead to unlimited span names. OTOH if x-ray is ok with unlimited span names, path could be used instead (possibly in the data conversion) cc @anuraaga
2 replies
I don't know the answer to the other question so will punt that one :D
Don't know much about feign, but if using zipkin-aws, remote service names need to be set to have proper names in x-ray segments. Maybe it's not set? https://github.com/openzipkin/zipkin-aws/blob/master/storage-xray-udp/src/main/java/zipkin2/storage/xray_udp/UDPMessageEncoder.java#L75
2 replies
Hello,
I m trying to propagate some extra-information within all log records (in my current service and client services) using spring-cloud-sleuth 2.2.1.RELEASE, but facing a problem when trying to add local-keys to SLF4J's MDC. (it works perfectly with propagation-keys for remote calls). This is my configuration:
spring:
sleuth:
propagation-keys:
- remote-key
local-keys:
- local-key
propagation:
tag:
whitelisted-keys:
- remote-key
- local-key
log:
slf4j:
whitelisted-mdc-keys:
- remote-key
- local-keyI'm i missing some thing? or log.slf4j.whitelisted-mdc-keys is not intended to work with local-keys?
Thank you in advance.
I guess this is a job for brave, but I cannot find any documentation 👀
@dimi-nk https://cloud.spring.io/spring-cloud-sleuth/reference/html/#sending-spans-to-zipkin says it is async, but doesn't copy the properties defined into asciidoc
to see properties you can look at the appendix here https://cloud.spring.io/spring-cloud-sleuth/reference/html/appendix.html
for example, the default amount of time to buffer spans is 1 second spring.zipkin.message-timeout