Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 05:35
    lanmingle commented #1955
  • Jun 11 14:07
    lanmingle commented #1955
  • Jun 10 15:31

    marcingrzejszczak on 3.1.x

    Updating Build to 3.1.0-SNAPSHOT (compare)

  • Jun 10 15:31

    marcingrzejszczak on 3.1.x

    Updating Build to 3.1.0 (compare)

  • Jun 10 15:17

    marcingrzejszczak on 3.1.x

    Made tests less brittle (compare)

  • Jun 10 13:53

    marcingrzejszczak on 3.1.x

    Polish (compare)

  • Jun 10 13:46

    marcingrzejszczak on cassandra

    (compare)

  • Jun 10 13:46

    marcingrzejszczak on 3.1.x

    Adds Cassandra support (#1974) … (compare)

  • Jun 10 13:46
    marcingrzejszczak closed #1974
  • Jun 10 13:35
    marcingrzejszczak synchronize #1974
  • Jun 10 13:35

    marcingrzejszczak on cassandra

    Update TraceReactiveSessionBean… (compare)

  • Jun 10 13:35
    marcingrzejszczak synchronize #1974
  • Jun 10 13:35

    marcingrzejszczak on cassandra

    Update TraceCqlSessionBeanPostP… (compare)

  • Jun 10 13:34
    marcingrzejszczak opened #1974
  • Jun 10 13:34
    marcingrzejszczak milestoned #1974
  • Jun 10 13:34
    marcingrzejszczak labeled #1974
  • Jun 10 13:33

    marcingrzejszczak on cassandra

    Polish (compare)

  • Jun 10 10:01

    mp911de on cassandra

    Polishing Reduce class visibil… (compare)

  • Jun 10 09:31

    mp911de on cassandra

    Add tracing support for Reactiv… Add missing overrides to Assert… (compare)

  • Jun 10 08:14

    marcingrzejszczak on 3.1.x

    simplify ON_EACH reactor instru… Merge remote-tracking branch 'o… (compare)

Marcin Grzejszczak
@marcingrzejszczak
MutableSpan is the span before sending to zipkin. Check its name and then you'll find the webclient one
Deserttown
@desertTown
I see, many thanks
Charly
@nekperu15739
Hi people, question, since aws was moved out of spring-cloud, we loose the sleuth instrumentation on messaging, anyone have a work arround to solved?
Charly
@nekperu15739
Marcin Grzejszczak
@marcingrzejszczak
responded
mr-nothing
@mr-nothing
Hello once again, guys :)
I'm trying to find if there is any peace of code in spring-sleuth which I can use to modify spans or add tags to these spans if they belong to jms part of my application? What I'm trying to do is to describe spans in more details since our application have pretty big number of jms integration so we can better understand which trace belong to which integration. Maybe there is some mechanism to propogate jms header info to span tags or maybe there is nothing and I need to create aop advice to handle these cases.
Thanks in advance for any information and your help.
1 reply
Koja Z
@kojaz_gitlab
For propagating custom fields, is there a way to propagate some fields only in baggage
and some fields in both baggage and http headers. For example:
baggage: userId=123,legacyTraceId=abc
legacyTraceId: abc
Marcin Grzejszczak
@marcingrzejszczak
also afiar in Sleuth 3.x we don't have the baggage header anymore
anything that is set as baggage will be propagated as it is
Fizii Q
@qfizii_gitlab

just set the legacyTraceId as a remote-field [to propagate the field as its own http header]

That works with 2020.0.0-M5 but not with any newer releases including 2020.0.3.
Here is an example project: https://gitlab.com/qfizii/sleuth-demo

2 replies

also afiar in Sleuth 3.x we don't have the baggage header anymore

How do you mean? Testing with spring-cloud 2020.0.3 (aka sleuth 3.0.3), I still see baggage http header

SergeySt
@SergeySt
Hi guys,
Question: Is it possible to make work sleuth with Datadog agent. Currently, I use dd-java-agent in my project to talk to dd-agent. is it possible to send traces directly from sleuth there or make work dd-java-agent and sleuth together?
1 reply
Christos Tsagkournis
@ctsag
hey guys, I'm trying to use Sleuth and datasource-proxy on a Spring Boot project and I'm having a bit of trouble. I can use datasource-proxy-spring-boot-starter with no issue, and the Sleuth documentation mentions that the datasource-proxy integration is directly ported from datasource-proxy-spring-boot-starter, so I'm a bit confused that there's trouble. What I've done so far is include this on my pom.xml
    <dependencies>
      <dependency>
        <groupId>org.springframework.cloud</groupId>
        <artifactId>spring-cloud-dependencies</artifactId>
        <version>${spring-cloud.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <dependencies>

    <dependency>
      <groupId>org.springframework.cloud</groupId>
      <artifactId>spring-cloud-starter-sleuth</artifactId>
    </dependency>

    <dependency>
      <groupId>net.ttddyy</groupId>
      <artifactId>datasource-proxy</artifactId>
      <version>1.7</version>
      <scope>runtime</scope>
    </dependency>

    [...]

  </dependencies>
and these on my applications.properties
spring.sleuth.jdbc.datasource-proxy.enabled = true spring.sleuth.jdbc.datasource-proxy.query.enable-logging = true spring.sleuth.jdbc.datasource-proxy.query.log-level = info
Marcin Grzejszczak
@marcingrzejszczak
are you using Sleuth 3.1.x snapshots ?
we do support it currently in Sleuth 3.1.0-SNAPSHOT which is the 2021.0.0-SNAPSHOT release train
Christos Tsagkournis
@ctsag
I'm using 2020.0.3
so it won't work
it will be supported in the upcoming 3.1.0 release
Christos Tsagkournis
@ctsag
hmmm, still no luck with the 2021.0.0-SNAPSHOT
I can see Sleuth doing its thing with other log lines, but nothing related to jdbc, datasource-proxy etc
Marcin Grzejszczak
@marcingrzejszczak
Please check the provided sample
Christos Tsagkournis
@ctsag
wait, I set the root logger to trace and I see this line
2021-06-07 15:32:25.737 DEBUG [,ba54d96ce7c24aa2,c8afaff204e58ae1] 12956 --- [io-50002-exec-2] n.t.d.l.l.SLF4JQueryLoggingListener : Name:dataSource, Connection:4, Time:7, Success:True Type:Prepared, Batch:False, QuerySize:1, BatchSize:0 Query:["select timezone0_.timezone_id as timezone1_13_0_, timezone0_.display as display2_13_0_, timezone0_.name as name3_13_0_, timezone0_.status as status4_13_0_ from ttimezone timezone0_ where timezone0_.timezone_id=?"] Params:[(1231)]
which is great, but, I've set spring.sleuth.jdbc.datasource-proxy.query.log-level = info so I would have expected the log level for it to be info, not debug
Marcin Grzejszczak
@marcingrzejszczak
that might be a bug then - let me double chec
spring.sleuth.jdbc.datasource-proxy.query.log-level=INFO
that should work
can you put a breakpoint at DataSourceProxyBuilderCustomizer#customize(ProxyDataSourceBuilder proxyDataSourceBuilder) and double check that this.datasourceProxy.getQuery().getLogLevel() is INFO ?
Christos Tsagkournis
@ctsag
doesn't change anything, let me add the breakpoint
no, it's DEBUG, despite the property being set to INFO
Christos Tsagkournis
@ctsag
I suppose a temp workaround is logging.level.net.ttddyy.dsproxy.listener.logging = DEBUG
2021.0.0-SNAPSHOT works fine after that
thanks for the help Marcin
Marcin Grzejszczak
@marcingrzejszczak
can you file an issue? Cause that's a bug
Christos Tsagkournis
@ctsag
hey Marcin, sry, just saw your comment, yes, I'll start an issue
I had another problem, more serious this time. I ran my test suite and after the first 10-15 tests (around 50 db queries), I started getting 30 second freezes, despite the fact that the datasource-proxy log lines reported timings of <10ms. I switched back to datasource-proxy-spring-boot-starter 1.7.1 and the problem was gone. Switched back to Sleuth 2021.0.0-SNAPSHOT and the problem came back. Hard to pin point or even describe the issue, but it was there for me. I'll give it another shot when the 3.1.0 release comes out.
4 replies
Christos Tsagkournis
@ctsag
Steven Shi
@terrificsoysauce
Does anyone know how to explicitly abandon a span (a span created by Sleuth's auto-instrumentation)? I tried brave.Span.abandon() but Sleuth still reports it.
Steven Shi
@terrificsoysauce
One workaround is to e.g. annotate the span with "abandon" and subsequently filter it out in SpanHandler, i.e. return false if span is annotated with "abandon".
Bhavesh Mistry
@bmistry13
@marcingrzejszczak
2021-06-10 13:04:51.356 ERROR [core-service,ca1b2c2bc4a947d3046b95ddc9175e07,fc0f460c27575316] 1 --- [task-scheduler-3] o.s.integration.handler.LoggingHandler : java.lang.NoSuchFieldError: LIFTER
at org.springframework.cloud.sleuth.instrument.reactor.ReactorHooksHelper.getLifterName(ReactorHooksHelper.java:171)
at org.springframework.cloud.sleuth.instrument.reactor.ReactorHooksHelper.isTraceContextPropagator(ReactorHooksHelper.java:175)
at org.springframework.cloud.sleuth.instrument.reactor.ReactorHooksHelper.shouldDecorate(ReactorHooksHelper.java:121)
at reactor.core.publisher.Operators$LiftFunction.apply(Operators.java:2544)
at reactor.core.publisher.Operators$LiftFunction.apply(Operators.java:2505)
at reactor.core.publisher.Mono.onAssembly(Mono.java:4890)
Bhavesh Mistry
@bmistry13
I am getting above error any specific version I need to use
Marcin Grzejszczak
@marcingrzejszczak
Please upgrade boot to the latest version
Andrew Flower
@rewolf
Good day, I'd like to know if it's safe to use Tracer#currentSpan() in an Aspect within a WebFlux application? (specifically, when advising an @ExceptionHandler method)
Marcin Grzejszczak
@marcingrzejszczak
Should be fine