These are chat archives for spring-cloud/spring-cloud

17th
Apr 2015
wojtkiewicz
@wojtkiewicz
Apr 17 2015 10:03
I applied your suggestions here wojtkiewicz/spring-cloud-config@480fa41
Dave Syer
@dsyer
Apr 17 2015 10:05
Looks good. Is it in the PR now?
wojtkiewicz
@wojtkiewicz
Apr 17 2015 10:05
Had some trouble with default application name and default profile because there were no such fields in ConfigServerProperties
I think so
Dave Syer
@dsyer
Apr 17 2015 10:05
I'll see if I can tidy that up. They must be in the *Repository implementations?
wojtkiewicz
@wojtkiewicz
Apr 17 2015 10:06
I added those to properties and set defaults to "default". I can change that if there is a better option.
Dave Syer
@dsyer
Apr 17 2015 10:07
"application" is better for the application name
wojtkiewicz
@wojtkiewicz
Apr 17 2015 10:10
profile should be "default"?
Dave Syer
@dsyer
Apr 17 2015 10:11
Yes
wojtkiewicz
@wojtkiewicz
Apr 17 2015 10:11
Ok, is there anything else you want me to change?
Dave Syer
@dsyer
Apr 17 2015 10:44
You could add Java doc and author tags?
And confirm you have filled in the CLA (link in README)
wojtkiewicz
@wojtkiewicz
Apr 17 2015 11:14
Ok
wojtkiewicz
@wojtkiewicz
Apr 17 2015 12:58
@author tags and javadocs added spring-cloud/spring-cloud-config@3a3e27e
Dave Syer
@dsyer
Apr 17 2015 12:58
Thanks
Did you update the PR?
wojtkiewicz
@wojtkiewicz
Apr 17 2015 12:58
yes
we filled required CLA