These are chat archives for spring-cloud/spring-cloud

8th
Jul 2015
Collin Peters
@collinpeters
Jul 08 2015 06:03
I'm finding that Zuul is setting an x-forwarded-host of domain.com:80 instead of just domain.com. Is that correct? Just wondering if I have to strip the port off in my code or if it shouldn't be sending it
Dave Syer
@dsyer
Jul 08 2015 06:12
I never noticed that. We could change it. Are you sure Zuul is setting that header?
Collin Peters
@collinpeters
Jul 08 2015 06:14
I've been trying to debug that for a bit and I'm pretty sure. Though I haven't found the code that does it yet. In another use case I'm using Nginx to add the header and there is no port there (though that might be my config). In SimpleHostRoutingFilter I do see the headers param has x-forwarded-host as domain.com:80
Dave Syer
@dsyer
Jul 08 2015 13:16
@ryanjbaxter what problems are you seeing?
The sso demo app works for me
I built everything locally, but I hope some of it is trickling into repo.spring.io now
It could easily be changed to omit the host if 80 or 443
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:20
@dsyer same error i saw on June 30th
Dave Syer
@dsyer
Jul 08 2015 13:20
Then you need to get some new bits
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:21
which projects, spring-cloud-netflix?
Dave Syer
@dsyer
Jul 08 2015 13:21
I just deployed spring-cloud-security manually
Is it netflix stuff that's broken in your build?
I thought you said it was OAuth2
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:21
no spring-cloud-netflix builds fine
so you just deployed some new snapshots for spring-cloud-security?
Dave Syer
@dsyer
Jul 08 2015 13:23
Yes. I'm not sure if they were new though
I only deployed what is in master
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:26
so some of what was in spring-cloud-security has been moved to spring boot it looks like right?
Dave Syer
@dsyer
Jul 08 2015 13:26
Yes, most of it.
We are probably going to change the config prefix as well
security.oauth2.*
Haven't done that yet
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:27
what happened to OAuth2SsoConfigurerAdapter?
Dave Syer
@dsyer
Jul 08 2015 13:28
You don't need it any more
Just add @EnableOAuth2Sso to a WebSecurityConfigurerAdapter
Hello, gitter. Can you hear me?
Ryan Baxter
@ryanjbaxter
Jul 08 2015 13:30
i was using it to configure which endpoints in my app did not require authentication...
Dave Syer
@dsyer
Jul 08 2015 13:30
Sure. That's normally the role of a WebSecurityConfigurerAdapter right?
Look at the sso sample
Ryan Baxter
@ryanjbaxter
Jul 08 2015 14:22
i guess i should ask on the spring-boot channel
Dave Syer
@dsyer
Jul 08 2015 14:23
Hmm. Yeah. That is a known issue I think.
Ryan Baxter
@ryanjbaxter
Jul 08 2015 15:01
@dsyer do you mind if i submit the pull request without testing on the latest and greatest code? I had some a bunch of testing before but then stopped short of submitting the pull request bc we had to sign the CLA
Dave Syer
@dsyer
Jul 08 2015 15:16
Sure.
I probably won't merge it without the tests
Ryan Baxter
@ryanjbaxter
Jul 08 2015 15:16
there are unit tests
but getting your initial impressions would be good as well
Dave Syer
@dsyer
Jul 08 2015 15:18
OK