These are chat archives for spring-cloud/spring-cloud

10th
Jul 2015
Ryan Baxter
@ryanjbaxter
Jul 10 2015 14:03
@dsyer and @spencergibb for the interface idea mentioned in #423 do you envision always approximating the zone based on the host name and having different ways of approximating the zone based on that input? I am just wondering how many other ways you would be able to approximate the zone from the host name...
Spencer Gibb
@spencergibb
Jul 10 2015 14:24
@ryanjbaxter, not sure. Was just thinking out loud.
Ryan Baxter
@ryanjbaxter
Jul 10 2015 14:25
if there is more than one way of approximating the zone from the host name than I can see the inferface being useful but I can’t really see other ways of doing it
probably one of those situations where it is best to wait for someone to say they need it
Spencer Gibb
@spencergibb
Jul 10 2015 14:29
Yeah, I was thinking that someone might want to approximate zone, from something other than hostname or something. We can wait, NP.
Ryan Baxter
@ryanjbaxter
Jul 10 2015 14:31
yes I can imagine that as well, a solid use case would give a good base for some changes though. Right now in my use case the hostname actually works out pretty well :)
Ryan Baxter
@ryanjbaxter
Jul 10 2015 15:01
how can my fork be so many commits ahead of spring-cloud-netflix:master? https://github.com/spring-cloud/spring-cloud-netflix/compare/master...ryanjbaxter:master
it should just be 1 commit ahead at this point
#315 was merged into master right?
Dave Syer
@dsyer
Jul 10 2015 15:02
I cherry picked it onto 1.0.x
Ryan Baxter
@ryanjbaxter
Jul 10 2015 15:02
oh so its not in master yet?
Dave Syer
@dsyer
Jul 10 2015 15:02
I merged into master
So it's there, but probably not the same ID (hence the cherry pick)
Ryan Baxter
@ryanjbaxter
Jul 10 2015 15:03
ah so githubs compare is then confused?
Dave Syer
@dsyer
Jul 10 2015 15:05
Could be
Your best option is to rebase anything you have on top of 1.0.x (or master depending on what you are interested in).
Or simply throw away your branch
Ryan Baxter
@ryanjbaxter
Jul 10 2015 15:11
All set now
didnt realize you cherry picked that stuff
Dave Syer
@dsyer
Jul 10 2015 15:13
cool