These are chat archives for spring-cloud/spring-cloud

12th
Aug 2015
Aizhan Toregozhina
@atoregozh
Aug 12 2015 20:28
In the documentation when it talks about multiple git repos and setting patterns, it wasn't clear to me that setting a pattern as pattern: *data or pattern:* wouldn't work unless i wrap it in double quotes. Maybe you could clarify that in documentation?
Spencer Gibb
@spencergibb
Aug 12 2015 20:29
can you point me at what you’re looking at
Aizhan Toregozhina
@atoregozh
Aug 12 2015 20:30
@spencergibb the subchapter that talks about 'Git Backend'
In the above example, if {application} does not match to any of the patterns, it will use the default uri defined under "spring.cloud.config.server.git.uri". For the "simple" repository, the pattern is "simple" (i.e. it only matches one application). The pattern format is a comma-separated list of application names with wildcards.
pattern format could be clarified a bit
Spencer Gibb
@spencergibb
Aug 12 2015 20:31
yup, create an issue, PR’s welcome
Aizhan Toregozhina
@atoregozh
Aug 12 2015 20:34
ok will do. also, patterning based on {application} (spring. application.name) is cool. have you thought of patterning based off spring.profiles?
for example, we might want to have a separate repo per profile (e.g. dev environment) and not based on application service
that's prob a separate issue
Spencer Gibb
@spencergibb
Aug 12 2015 20:36
it follows the standard spring-boot configuration conventions, so appname-profile.{yaml|properties}
for the repos, yeah a separate issue
Aizhan Toregozhina
@atoregozh
Aug 12 2015 20:37
ok, will create 2 issues: 1) documentation clarification 2) enhancement
Aizhan Toregozhina
@atoregozh
Aug 12 2015 22:48
@spencergibb issues opened: spring-cloud/spring-cloud-config#213 , spring-cloud/spring-cloud-config#214