These are chat archives for spring-cloud/spring-cloud

9th
Oct 2015
Dave Syer
@dsyer
Oct 09 2015 05:54
looks like a bug in Spring Data Elasticsearch to me
turick
@turick
Oct 09 2015 17:26
hi all... has anybody had success integrating sleuth and zipkin to trace calls end-to-end through zuul and underlying microservices? documentation for sleuth is pretty thin, but i'm pointing my project to my zipkin server and running some of the sleuth samples from git, but nothing shows up in zipkin
Spencer Gibb
@spencergibb
Oct 09 2015 17:34
We did for the spring one keynote https://github.com/springone2gx2015/vehicle-fleet-demo/ and here is one that just came to my attention https://github.com/azwickey-pivotal/SpringTrader
Marcin Grzejszczak
@marcingrzejszczak
Oct 09 2015 17:45
@turick did you debug your solution to see if Sleuth filters are working for you?
Dave Syer
@dsyer
Oct 09 2015 17:54
Zuul uses hystrix so you need to stick to the default thread isolation for Spring Cloud
If you just use it out of the box it will not work with sleuth
The samples should work I would think though
Dave Syer
@dsyer
Oct 09 2015 18:16
Clarification: the Spring Cloud Zuul proxy uses hystrix OOTB. So it's that which works (because we nailed the thread isolation to SEMAPHORE which is not the default for hystrix on its own)
Matt Benson
@mbenson
Oct 09 2015 18:26
thanks @spencergibb
Spencer Gibb
@spencergibb
Oct 09 2015 18:28
NP, it was a pretty big change to feign support, so it didn’t surprise me that something slipped through. I added the clients attr so the tests wouldn’t have to classpath scan. And since they didn’t, I didn’t see it was broken :-)
good find
turick
@turick
Oct 09 2015 20:48
thanks for the info everybody. @dsyer - so you are saying that the default configuration OOTB for spring cloud zuul works with sleuth? i haven't dug too deep, but i implemented the SampleController that has all the /hi, /call, /async, etc endpoints. the only real configuration i did was 1) point my config file to my zipkin server 2) instantiate the AlwaysSampler bean, then basically copy over the SampleController/SampleBackground classes. The endpoints generate the traces and write the output to the browser, and i would have expected those calls to have shown up on zipkin, but they didn't.
@spencergibb that vehicle fleet demo looks pretty incredible. hopefully i can dissect it well enough to understand your implementation of sleuth
turick
@turick
Oct 09 2015 20:51
ya, that's the code i was using with the SampleController and SampleBackground classes, but didn't see any entries in zipkin
turick
@turick
Oct 09 2015 20:59
interesting, i just changed the spring.zipkin.host to a different vm that's not running zipkin, and get no errors... i turned debug logging on for sleuth and don't see any sleuth messages at all when the service starts up
when i hit the /call endpoint, i see a debug message: 2015-10-09 15:58:14.747 DEBUG 15028 --- [p-nio-80-exec-4] o.s.c.s.instrument.web.TraceWebAspect : Wrapping callable with span [MilliSpan(begin=1444424294642,
end=0, name=http/call, traceId=2a558f26-a8a8-4903-b756-d0c957269f09, parents=[], spanId=51b75eeb-5dba-43ac-9eb0-104e580600e0, remote=false, annotations={/http/
request/uri=http://localhost/call, /http/request/endpoint=/call, /http/request/method=GET, /http/request/headers/host=localhost, /http/request/headers/user-agen
t=Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0, /http/request/headers/accept=text/html,application/xhtml+xml,application/xml;q=0.9,
/
;q=0.8, /http/request/headers/accept-language=en-US,en;q=0.5, /http/request/headers/accept-encoding=gzip, deflate, /http/request/headers/cookie=SESSION=45b9f3
65-7d25-4d60-abe9-aff72fc693c1;, /http/request/headers/connection=keep-alive}, processId=null, timelineAnnotations=[])]
Spencer Gibb
@spencergibb
Oct 09 2015 21:01
My guess is a problem between app and zipkin
turick
@turick
Oct 09 2015 21:02
ok. i'm using the zipkin docker package to deploy zipkin, and i haven't done any real configuration on zipkin itself. but i would think if there were a problem connecting, my app would be complaining about it?
the only time i've seen a real error message on my app is when i added "http://"; to the beginning of my host variable in my config file, then i get some nice exceptions from ZipkinAutoConfiguration
Dave Syer
@dsyer
Oct 09 2015 21:13
there's a SampleController in the non-zipkin samples so I'm not sure I understand yet what the issue is (since AFAIK the zipksin samples all work)
turick
@turick
Oct 09 2015 21:18
ya, i'm not sure how to even start debugging this... i'll circle back around on Monday -- maybe fire up wireshark and see if there is any traffic at all going to my zipkin server