These are chat archives for spring-cloud/spring-cloud

7th
Nov 2015
Adrian Cole
@adriancole
Nov 07 2015 15:42
sleuth q: what does SpanAcquiredEvent mean?
does that mean it is a new trace?
Dave Syer
@dsyer
Nov 07 2015 15:43
Yes
Adrian Cole
@adriancole
Nov 07 2015 15:43
cool
Adrian Cole
@adriancole
Nov 07 2015 16:00
@dsyer @spencergibb this is a place-holder.. I'm going to shine up some things in brave so that implementing my comments aren't disgusting spring-cloud/spring-cloud-sleuth#53
Dave Syer
@dsyer
Nov 07 2015 16:15
I was thinking brave is probably on the way out of sleuth
But easy either way
Adrian Cole
@adriancole
Nov 07 2015 16:16
yeah whichever works
once my in-flight on local component is done, I think zipkin-java could be ready for release if that helps.
alternatively, we could shade a snapshot in or build json directly
Dave Syer
@dsyer
Nov 07 2015 16:18
Shade a snapshot of what?
The serialization I guess
Adrian Cole
@adriancole
Nov 07 2015 16:19
yep zipkin-java snapshots are published to sonatype, core has the serialization api (dep free)
Dave Syer
@dsyer
Nov 07 2015 16:19
I think we definitely need a release of zipkin-Java before sleuth is GA
I'd prefer that to shading anyway
Adrian Cole
@adriancole
Nov 07 2015 16:20
+1
I think 1 week is a reasonable eta
Dave Syer
@dsyer
Nov 07 2015 16:20
Fine
Adrian Cole
@adriancole
Nov 07 2015 16:20
might be a low version number, but still published :P