These are chat archives for spring-cloud/spring-cloud

12th
Nov 2015
Spencer Gibb
@spencergibb
Nov 12 2015 00:11
I don’t think so.
ccit-spence
@ccit-spence
Nov 12 2015 00:27
@spencergibb Am I right that the Decoder is what needs to be modified? My assumption is that the ObjectMapper needs to be modified.
Spencer Gibb
@spencergibb
Nov 12 2015 01:01
The decoder is what needs to be modified. We plug in the same converters that RestTemplate does
ccit-spence
@ccit-spence
Nov 12 2015 01:02
I must be using Feign wrong then. If RestTemplate works without modification.
Spencer Gibb
@spencergibb
Nov 12 2015 01:02
no, not that “same” :-)
ccit-spence
@ccit-spence
Nov 12 2015 01:03
ok, just making sure.
Spencer Gibb
@spencergibb
Nov 12 2015 01:03
we use HttpMessageConverters
ccit-spence
@ccit-spence
Nov 12 2015 01:04
So then Overriding the SpringDecoder would be a decent approach?
With a config class
Spencer Gibb
@spencergibb
Nov 12 2015 01:05
that or customized HttpMessageConverters
ccit-spence
@ccit-spence
Nov 12 2015 01:06
I may play around with it this weekend
RestTemplate works, Feign just looks nicer to me
Spencer Gibb
@spencergibb
Nov 12 2015 03:01
yup, it’s a different style.
Tommy Ludwig
@shakuzen
Nov 12 2015 14:38
Let me know if any additional information is needed for spring-cloud/spring-cloud-config#264
Tommy Ludwig
@shakuzen
Nov 12 2015 15:35
@dsyer Regarding spring-cloud/spring-cloud-config#264, I am aware of the MVC limitation and the documentation regarding replacing "/" with "(_)" - I even mentioned it directly in the issue. This works perfectly well with the EnvironmentController (I even linked to the line in the code that does the replacement). This however is not working with the ResourceController for serving plain text files because that replacement code is simply not there (I linked to the ResourceController code on master). Could you take another look or am I missing something?
Dave Syer
@dsyer
Nov 12 2015 15:36
Sorry, missed that.
Tommy Ludwig
@shakuzen
Nov 12 2015 15:36
Not a problem at all.
Tommy Ludwig
@shakuzen
Nov 12 2015 16:14
@dsyer Thank you for the very quick turnaround on that issue. I just have one curious question: is it okay that the slash replacement doesn't happen on the ResourceController#binary method also?
Dave Syer
@dsyer
Nov 12 2015 16:49
No. Thanks.
Check now
Tommy Ludwig
@shakuzen
Nov 12 2015 17:01
Looks good. Thanks Dave