These are chat archives for spring-cloud/spring-cloud

19th
Jan 2016
Dave Syer
@dsyer
Jan 19 2016 05:59
Those are also only warnings (tomcat actually cleans up the classloader as much as it can). So it's not necessarily a problem.
Simon
@sbuettner
Jan 19 2016 09:54
Hi everyone, just curious. Is there a release date or a roadmap for spring cloud?
Dave Syer
@dsyer
Jan 19 2016 10:23
We can't be precise about it at this point.
2016Q1 is pretty safe
Brixton is gated on spring-cloud-stream which is needed by spring-cloud-dataflow. I think there is quite a definite time line for that project, so that will constrain the rest of Spring Cloud. We hope to have spring-cloud-stream go GA as soon as possible (i.e. before it is needed by dataflow), but we haven't had the meeting to agree the dates yet.
Simon
@sbuettner
Jan 19 2016 10:40
@dsyer Thanks
Dreampie
@Dreampie
Jan 19 2016 12:11

@dsyer
@FeignClient("xx")
interface UserService{

@RequestMapping(value="/users",method=GET)
public List<User> findBy(User user);
}
userService.findBy(user);
Too many parameters, hope packaged into model,how can todo?

Dave Syer
@dsyer
Jan 19 2016 12:12
How were you going to send the parameters in the request?
A GET with a @RequestBody is not really kosher (though some servers might accept it)
You need to split the input up into @RequestParam and @PathVariable.
Dreampie
@Dreampie
Jan 19 2016 12:15
get parameter like : user={userJson}
Dave Syer
@dsyer
Jan 19 2016 12:16
JSON as a request parameter?
Maybe you need a POST (not a GET)?
Dreampie
@Dreampie
Jan 19 2016 12:18
but rest is recommended to use the get method,because I only want to get some data with parameters
Dave Syer
@dsyer
Jan 19 2016 12:28
Then you need to use @RequestParam and @PathVariable
If you want to torture your users you could put JSON in a @RequestParam
but it's not very conventional
Dreampie
@Dreampie
Jan 19 2016 12:34
That means
need to be converted to a string before sending the request
Dave Syer
@dsyer
Jan 19 2016 12:34
Indeed, that's what I meant by "torture your users".
Dreampie
@Dreampie
Jan 19 2016 12:35
FeignClient can config request encoder to support this?
Dave Syer
@dsyer
Jan 19 2016 12:41
Support what? Torture?
Spring Cloud with Feign already supports the @RequestParam and @PathVariable annotations. It's up to you how to use them.
Michael Rumpf
@mrumpf
Jan 19 2016 12:45
Hi, the Spring Boot project has all future milestones defined. There is no such milestones list for Spring Cloud (yet). We are just discussing on which version we should focus our development. Can you give any hint for a final Brixton Release roadmap?
Dreampie
@Dreampie
Jan 19 2016 12:51

Registering the editor with every @RequestParam? Can do this:

get(@JsonArgument Page page, @JsonArgument User user)

like use HandlerMethodArgumentResolver to convert every parameter to model

Dave Syer
@dsyer
Jan 19 2016 13:00
@mrumpf see above where @sbuettner asked the same question
Michael Rumpf
@mrumpf
Jan 19 2016 13:00
OK, thx
Alex Filatov
@sprgn
Jan 19 2016 14:20
Tomcat is doing a bad job cleaning those up. Those threads indeed stay out there, and after a couple of redeploys, it becomes impossible to deploy again until container is restarted.
Dave Syer
@dsyer
Jan 19 2016 14:24
OK. Feel free to propose a change if you can see how to shutdown the threads.
You have the issue link
Matt Benson
@mbenson
Jan 19 2016 16:38
okay, I'm trying to use spring-cloud-starter-eureka with spring-boot-starter-jersey. However, Eureka needs jersey 1 so I've got a conflict. Has this been handled before?
Dave Syer
@dsyer
Jan 19 2016 16:39
It's not possible I think
There's no way 2 versions of Jersey can co-exist.
Matt Benson
@mbenson
Jan 19 2016 16:40
Is another JAX-RS impl supported by Spring Boot?
seems to me Eureka could and possibly should shade jersey1
but that's beyond your control, obviously
Dave Syer
@dsyer
Jan 19 2016 16:41
Yes
Matt Benson
@mbenson
Jan 19 2016 16:41
yes to which? :)
Dave Syer
@dsyer
Jan 19 2016 16:41
Spring Boot only supports Jersey 2
Yes to both
Matt Benson
@mbenson
Jan 19 2016 16:44
argh, they would build with gradle
Matt Benson
@mbenson
Jan 19 2016 23:52
trying to implement a case of what is advertised in the spring-cloud doc as "Together with Spring MVC you can share the same contract for your REST endpoint and Feign client." But what I find is that the OOTB MVC setup doesn't find the interface annotations on the implementation class.
The feign-eureka sample of course doesn't use a separate interface to define the @RestController
Spencer Gibb
@spencergibb
Jan 19 2016 23:58
Not my favorite feature.
Matt Benson
@mbenson
Jan 19 2016 23:58
is there a downside?
Spencer Gibb
@spencergibb
Jan 19 2016 23:58
Sharing server side classes on a client side?
Matt Benson
@mbenson
Jan 19 2016 23:59
Defining the interface separately to be implemented on the server and consumed by the client
Dumbing down the consumer end of a service, as it were