These are chat archives for spring-cloud/spring-cloud

16th
Feb 2016
Fabian Wallwitz
@cforce
Feb 16 2016 07:46
does "discoveryComposite" actuator list any microservice from eureka server (local copy of the server list is latest know status) or only the ones which has been accessed through the microservice itself?
or the other way round .. when will status of "discoveryClient" will goto "down" ?
Fabian Wallwitz
@cforce
Feb 16 2016 07:57
i try to build an actuator for all feign clients, checking if the anotated service and enpoint is alive .. any suggestions..what i could build on?
Dave Syer
@dsyer
Feb 16 2016 09:19
The discovery health indicator lists all the services and their statuses (there's no API at the moment for "the ones we are connected to")
Fabian Wallwitz
@cforce
Feb 16 2016 10:37
i just wrote an FeignClientHealthIndicator which checks if at least one instance for required service is "UP", doing this for all FeignClients used ..
however it does not check if the endpoint (PATH) exists -..it would need a /ping endpoint for checking.. that check shall only be executed one time per service start
does any similar actuator impl. exists for MVC "endpoints" in general?
Dave Syer
@dsyer
Feb 16 2016 10:43
What do you mean: "similar" to what?
Fabian Wallwitz
@cforce
Feb 16 2016 10:45
is there any existing code (e.g. in Feign) which allows building up health check on consumed paths?
i assume no .. so far i can't find any..
Dave Syer
@dsyer
Feb 16 2016 10:47
Not in Spring Cloud, no
Fabian Wallwitz
@cforce
Feb 16 2016 14:29
does Feign hystrix fallback class must be static?
Fabian Wallwitz
@cforce
Feb 16 2016 14:34
in the documentation example its static .. and the FeignClient protected .. but if i use inheritance of the RequestMapping in Client ..thats not possible on an public interface
and how can i configure detailed hystrix parameters together with feign fallback class?
is there any full featured example for this "new" fallvack feature together with deep hystrix configuration?
Dave Syer
@dsyer
Feb 16 2016 15:16
AFAIK it just needs to be a class with the same interface
The "static " keyword is necessary only if it is a nested class
(normal Java language constraints)
The best example is in the tests
It doesn't use inheritance though
I'd say you'd need to provide a sample so we can see what you mean by that
Matt Benson
@mbenson
Feb 16 2016 17:13
@dsyer: thoughts on #828? That was just the first incremental step; I now have a local commit that additionally supports parameter name fallback, though it may bear a bit of hammering before it's 100% acceptable for inclusion.
Dave Syer
@dsyer
Feb 16 2016 18:15
Is that the feign one?
Matt Benson
@mbenson
Feb 16 2016 18:15
yes
I addressed your comments from yesterday (I think)
Spencer Gibb
@spencergibb
Feb 16 2016 18:16
spring-cloud/spring-cloud-netflix#828
Matt Benson
@mbenson
Feb 16 2016 18:19
that, too :)
@spencergibb: any thoughts from you?
Spencer Gibb
@spencergibb
Feb 16 2016 18:20
I did some work on it already spring-cloud/spring-cloud-netflix@62d340b
Matt Benson
@mbenson
Feb 16 2016 18:21
this change does the same for parameter annotations
Spencer Gibb
@spencergibb
Feb 16 2016 18:21
nice, I see. I hadn’t grokked the difference. Sweet.
Dave Syer
@dsyer
Feb 16 2016 18:22
I thought it was a good contribution (just missing a commit log IIRC)
Matt Benson
@mbenson
Feb 16 2016 18:24
I updated the commit log and renamed the test class as you requested
Dave Syer
@dsyer
Feb 16 2016 18:24
Great
Johannes Edmeier
@joshiste
Feb 16 2016 19:46
@spencergibb is there any schedule for the RC and RELEASE of Brixton?
RC1 this month, release to follow. Waiting on the GA release of spring-cloud-stream
Johannes Edmeier
@joshiste
Feb 16 2016 19:48
Thx. In that bunch of spring-cloud projects I didn't know where to look for the milestoens
Dave Syer
@dsyer
Feb 16 2016 19:49
They are all in github now
Provisional dates
But it's a line in the sand at least
Johannes Edmeier
@joshiste
Feb 16 2016 19:50
great thx a lot