These are chat archives for spring-cloud/spring-cloud

25th
Apr 2016
Donovan Muller
@donovanmuller
Apr 25 2016 11:13
@dsyer Wrt spring-cloud/spring-cloud-bus@bef97a5, is it not a bit limiting that custom events must use a Spring Cloud package?
Dave Syer
@dsyer
Apr 25 2016 11:19
Yes. But I think it will get us to 1.1.0.
It's brittle to add custom events anyway (all apps need to share another jar).
So if we want to make it easier we should do it carefully
Not a quick change between Rc2 and GA
Donovan Muller
@donovanmuller
Apr 25 2016 11:20
Ok, say I wanted to make this a bit more generic. What would your thoughts be on implementation? I.e. Custom annotation and scan for that (like @FeignClient), scan for classes implementing RemoteApplicationEvent...
Dave Syer
@dsyer
Apr 25 2016 11:21
Probably, yes
Donovan Muller
@donovanmuller
Apr 25 2016 11:22
Which one?
Dave Syer
@dsyer
Apr 25 2016 11:22
i didn't read that as a binary choice
We need a form of component scan
So @RemoteApplicationEventScan or something
Donovan Muller
@donovanmuller
Apr 25 2016 11:24
That would scan for impl's of RemoteApplicationEvent?
Dave Syer
@dsyer
Apr 25 2016 11:24
It has to be subclasses I think
Or else we need a way to map POJO to a subclass
Maybe that would be nice
Donovan Muller
@donovanmuller
Apr 25 2016 11:25
Sorry, could you elaborate on "Or else we need a way to map POJO to a subclass"
Dave Syer
@dsyer
Apr 25 2016 11:25
The bus only operates on RAEs
But users could define POJO classes (I guess)
I'm not sure it's worth a lot of effort
Subclasses will work
Donovan Muller
@donovanmuller
Apr 25 2016 11:27
ok, will try with scanning for sublasses of RemoteApplicationEvent on @RemoteApplicationEventScan
Donovan Muller
@donovanmuller
Apr 25 2016 11:40
Would you recommend @IntegrationComponentScan as a good starting point?
Dave Syer
@dsyer
Apr 25 2016 11:41
There's code in BusJacksonMessageConverter already
to do the sacn
You just need to pass it some package names
Donovan Muller
@donovanmuller
Apr 25 2016 11:42
ah ok, got it
Bartek Andrzejczak
@bandrzejczak
Apr 25 2016 13:35
I'm not sure this is spring issue or zuul issue but here it is: When I send POST request containing Multipart form through zuul proxy, if the form contains duplicated form parts (having same name), those duplicates are reduced and only one form part with this name reaches the destination server. How can I tackle this issue?
Dave Syer
@dsyer
Apr 25 2016 13:43
Zuul itself has no knowledge of multipart data
So if there's an isssue it's in Spring Cloud
Did you try using the /zuul servlet (instead of the default path)?
Bartek Andrzejczak
@bandrzejczak
Apr 25 2016 13:47
What do you mean by that? accessing my resource under /api/resource with /zuul/api/resource?
Dave Syer
@dsyer
Apr 25 2016 13:49
Yes
Bartek Andrzejczak
@bandrzejczak
Apr 25 2016 13:53
Okay, I've tried making a request by hand and it works fine. I'll change url to zuul servlet in ngnix and try running the app
Bartek Andrzejczak
@bandrzejczak
Apr 25 2016 14:56
Thanks ;) Using zuul servlet worked just fine.
pradeepkusingh
@pradeepkusingh
Apr 25 2016 20:13
@spencergibb : Hi Spencer , how to encrypt whole property files , so no one can see my /configprops or /env data from actuator end points ?
Spencer Gibb
@spencergibb
Apr 25 2016 20:14
disable those end points?
pradeepkusingh
@pradeepkusingh
Apr 25 2016 20:15
We don't want .. just want to make few proeprties invisible or encrypted :)
Spencer Gibb
@spencergibb
Apr 25 2016 20:15
You can configure which patterns get put as stars (********) like secret or password.
pradeepkusingh
@pradeepkusingh
Apr 25 2016 20:16
ok, looks . do we have any docs or sample which I can follow anything specific to spring ?
looks good.
Spencer Gibb
@spencergibb
Apr 25 2016 20:19
From http://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#common-application-properties endpoints.configprops.keys-to-sanitize=password,secret,key,.*credentials.*,vcap_services and endpoints.env.keys-to-sanitize=password,secret,key,.*credentials.*,vcap_services
either endswith or regex.
pradeepkusingh
@pradeepkusingh
Apr 25 2016 20:20
@spencergibb : Thank you :) you are awesome