These are chat archives for spring-cloud/spring-cloud

22nd
May 2016
Donovan Muller
@donovanmuller
May 22 2016 08:53
Is https://github.com/openzipkin/zipkin-java/blob/master/zipkin-server/README.md the recommended way to run the Zipkin UI with Sleuth?
Just want to confirm they're interchangeable? Seems zipkin-server has more span stores?
Donovan Muller
@donovanmuller
May 22 2016 09:15
Guess I'm just confused as to which Zipkin server impl. gives you the UI as well. I'm using @EnableZipkinStreamServer as per the docs but do not get the UI on http://localhost:9411/ as expected (I do get the Zipkin API endpoints and can call successfully)
and in spring-cloud-sleuth-samples it seems like you should be standing up the openzipkin server...
Dave Syer
@dsyer
May 22 2016 10:05
The UI is a separate JAR (zipkin-ui).
@EnableZipkinServer switches it on if it's there (and @EnableZipkinStreamServer is meta-annotated @EnableZipkinServer, so either work).
Donovan Muller
@donovanmuller
May 22 2016 10:07
So add it as a dependency and should be good to go?
Dave Syer
@dsyer
May 22 2016 10:07
Yes
Donovan Muller
@donovanmuller
May 22 2016 10:07
By it I mean zipkin-ui
Dave Syer
@dsyer
May 22 2016 10:07
Yes
Donovan Muller
@donovanmuller
May 22 2016 10:07
Great, thanks. Worth adding to the docs? Can do a a PR later...
Dave Syer
@dsyer
May 22 2016 10:08
Yeah, if it's not there already.
We already have it in start.spring.io.
Thanks
Andreas Evers
@andreasevers
May 22 2016 13:12
Hey guys,
Should spring-cloud-starter-parent ever be used by a regular application?
e.g:
<dependency>
    <groupId>org.springframework.cloud</groupId>
    <artifactId>spring-cloud-starter-parent</artifactId>
    <version>Brixton.RELEASE</version>
</dependency>
or should we rather use the dependencies import?
The reason why I’m asking is because I’m getting the following issue (spring-cloud/spring-cloud-netflix#1019) where using the spring-boot-starter-parent fixed it (although not for me)
Dave Syer
@dsyer
May 22 2016 13:29
We don't like to encourage the use of that parent
It's there for historical reasons.
Andreas Evers
@andreasevers
May 22 2016 13:29
I updated the ticket with my pretty straight-forward fix, but still got me wondering if there’s any benefit to using spring-cloud-starter-parent as a parent
Dave Syer
@dsyer
May 22 2016 13:30
It forces the dependencies to be all managed by Spring Cloud
I'm not sure I'd ever want that.
but since it already existed, people might have been relying on it (in the Angel version).
We'll probably remove it at some point
Andreas Evers
@andreasevers
May 22 2016 13:31
So basically always prefer the dependency import instead of the inheritence
Dave Syer
@dsyer
May 22 2016 13:31
Yes.
Andreas Evers
@andreasevers
May 22 2016 13:31
Cool cheers :)
Dave Syer
@dsyer
May 22 2016 13:31
I also think the spring-boot-starter-parent has issues
It's a compromise
Andreas Evers
@andreasevers
May 22 2016 13:32
Isn’t there a dependency import for spring-boot as well?
Dave Syer
@dsyer
May 22 2016 13:32
There is
The thing that the parent gives you that imports do not is (in maven) the ability to override individual versions with properties.
That's quite a powerful feature in fact, and it's the only reason we keep the parent in its current form (plugins and dependencies)
Andreas Evers
@andreasevers
May 22 2016 13:33
I see