These are chat archives for spring-cloud/spring-cloud

7th
Jun 2016
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:12
Hi guys, I’m playing with Netflix Hystrix and it’s @HystrixCommand but it keeps giving me the following message:
com.netflix.hystrix.contrib.javanica.exception.FallbackDefinitionException: fallback method wasn't found: fallbackThrowUpMethod([])
I know it’s related to Netflix/Hystrix#1155 but I’m using Brixton.RELEASE and it already has the fixed version of Hystrix
litzuhsien
@litzuhsien
Jun 07 2016 01:13
Where is y
Spencer Gibb
@spencergibb
Jun 07 2016 01:14
@marcosbarbero would need to see your code
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:14
It’s easy. Give me few seconds and I’ll push to github
Spencer Gibb
@spencergibb
Jun 07 2016 01:17
hm, maybe just Exception?
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:18
it’s just a few samples of spring cloud and it’s power, tomorrow I’ve a presentation to do and I’m about to add a sample of circuit breaker
I’ve tried with Exception, Throwable, RuntimeException and nothing at all
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:22
Ok, I’ll try it again.
same error just happened
Spencer Gibb
@spencergibb
Jun 07 2016 01:22
works without exception?
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:22
don't
Spencer Gibb
@spencergibb
Jun 07 2016 01:22
fallbacks on @Controllers don’t work
that’s why
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:23
really? it used to work
Maybe something has changed in the latests releases
If i’m not wrong in Brixton.M5 it used to work. I’ll give it a try.
Spencer Gibb
@spencergibb
Jun 07 2016 01:25
spring-cloud/spring-cloud-netflix#207
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:26
I see
Spencer Gibb
@spencergibb
Jun 07 2016 01:26
There has been issues for over a year. Likely not consistent.
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:26
Well, not a problem at all. It’s just a sample
Spencer Gibb
@spencergibb
Jun 07 2016 01:26
I bet if you put your code in a service class it works
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:26
I’ll do that right now
Spencer Gibb
@spencergibb
Jun 07 2016 01:27
it has to do with if your controller is an AOP proxy or not
IIRC
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:29
The result will talk by itself
curl localhost:9000/throw
["it","works"]
Spencer Gibb
@spencergibb
Jun 07 2016 01:29
yup, can’t argue with results
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:29
hehehe
thank you for your time @spencergibb
Spencer Gibb
@spencergibb
Jun 07 2016 01:29
de nada, boa noite
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:30
hahahaha
it was funny hahahaha portuguese language was not expected at all hahaha
Spencer Gibb
@spencergibb
Jun 07 2016 01:31
;-) falo português, morei dois anos no nordeste
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:32
Agora eu fiquei bem surpreso! Eu moro em São Paulo. Mas acho melhor continuarmos a falar em inglês, antes que alguém do canal se incomode hehehe ;)
Spencer Gibb
@spencergibb
Jun 07 2016 01:32
:-) good night then
Marcos Barbero
@marcosbarbero
Jun 07 2016 01:33
good night! :D and thanks again
Włodzimierz Rożkow
@rozhok
Jun 07 2016 08:35
is there way to completely disable Servo stuff in app?
also, is there way to completely disable healtcheck and telemetry endpoints?
Dave Syer
@dsyer
Jun 07 2016 08:39
Health check in Eureka client you mean?
(I think it's off by default)
Włodzimierz Rożkow
@rozhok
Jun 07 2016 09:05
i mean /health and /info endpoints
and other related stuff
Dave Syer
@dsyer
Jun 07 2016 09:20
endpoints.health.enabled=false
endpoints.info.enabled=false
does that not work?
Pedro Vilaça
@pmvilaca
Jun 07 2016 09:24
@rozhok - endpoints.enabled=false
will disable all the endpoints
and then you can opt-in for the endpoints that you want to enable
Włodzimierz Rożkow
@rozhok
Jun 07 2016 09:43
thank you @pmvilaca !
Servo question is still actual
Dave Syer
@dsyer
Jun 07 2016 09:45
You can exclude it from the classpath
Włodzimierz Rożkow
@rozhok
Jun 07 2016 09:45
we didn't using it at the moment so I want to get rid of all non-necessary stuff
cool
Dave Syer
@dsyer
Jun 07 2016 09:45
There's probably an enabled flag as well
spring.metrics.servo.enabled
I'm just reading source code at ServoMetricsAutoConfiguration
Włodzimierz Rożkow
@rozhok
Jun 07 2016 09:54
this thins doesn't stop ServoPollScheduler threads, probably it'll be better to exlude them from classpath