These are chat archives for spring-cloud/spring-cloud

15th
Jun 2016
Donovan Muller
@donovanmuller
Jun 15 2016 06:18
@markpollack Yup, looks good now. Thanks
David Steiman
@xetys
Jun 15 2016 10:09
hello, just an easy question, when using current Brixton.RELEASE, how to specify a timeout on zuul, which acutally will work. I thought it was like
hystrix:
    command:
        SERVICE_ID:
            execution:
                timeout:
                    enabled: false
but i still get timeouts, cause some APIs take slightly more time
David Steiman
@xetys
Jun 15 2016 10:31
also tried with
ribbon:
  ConnectTimeout: 3000
  ReadTimeout: 60000
getting a timeout
Danish Chaudhry []
@chdanish_twitter
Jun 15 2016 10:32
This message was deleted
This message was deleted
David Steiman
@xetys
Jun 15 2016 10:35
ok, got confused with the hystrix settings....i got a slow .NET service to consume, and one request results in 3 request to .NET...."its not a timeout, it just takes some time :D"
so the hystrix was set on the consuming service, not on the proxy
but i don't want to disable the timeouts total
why delete @chdanish_twitter ?
szisti
@szisti
Jun 15 2016 11:45
Would it be possible to disable the zookeeperDiscovery health indicator similar to this one: spring-cloud/spring-cloud-zookeeper@bb0ba6b
Marcin Grzejszczak
@marcingrzejszczak
Jun 15 2016 11:53
you can register your own ZookeeperHealthIndicator that does nothing if you want to disable it
i.e. management.health.zookeeper.enabled=false disables it
Bartek Andrzejczak
@bandrzejczak
Jun 15 2016 13:11
Is it possible, that Zuul cannot interpret path segments with semicolons in them? We're sending a request with %3B in it, and what we receive on the other side is an address up to this point. So if we're sending http://test.com/value%3B1.0 after Zuul it's just http://test.com/value.
Dave Syer
@dsyer
Jun 15 2016 13:12
Quite likely.
Are you using 1.1.2.RELEASE?
Bartek Andrzejczak
@bandrzejczak
Jun 15 2016 13:13
1.1.0.RC2
Dave Syer
@dsyer
Jun 15 2016 13:16
Kind of old then.
Bartek Andrzejczak
@bandrzejczak
Jun 15 2016 13:16
I'm updating to Brixton.RELEASE and I'll see if it works there.
Dave Syer
@dsyer
Jun 15 2016 13:16
Better try an upgrade before we dig any deeper.
Brixton.SR1 was announced yesterday
Bartek Andrzejczak
@bandrzejczak
Jun 15 2016 13:17
All right.
szisti
@szisti
Jun 15 2016 13:41
@dsyer I'm looking to disable zookeeperDiscovery, not the zookeeper (which works perfectly, as you said it's conditional)
Dave Syer
@dsyer
Jun 15 2016 13:42
You said "disable the zookeeperDiscovery health indicator"
So I guess I got the wrong health indicator
Marcin Grzejszczak
@marcingrzejszczak
Jun 15 2016 13:52

It's already conditional in ...

I guess I'm blind...

Dave Syer
@dsyer
Jun 15 2016 14:03
Probably it should be a DiscoveryHealthIndicator as well
spring-cloud/spring-cloud-zookeeper#85
PR welcome
Bartek Andrzejczak
@bandrzejczak
Jun 15 2016 15:20
@dsyer Brixton.SR1 actually ruins our authorization (based on keycloak, which is also registered in eureka and available through zuul), I don't really know why, so we cannot use it.
David Steiman
@xetys
Jun 15 2016 15:27
have you declared "authorization" to be excluded from ignoredHeaders?
since Brixton.RC1 the sensitive headers from zuul works
Jacques-Etienne Beaudet
@jebeaudet
Jun 15 2016 15:34
spring-cloud/spring-cloud-netflix#1003 @bandrzejczak
David Steiman
@xetys
Jun 15 2016 15:40
@bandrzejczak
@Component
public class RelayTokenFilter extends ZuulFilter{
    @Override
    public String filterType() {
        return "pre";
    }

    @Override
    public int filterOrder() {
        return 10000;
    }

    @Override
    public boolean shouldFilter() {
        return true;
    }

    @Override
    public Object run() {
        RequestContext context = RequestContext.getCurrentContext();

        @SuppressWarnings("unchecked") Set<String> ignoredHeaders = (Set<String>) context.get("ignoredHeaders");
        ignoredHeaders.remove("authorization");

        return null;
    }
}
other way
Jacques-Etienne Beaudet
@jebeaudet
Jun 15 2016 16:08
just setting the zuul.sensitive-headers key to empty should also do it