Good morning/Afternoon. Can somebody review my PRs please (from 83 to 87) ?
We should perhaps create a spring-cloud-kubernetes channel to discuss
@dsyer i see you committed a change 13 days ago in SimpleDiscoveryClient to return a local instance instead of null (https://github.com/spring-cloud/spring-cloud-commons/commit/fc2355b9853a4d0164a6c9287b36668fd5844ba7#diff-e9667d843bbf6dc49a28dd26db92a876). i'm using spring cloud dalston release and having an issue with spring cloud netflix hystrix stream. apparently the stream task tries to build some json using the local service object (which is null) and starts filling up logs with NPEs. can you tell me if there is there a workaround for this?
for reference, here is the hystrix code that is calling the getLocalServiceInstance method: https://github.com/spring-cloud/spring-cloud-netflix/blob/master/spring-cloud-netflix-hystrix-stream/src/main/java/org/springframework/cloud/netflix/hystrix/stream/HystrixStreamTask.java#L122
Isn't that the problem I fixed?
hey guys, if you are using vault as one of the backend repo for spring-cloud-config - It requires the clients to configure a vault token under
spring.cloud.config.token and pass the same as a header to the spring-cloud-config-server. But this opens up the token to the world and leak the same.
what is the best practice to manage this ?
It's fixed in a snapshot and I was looking to avoid adding a snapshot dependency... Hoping you could tell me if there was some other kind of workaround. I ended up adding the cloud commons snapshot as a dependency but that's obviously not optimal.