These are chat archives for spring-cloud/spring-cloud

10th
Oct 2017
Richard Kettelerij
@rkettelerij
Oct 10 2017 07:55 UTC
Hi, could anyone from the spring cloud team perhaps have a quick look at my PR: spring-cloud/spring-cloud-consul#356. I know you guys have a ton of projects to maintain, but this PR is open for a while now and I'd like to contribute where I can.
Dave Syer
@dsyer
Oct 10 2017 07:57 UTC
Thanks for the patch. We need to fix the broken tests before looking at merging new features I think.
There's a lot to do at the moment (Spring Boot 2)
Richard Kettelerij
@rkettelerij
Oct 10 2017 08:01 UTC
I understand (i'm also looking forward to spring boot 2). I'll wait, let me know if I can be of any assistance.
Dave Syer
@dsyer
Oct 10 2017 08:02 UTC
Fixing tests would go a long way. You said there were failures on master (not Boot 2.0). So they should be easy to track down.
Tim Ysewyn
@TYsewyn
Oct 10 2017 11:30 UTC
@spencergibb with some delay, created spring-cloud/spring-cloud-gateway#79