These are chat archives for spring-cloud/spring-cloud

17th
Oct 2017
Dave Syer
@dsyer
Oct 17 2017 05:51
Generally speaking propertysources are not beans. So what do you mean?
Richard Kettelerij
@rkettelerij
Oct 17 2017 08:23

FYI: The build of spring-cloud-consul (master branch) has been failing for some time now. This is due to one failing test. I've done some analysis and it's caused by this commit: spring-cloud/spring-cloud-consul@6ae6dea.

That commit bumps the spring-cloud-netflix dependency, which in turn bumps the netflix archaius version. Now spring-cloud-consul is build using Java 7. The test fails since a certain library (I think archaius) is compiled with Java 8. The error is:

Caused by: java.lang.NoSuchMethodError: java.util.concurrent.ConcurrentHashMap.keySet()Ljava/util/concurrent/ConcurrentHashMap$KeySetView; at com.netflix.config.ConcurrentMapConfiguration.getKeys(ConcurrentMapConfiguration.java:152)

Now archaius is suppose to be Java 6 compatible (source and target version) but the error suggests otherwise. Hope this is of any help.

Dave Syer
@dsyer
Oct 17 2017 08:27
That sounds helpful, thanks.
I wonder why it doesn't fail in spring-cloud-netflix
What version of archaius are you seeing?
Richard Kettelerij
@rkettelerij
Oct 17 2017 08:28
It's archaius 0.7.5
Dave Syer
@dsyer
Oct 17 2017 08:30
Is there an issue in archaius for this?
they should do a new release I guess
It's the same version of archaius in s-c-netflix
Maybe different code paths.
I think we need @spencergibb to have an opinion on the archaius features in s-c-consul. Archaius 1.x is basically dormant, but I think we have to keep supporting it for compatiblity.
Richard Kettelerij
@rkettelerij
Oct 17 2017 08:36
Indeed Archaius v0.7.5 was released over a year ago (4 oct 2016).
There's no issue in the archaius issue tracker for this (yet)
Dave Syer
@dsyer
Oct 17 2017 08:37
How about opening one?
Richard Kettelerij
@rkettelerij
Oct 17 2017 08:37
The metadata of the archaius jar says:
Build-Java-Version=1.8.0_31 X-Compile-Target-JDK=1.6 X-Compile-Source-JDK=1.6
So this aligns with my findings. Since the offending map is declared as protected ConcurrentHashMap<String, Object> map;
Dave Syer
@dsyer
Oct 17 2017 08:38
Yeah. It should be easy to fix.
If you open a ticket you will be able to track it.
Richard Kettelerij
@rkettelerij
Oct 17 2017 08:38
I'll take a look
Dave Syer
@dsyer
Oct 17 2017 08:38
We can get hold of someone at Netflix who can push a release out
Richard Kettelerij
@rkettelerij
Oct 17 2017 09:04
I've created Netflix/archaius#522
Dave Syer
@dsyer
Oct 17 2017 09:08
:thumbsup:
Jagmohan Sharma
@JagmohanSharma
Oct 17 2017 13:48
Regarding Netflix/Hystrix#1697, can we also point someone from Netflix/Hystrix team to help/guide on this issue?
Dave Syer
@dsyer
Oct 17 2017 16:34
It would be more likely to succeed if there was an actual pull request. But we can ask.
Spencer Gibb
@spencergibb
Oct 17 2017 16:44
@JagmohanSharma I've made contact RE hystrix
Abdulmuqueet Mohammed
@aim4pole
Oct 17 2017 19:54
@dsyer : Hi dave , spring-cloud/spring-cloud-config@8d8e07a
based on this commit, if I publish refreshevent, will my config property sources updated
I am not using spring-cloud-bus or config server
Abdulmuqueet Mohammed
@aim4pole
Oct 17 2017 20:00
based on the readme: it works only when I use config server with spring-cloud-bus it will work
Spencer Gibb
@spencergibb
Oct 17 2017 20:08
@aim4pole not without bus, otherwise, how will clients be notified to refresh their configuration?
Abdulmuqueet Mohammed
@aim4pole
Oct 17 2017 20:20
if I am running a single client in same jvm process , then I do still need the bus??
Spencer Gibb
@spencergibb
Oct 17 2017 20:25
are you sharing a spring application context?
Abdulmuqueet Mohammed
@aim4pole
Oct 17 2017 20:26
yes meaning within same context i am config watcher as well client
Spencer Gibb
@spencergibb
Oct 17 2017 20:27
then you might not need the bus, but that is not the typical setup
Abdulmuqueet Mohammed
@aim4pole
Oct 17 2017 20:27
ok thanks spencer