These are chat archives for spring-cloud/spring-cloud

20th
Mar 2018
Uri Goldstein
@urig
Mar 20 2018 06:55
Good morning. I have a question about Eurkea, hope it's on topic:
In a sample project I've setup, I point my Eureka clients to my Eureka server with a URL like so:
eureka.serviceUrl.default=http://localhost:8761/eureka/v2/
What happens if that server dies?
Is there a way to configure the clients to discover the Eureka server w/o relying on an absolute URL?
Roi Ezra
@ezraroi
Mar 20 2018 08:01
Hi, i have a question regarding the configuration service working with Git backend and GitHub. From looking on the code, looks like that if GitHub is down, all requests to get configuration will fail. Can we make the configuration service return the local copy on such cases?
Dave Syer
@dsyer
Mar 20 2018 08:51
I'm pretty sure that's what happens
Roi Ezra
@ezraroi
Mar 20 2018 09:13
@dsyer from looking on the code looks like the refresh method in JGitEnvironmentRepository will throw exception that will not be handeled
Dave Syer
@dsyer
Mar 20 2018 09:16
I guess it depends on the exception.
It's not obvious from reading the code
Roi Ezra
@ezraroi
Mar 20 2018 09:17
i don't see any exception handling in the sequence that starts from the RestController
Dave Syer
@dsyer
Mar 20 2018 09:21
I see exception handling in fetch()
And unit tests that exercise the code path
Roi Ezra
@ezraroi
Mar 20 2018 09:30
yes, but shouldPull might also throw exception.. I am not sure
maybe git status will work even if the remote repo is down
Dave Syer
@dsyer
Mar 20 2018 09:38
If you think you can improve it, please do.
git status should have no interaction with the remote
Ryan Baxter
@ryanjbaxter
Mar 20 2018 10:41
Ryan Baxter
@ryanjbaxter
Mar 20 2018 11:49
you can also take a look at this issue which has some good information spring-cloud/spring-cloud-netflix#203
Roi Ezra
@ezraroi
Mar 20 2018 11:59
thanks @dsyer
Uri Goldstein
@urig
Mar 20 2018 16:25
Thanks @ryanjbaxter !
Uri Goldstein
@urig
Mar 20 2018 16:33
@ryanjbaxter I still don't understand how the client can find an alternative server if the original server goes down?
Do I supply the client with multiple server URLs?
Or rely on a third party to load balance behind the server URL?
Spencer Gibb
@spencergibb
Mar 20 2018 16:33
multiple server urls
Uri Goldstein
@urig
Mar 20 2018 16:33
Thanks @spencergibb
Felipe Adorno
@FelipeAdorno
Mar 20 2018 16:58
Hi all, I have an application with context-path configuration /foo and I set the actuator path /foo too but when the application registering in eureka don't get the /foo, what's wrong with my configuration?
Spencer Gibb
@spencergibb
Mar 20 2018 16:59
eureka only registers host and port