These are chat archives for spyder-ide/public

24th
Mar 2018
hofingermarkus
@hofingermarkus
Mar 24 2018 12:42
Hi Guys!
So I updated the config page to allow usage of Jedi, and added a warning to the Greedy completer.
I followed the way greedy completer gets its information passed to the ipython console.
Everything seems to work - how do I proceed?
Forking spyder on Github, uploading my changes as branch and filing a pull request?
Or do I have to do anything else or in another way?
hofingermarkus
@hofingermarkus
Mar 24 2018 13:25
I just filed the pull request - you can notify me here if something is odd....
Carlos Cordoba
@ccordoba12
Mar 24 2018 15:36
@hofingermarkus, thanks!
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 16:44
@hofingermarkus Thanks! I'm reviewing your PR as we speak—its good overall; it just needs a lot of basic typos and errors to be corrected, you should try to cut down the amount of text and crazy/inconsistent formatting, and it would be good to add a test, i.e. that enabling/disabling the jedi completer and basic completions work as expected.
hofingermarkus
@hofingermarkus
Mar 24 2018 17:57
Sorry, I maybe spent to little time on it - should have read it through more thoroughly...
hofingermarkus
@hofingermarkus
Mar 24 2018 18:22
But @CAM-Gerlach, honestlly it would have been way easier for me to change your requests if you would have written one longer sentence, than 17 - change requests... ^^
I'll write a complete shortened text, put it here and you can add any changes, before I'll add it to the codebase...
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 18:27
Well, there were a number of separate things on many different lines that needed to be changed, and that is the standard procedure for reviewing code...Github's system is limited in that regard. However, yeah, on the longer blocks especially what would have been much more helpful is just suggesting the changes directly inline in the text. Don't put it here directly, of course; it'll be impossible to review that way. Instead, why don't you make the changes in your branch, and I'll submit a PR against that if anything needs to be changed further.
@hofingermarkus
hofingermarkus
@hofingermarkus
Mar 24 2018 20:10
@CAM-Gerlach - so almost done...
However you write "Jedi Completion" whilst most of the time the word "completion" is written as lower case (also in the original texts..)
Is it ok if I leave it lower case everywhere?
(It took me a while to find out that github has a way better viewer for the changes, because in the summary page from the PR, it always shows all lines before and after your comments, which makes it hard to read what you really meant... )
Spyder_GUI_Updates3.png
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:31
@hofingermarkus That's because its in Title Case, like all the other titles on that page.
Normally yeah, you def. wouldn't want to capitalize it.
hofingermarkus
@hofingermarkus
Mar 24 2018 20:32
Hmm... its not consistent with the other pages..
"Inline backend" "IPython console"
Actually "Symbolic Mathematics" is the exception..
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:40
Hmm, you're right. Everything I could see in your screenshot was title case, but I only 2 of the 3 others only had more than one word. Looking through the rest of the panes, a few multi-word headers are in Title Case, but the rest are in normal Sentence case. IMO, they could all be in Title Case, but better to be consistent, so I guess go ahead and change back to lower, and fix Symbolic mathematics too if you don't mind. Thanks for checking.
@hofingermarkus
hofingermarkus
@hofingermarkus
Mar 24 2018 20:41
I just saw that I went over the line limit...
I'll change it and push in a few minutes again...
Should have developed for Spyder in Spyder not in Notepad++ ^^
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:42
You don't have either the 79 char line or real time style analysis enabled in the editor?
@hofingermarkus Haha, I do that too sometimes. But NP++ has a max length line too; I use it all the time.
hofingermarkus
@hofingermarkus
Mar 24 2018 20:42
Honestly - I thought - well adding this new window would be like 5mins, so why fire everything up... ^^
Well, lesson learned ^^
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:44
@hofingermarkus Editing > Vertical Edge Settings > Set Number of Columns to 79 and Show vertical edge to checked.
hofingermarkus
@hofingermarkus
Mar 24 2018 20:44
And about the translation... I'm not sure what you mean... Do you want me to put a _ before tip => "_tip="...
shall I also do it for the greedy completer
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:45
image.png
@hofingermarkus Its _("asdf"); its an alias for a function. But not sure... @ccordoba12 Are hover tips not translated?
It wouldn't be before tip; that'd break the syntax. It needs to act just on the string, so e.g. tip=_("dsfsdf") just like any other function.
hofingermarkus
@hofingermarkus
Mar 24 2018 20:53
Hmm... I just recognized, that there are many lines (not from me ) above this line limit...
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 20:55
Yes. There's a lot of crud in Spyder's codebase, presumably from before the editor itself had features to detect these issues and there was no real standard for the project. The basic rule seems to be that any line you touch, you should fix to conform to PEP8/etc, but don't worry about those you don't.
hofingermarkus
@hofingermarkus
Mar 24 2018 21:08
Ok so i pushed the last changes...
Unfurtunately I need to run..
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 21:08
No problem
Thanks man
hofingermarkus
@hofingermarkus
Mar 24 2018 21:08
I hope, most of the stuff is as you want... Feel free to make any changes..
CAM Gerlach
@CAM-Gerlach
Mar 24 2018 21:11
Sure; looking good. Just a tip—try to keep git commit messages in the imperative tense ("Add GUI option to...", "Rephrase text and fix typos", etc); 74 chars in length or under, and there is no need to include the same text every time; just say what's new in that commit—the overall change is already described by your PR title and by your branch name.
Also, it is generally a good idea to create a new branch for each PR with an appropriate name (e.g. add-jedi-option) rather than pushing directly to your copy of 3.x; it can lead to a lot of problems and hassles otherwise and keeps things cleaner.