These are chat archives for spyder-ide/public

22nd
Dec 2018
Victor Sonck
@thepycoder
Dec 22 2018 13:04
Hey guys! I like the functionality of this (spyder-ide/spyder#1759) and needed the practice, so I made it! Everything works locally, so I was making a test but could it be that there are several shortcut tests don't pass? I ran them on a fresh version of spyder master so I don't think my code broke those. Could that be correct or was it me after all? Ubuntu 18.04 LTS, python 3.6 and all other tests pass but some of these shortcut ones
CAM Gerlach
@CAM-Gerlach
Dec 22 2018 13:55
@thepycoder Hey, thanks for doing that! It indeed sounds very useful. If you want to go ahead with a PR, the tests will run on our CI servers and we'll be able to see the full output to isolate the problem, and we'll also be able to take a look at your code to see if the issue might lie there. Thanks, and looking forward to reviewing it!
:+1:
Victor Sonck
@thepycoder
Dec 22 2018 13:57
Very welcome! I love spyder, time to give some back. I base the PR against master?
CAM Gerlach
@CAM-Gerlach
Dec 22 2018 13:58
Yep; assuming you you based your feature branch against master (otherwise, you'll want to rebase it since 3.x is in feature freeze now with the upcoming Spyder 4 release). Thanks!