Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 15:35

    sqlalchemy-bot on main

    Removals: MetaData.bind, Table.… Merge "Removals: MetaData.bind,… (compare)

  • 15:34
    sqlalchemy-bot closed #7389
  • 15:34

    sqlalchemy-bot on main

    copy list for __iadd__ Fixed i… Merge "copy list for __iadd__" … (compare)

  • 15:34

    sqlalchemy-bot on rel_1_4

    copy list for __iadd__ Fixed i… Merge "copy list for __iadd__" … (compare)

  • 12:27
    CaselIT locked #7395
  • 12:27
    CaselIT unlabeled #7395
  • 09:59
    AbdealiJK edited #7395
  • 09:49
    AbdealiJK labeled #7395
  • 09:49
    AbdealiJK opened #7395
  • Dec 02 21:09

    sqlalchemy-bot on rel_1_4

    block class_getitem test for py… (compare)

  • Dec 02 19:52

    sqlalchemy-bot on rel_1_4

    Add __class_getitem__ to the de… (compare)

  • Dec 02 19:52
    sqlalchemy-bot closed #7381
  • Dec 02 19:52
    sqlalchemy-bot closed #7368
  • Dec 02 19:52

    sqlalchemy-bot on main

    Add __class_getitem__ to the de… Merge "Add __class_getitem__ to… (compare)

  • Dec 02 19:12
    zzzeek edited #7394
  • Dec 02 19:11
    zzzeek milestoned #7394
  • Dec 02 19:11
    zzzeek labeled #7394
  • Dec 02 19:11
    zzzeek labeled #7394
  • Dec 02 19:11
    zzzeek labeled #7394
  • Dec 02 19:11
    zzzeek opened #7394
Bryan Forbes
@bryanforbes
:D
mike bayer
@zzzeek
turns out releases are free! we can make as many as we want
Federico Caselli
@CaselIT
woot!
Bryan Forbes
@bryanforbes
you should tell the enterprise world that
mike bayer
@zzzeek
yeah
Bryan Forbes
@bryanforbes
the first thing I want to do is get the plugin passing in mypy strict mode
mike bayer
@zzzeek
anyway, the trend continues that a LOT of shit has broke w/ 1.4 but its all one liner stuff, meaning the approach remains sound
Federico Caselli
@CaselIT
8th release since the 15th :)
doesn't this merit a changelog entry? sqlalchemy/sqlalchemy@a143036
mike bayer
@zzzeek
@CaselIT technically yes but it's not critical.
@CaselIT im ina hurry to get this out since i have to go get a vaccine today....
Federico Caselli
@CaselIT
no problem, we can add it to the documentation later
since the website updates every 30minutes
Maico Timmerman
@MaicoTimmerman
@bryanforbes you might want to checkout the https://github.com/python/mypy/blob/master/misc/proper_plugin.py, I'm not sure why it is not exposed in the main library, but I ran it against the sqla mypy plugin and it found 3 issues
Bryan Forbes
@bryanforbes
whoa…
mike bayer
@zzzeek
@CaselIT i just added it
Federico Caselli
@CaselIT
neat!
still fiddling with stuff at work
Bryan Forbes
@bryanforbes
@MaicoTimmerman so I just add that to the plugins in mypy config, right?
(after updating to mypy master…)
mike bayer
@zzzeek
do we know that this plugin linter is current ? it wasnt mentioned to me
Bryan Forbes
@bryanforbes
hmm, it’s not included in a mypy master build either :/
Maico Timmerman
@MaicoTimmerman
Ye, but you need to copy it. I was opening a issue at mypy to ask them to publish it in the mypy package, but I got interrupted
Bryan Forbes
@bryanforbes
:+1:
Maico Timmerman
@MaicoTimmerman
It is not a full linter, from what I understood it just prevents you from doing instance checks on unresolved types
Bryan Forbes
@bryanforbes
@MaicoTimmerman thanks for that tip… I’m doing some cleanup on the plugin right now
Federico Caselli
@CaselIT
i'll try to look at some other stub pr. @MaicoTimmerman if you can lend an hand it would be great!
Maico Timmerman
@MaicoTimmerman
I'm from the Netherlands, so I'm done for day. Sunday I might be able to spent some hours
Federico Caselli
@CaselIT
I'm also a fellow European. Italy :)
Bryan Forbes
@bryanforbes
@zzzeek @jvanasco after creating my own branch and committing to it, should I push that branch to github before running git review, or just run git review?
Federico Caselli
@CaselIT
there is no need to push to github
Bryan Forbes
@bryanforbes
cool
Federico Caselli
@CaselIT
also since you will amend the same commit, pushing makes it annoying since you would need to force push
Bryan Forbes
@bryanforbes
and there’s my first gerrit submission :)
Federico Caselli
@CaselIT
seems that all is in order :)
does mypy integrates with the editor? I mean do you usually run it on the terminal or it has an editor plugin or similar?
Bryan Forbes
@bryanforbes
I run it via coc.nvim
(which is an nvim plugin)
Federico Caselli
@CaselIT
it has an extension to run mypy? (not a vim user here :) )
Bryan Forbes
@bryanforbes
there’s a diagnostic language server that can run mypy
Federico Caselli
@CaselIT
ok.
Bryan Forbes
@bryanforbes
what editor do you use?
Federico Caselli
@CaselIT
vscode
iirc also mike switched to it some time ago, not sure if it has stuck
I've never tried vim as an editor for doing anything serious (other than editing the one off config file on a server somewhere) do you suggest it?
Bryan Forbes
@bryanforbes
vscode has its own type checker, but I would imagine someone has made it so mypy can be run in it
Federico Caselli
@CaselIT
I think it uses pylance, that's an extension of pyright as type checker. I've yet to explore the options though. I have in the default option that is "use the typing if available, but don't show type errors"
as an intellisnse pylance works quite well, sadly it's not open source atm
Federico Caselli
@CaselIT
are you on linux ?
Bryan Forbes
@bryanforbes
macOS