Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 17:40
    zzzeek labeled #7286
  • 17:40
    zzzeek labeled #7286
  • 15:58
    zzzeek review_requested #7381
  • 15:17
    kasium synchronize #7381
  • 14:43
    zzzeek labeled #7286
  • 14:43
    zzzeek labeled #7286
  • 14:41
    zzzeek edited #7388
  • 14:41
    zzzeek labeled #7388
  • 14:41
    zzzeek milestoned #7388
  • 14:41
    zzzeek labeled #7388
  • 14:41
    zzzeek opened #7388
  • 12:09
    CaselIT reopened #7286
  • Nov 30 15:55

    sqlalchemy-bot on rel_1_4

    Fixes: #4390 Deprecated an und… Merge "Fixes: #4390" into rel_1… (compare)

  • Nov 30 15:54
    sqlalchemy-bot closed #4390
  • Nov 30 15:54

    sqlalchemy-bot on main

    Fixes: #4390 Deprecated an und… Merge "Fixes: #4390" into main (compare)

  • Nov 30 15:49

    sqlalchemy-bot on main

    document get_bind() overrides f… Merge "document get_bind() over… (compare)

  • Nov 30 15:49

    sqlalchemy-bot on rel_1_4

    document get_bind() overrides f… Merge "document get_bind() over… (compare)

  • Nov 30 15:48
    zzzeek review_requested #7381
  • Nov 30 15:19
    kasium synchronize #7381
  • Nov 30 15:08
    zzzeek review_requested #7381
mike bayer
@zzzeek
@CaselIT im ina hurry to get this out since i have to go get a vaccine today....
Federico Caselli
@CaselIT
no problem, we can add it to the documentation later
since the website updates every 30minutes
Maico Timmerman
@MaicoTimmerman
@bryanforbes you might want to checkout the https://github.com/python/mypy/blob/master/misc/proper_plugin.py, I'm not sure why it is not exposed in the main library, but I ran it against the sqla mypy plugin and it found 3 issues
Bryan Forbes
@bryanforbes
whoa…
mike bayer
@zzzeek
@CaselIT i just added it
Federico Caselli
@CaselIT
neat!
still fiddling with stuff at work
Bryan Forbes
@bryanforbes
@MaicoTimmerman so I just add that to the plugins in mypy config, right?
(after updating to mypy master…)
mike bayer
@zzzeek
do we know that this plugin linter is current ? it wasnt mentioned to me
Bryan Forbes
@bryanforbes
hmm, it’s not included in a mypy master build either :/
Maico Timmerman
@MaicoTimmerman
Ye, but you need to copy it. I was opening a issue at mypy to ask them to publish it in the mypy package, but I got interrupted
Bryan Forbes
@bryanforbes
:+1:
Maico Timmerman
@MaicoTimmerman
It is not a full linter, from what I understood it just prevents you from doing instance checks on unresolved types
Bryan Forbes
@bryanforbes
@MaicoTimmerman thanks for that tip… I’m doing some cleanup on the plugin right now
Federico Caselli
@CaselIT
i'll try to look at some other stub pr. @MaicoTimmerman if you can lend an hand it would be great!
Maico Timmerman
@MaicoTimmerman
I'm from the Netherlands, so I'm done for day. Sunday I might be able to spent some hours
Federico Caselli
@CaselIT
I'm also a fellow European. Italy :)
Bryan Forbes
@bryanforbes
@zzzeek @jvanasco after creating my own branch and committing to it, should I push that branch to github before running git review, or just run git review?
Federico Caselli
@CaselIT
there is no need to push to github
Bryan Forbes
@bryanforbes
cool
Federico Caselli
@CaselIT
also since you will amend the same commit, pushing makes it annoying since you would need to force push
Bryan Forbes
@bryanforbes
and there’s my first gerrit submission :)
Federico Caselli
@CaselIT
seems that all is in order :)
does mypy integrates with the editor? I mean do you usually run it on the terminal or it has an editor plugin or similar?
Bryan Forbes
@bryanforbes
I run it via coc.nvim
(which is an nvim plugin)
Federico Caselli
@CaselIT
it has an extension to run mypy? (not a vim user here :) )
Bryan Forbes
@bryanforbes
there’s a diagnostic language server that can run mypy
Federico Caselli
@CaselIT
ok.
Bryan Forbes
@bryanforbes
what editor do you use?
Federico Caselli
@CaselIT
vscode
iirc also mike switched to it some time ago, not sure if it has stuck
I've never tried vim as an editor for doing anything serious (other than editing the one off config file on a server somewhere) do you suggest it?
Bryan Forbes
@bryanforbes
vscode has its own type checker, but I would imagine someone has made it so mypy can be run in it
Federico Caselli
@CaselIT
I think it uses pylance, that's an extension of pyright as type checker. I've yet to explore the options though. I have in the default option that is "use the typing if available, but don't show type errors"
as an intellisnse pylance works quite well, sadly it's not open source atm
Federico Caselli
@CaselIT
are you on linux ?
Bryan Forbes
@bryanforbes
macOS
but I’ve used vim for almost 20 years, so I can’t get away from it
I have to use VS Code in a remote VM for a customer, but I install the vim bindings for it so it’s bearable :D
Federico Caselli
@CaselIT
ah yes. I'm used to the vscode bindings
but it's something similar with the keyboard layout. I use the en-us version to program, since the localized ones (it in my case) is a bit of a pain
do you know if the python has wheels specs for the arm version of macos?
Bryan Forbes
@bryanforbes
that I’m not sure
I want to say “yes”, but I can’t say for sure
woo! my gerrit PR passed
Federico Caselli
@CaselIT
I guess we will need to wait for github to have arm macs though, I don't think you can use a normal intel version to compile on arm, and I don't think the docker + qemu we use on linux works for mac
Bryan Forbes
@bryanforbes
and now @CaselIT begins to rip into my PRs :D