Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 17 23:08
    shdai12 edited #923
  • Sep 17 21:30

    sqlalchemy-bot on rel_1_2

    add attribute sphinx is breakin… (compare)

  • Sep 17 21:30

    sqlalchemy-bot on rel_1_3

    add attribute sphinx is breakin… (compare)

  • Sep 17 21:30

    sqlalchemy-bot on master

    add attribute sphinx is breakin… (compare)

  • Sep 17 20:29

    sqlalchemy-bot on master

    vendor asynccontextmanager whi… (compare)

  • Sep 17 18:25
    zzzeek labeled #923
  • Sep 17 18:25
    zzzeek labeled #923
  • Sep 17 18:25
    zzzeek labeled #923
  • Sep 17 18:22
    zzzeek transferred #7046
  • Sep 17 18:22
    shdai12 opened #923
  • Sep 17 18:21
    zzzeek milestoned #7045
  • Sep 17 18:20
    zzzeek labeled #7045
  • Sep 17 18:20
    zzzeek labeled #7045
  • Sep 17 18:20
    zzzeek unlabeled #7045
  • Sep 17 18:20
    zzzeek labeled #7045
  • Sep 17 18:20
    zzzeek labeled #7045
  • Sep 17 18:16
    shdai12 labeled #7046
  • Sep 17 18:16
    shdai12 opened #7046
  • Sep 17 17:58
    kmod opened #7045
  • Sep 17 17:58
    kmod labeled #7045
Federico Caselli
@CaselIT
are you on linux ?
Bryan Forbes
@bryanforbes
macOS
but I’ve used vim for almost 20 years, so I can’t get away from it
I have to use VS Code in a remote VM for a customer, but I install the vim bindings for it so it’s bearable :D
Federico Caselli
@CaselIT
ah yes. I'm used to the vscode bindings
but it's something similar with the keyboard layout. I use the en-us version to program, since the localized ones (it in my case) is a bit of a pain
do you know if the python has wheels specs for the arm version of macos?
Bryan Forbes
@bryanforbes
that I’m not sure
I want to say “yes”, but I can’t say for sure
woo! my gerrit PR passed
Federico Caselli
@CaselIT
I guess we will need to wait for github to have arm macs though, I don't think you can use a normal intel version to compile on arm, and I don't think the docker + qemu we use on linux works for mac
Bryan Forbes
@bryanforbes
and now @CaselIT begins to rip into my PRs :D
Federico Caselli
@CaselIT
still sorting by smallest
:)
secretly hoping mike takes the large ones :)
Bryan Forbes
@bryanforbes
they say that’s the best way to deal with any sort of debt in finances :)
Federico Caselli
@CaselIT
ahah
the Union[] is ugly as sin in python.
Bryan Forbes
@bryanforbes
yeah :/
in 3.10, you’ll be able to use X | Y
Federico Caselli
@CaselIT
un 39 you can use a | b
oh 3.10
Bryan Forbes
@bryanforbes
you can use it in 3.9 if you have from __future__ import annotations, but only in certain spots
same with typings
Federico Caselli
@CaselIT
indeed. 3.9 raises
Bryan Forbes
@bryanforbes
you can do this in 3.9:
from __future__ import annotations

def foo(bar: str | int) -> None:
because annotations aren’t evaluated
Federico Caselli
@CaselIT
do the typing need to be compatible with the py version you target?
Bryan Forbes
@bryanforbes
I forget
let me check
Federico Caselli
@CaselIT
iirc annotation will be always evaluated until 4
Alex Grönholm
@agronholm
no, in 3.10 they're not evaluated
Federico Caselli
@CaselIT
that is also a stupid thing to do by default... they should have made then lazy by default
Bryan Forbes
@bryanforbes
I thought they were going to default to not evaluating in 3.10
Federico Caselli
@CaselIT

no, in 3.10 they're not evaluated

thanks! so there is no longer need to use str for forward refs?

Alex Grönholm
@agronholm
correct
Federico Caselli
@CaselIT
just 5 releases too late I guess
Bryan Forbes
@bryanforbes
X | Y is supported in stubs
we can do a mass change at a later time
there’s another change I’d like to see: removing = … from module-level and class-level variables
@CaselIT I think the docs are wrong for DDLElement.dialect
execute_if(dialect=) says this:
        :param dialect: May be a string, tuple or a callable
          predicate.  If a string, it will be compared to the name of the
          executing database dialect::

            DDL('something').execute_if(dialect='postgresql')

          If a tuple, specifies multiple dialect names::

            DDL('something').execute_if(dialect=('postgresql', 'mysql'))
Bryan Forbes
@bryanforbes
however, _should_execute does this:
    def _should_execute(self, target, bind, **kw):
        if isinstance(self.dialect, util.string_types):
            if self.dialect != bind.engine.name:
                return False
        elif isinstance(self.dialect, (tuple, list, set)):
            if bind.engine.name not in self.dialect:
                return False
        if self.callable_ is not None and not self.callable_(
            self, target, bind, state=self.state, **kw
        ):
            return False

        return True
so dialect is never used as a callable
Federico Caselli
@CaselIT
indeed.
lest's fix it
Bryan Forbes
@bryanforbes
(which is why I didn’t annotate it that way)
Federico Caselli
@CaselIT
i read the docs. see what's happens