Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 08:08
    bigjools labeled #6823
  • 08:08
    bigjools opened #6823
  • Jul 28 19:38
    CaselIT edited #5987
  • Jul 28 18:11
    zzzeek review_requested #334
  • Jul 28 17:53
    CaselIT closed #6820
  • Jul 28 17:53
    CaselIT locked #6820
  • Jul 28 17:14
    jvanasco synchronize #334
  • Jul 28 16:03
    zzzeek milestoned #6821
  • Jul 28 16:03
    zzzeek labeled #6821
  • Jul 28 16:03
    zzzeek labeled #6821
  • Jul 28 16:03
    zzzeek unlabeled #6821
  • Jul 28 15:30
    EvanWMorton labeled #6821
  • Jul 28 15:30
    EvanWMorton opened #6821
  • Jul 28 13:17
    zzzeek labeled #6820
  • Jul 28 12:49
    zzzeek labeled #6820
  • Jul 28 12:49
    zzzeek unlabeled #6820
  • Jul 28 07:29
    franck-serot labeled #6820
  • Jul 28 07:29
    franck-serot opened #6820
  • Jul 27 23:52
    huntfx closed #6811
  • Jul 27 20:47
    jvanasco opened #334
Bryan Forbes
@bryanforbes
woo! my gerrit PR passed
Federico Caselli
@CaselIT
I guess we will need to wait for github to have arm macs though, I don't think you can use a normal intel version to compile on arm, and I don't think the docker + qemu we use on linux works for mac
Bryan Forbes
@bryanforbes
and now @CaselIT begins to rip into my PRs :D
Federico Caselli
@CaselIT
still sorting by smallest
:)
secretly hoping mike takes the large ones :)
Bryan Forbes
@bryanforbes
they say that’s the best way to deal with any sort of debt in finances :)
Federico Caselli
@CaselIT
ahah
the Union[] is ugly as sin in python.
Bryan Forbes
@bryanforbes
yeah :/
in 3.10, you’ll be able to use X | Y
Federico Caselli
@CaselIT
un 39 you can use a | b
oh 3.10
Bryan Forbes
@bryanforbes
you can use it in 3.9 if you have from __future__ import annotations, but only in certain spots
same with typings
Federico Caselli
@CaselIT
indeed. 3.9 raises
Bryan Forbes
@bryanforbes
you can do this in 3.9:
from __future__ import annotations

def foo(bar: str | int) -> None:
because annotations aren’t evaluated
Federico Caselli
@CaselIT
do the typing need to be compatible with the py version you target?
Bryan Forbes
@bryanforbes
I forget
let me check
Federico Caselli
@CaselIT
iirc annotation will be always evaluated until 4
Alex Grönholm
@agronholm
no, in 3.10 they're not evaluated
Federico Caselli
@CaselIT
that is also a stupid thing to do by default... they should have made then lazy by default
Bryan Forbes
@bryanforbes
I thought they were going to default to not evaluating in 3.10
Federico Caselli
@CaselIT

no, in 3.10 they're not evaluated

thanks! so there is no longer need to use str for forward refs?

Alex Grönholm
@agronholm
correct
Federico Caselli
@CaselIT
just 5 releases too late I guess
Bryan Forbes
@bryanforbes
X | Y is supported in stubs
we can do a mass change at a later time
there’s another change I’d like to see: removing = … from module-level and class-level variables
@CaselIT I think the docs are wrong for DDLElement.dialect
execute_if(dialect=) says this:
        :param dialect: May be a string, tuple or a callable
          predicate.  If a string, it will be compared to the name of the
          executing database dialect::

            DDL('something').execute_if(dialect='postgresql')

          If a tuple, specifies multiple dialect names::

            DDL('something').execute_if(dialect=('postgresql', 'mysql'))
Bryan Forbes
@bryanforbes
however, _should_execute does this:
    def _should_execute(self, target, bind, **kw):
        if isinstance(self.dialect, util.string_types):
            if self.dialect != bind.engine.name:
                return False
        elif isinstance(self.dialect, (tuple, list, set)):
            if bind.engine.name not in self.dialect:
                return False
        if self.callable_ is not None and not self.callable_(
            self, target, bind, state=self.state, **kw
        ):
            return False

        return True
so dialect is never used as a callable
Federico Caselli
@CaselIT
indeed.
lest's fix it
Bryan Forbes
@bryanforbes
(which is why I didn’t annotate it that way)
Federico Caselli
@CaselIT
i read the docs. see what's happens
Bryan Forbes
@bryanforbes
:D
Federico Caselli
@CaselIT
fixed
Bryan Forbes
@bryanforbes
@CaselIT I pushed a commit to address your feedback
Federico Caselli
@CaselIT
@zzzeek I've taken another look at the event stuff and ... it's really quite hard to change
I've an idea, but I'll probably need some feedback if that's something useful
Federico Caselli
@CaselIT

@bryanforbes there seems to be a wheel "name" for arm macos. universal2. See https://pypi.org/project/orjson/#files that publishes them

no clue how to create them though. that project uses rust that I think can cross-compile on different architectures

Bryan Forbes
@bryanforbes
@zzzeek as soon as that public API branch in gerrit gets merged, I’m going to start submitting strict mode fixes for the plugin
then I’ll start on a refactor
Maico Timmerman
@MaicoTimmerman
@bryanforbes Did you see my other question as well? https://github.com/sqlalchemy/sqlalchemy2-stubs/pull/59/files#r611092432 Then I can update the PR in a single go